Design and Architecture

Christian Graus wrote:

I don't see how it's useful to NOT know what you're about to pull the trigger on.

VuNic wrote:

I have a set of ammunition. Anti-aircraft guns, fire shells, Launch missiles,
etc etc. but all these are "mutually exclusive".
 
If I would like to
mount the ship with Anti-aircraft guns, all other ammo go unusable. I can
dynamically swap between available ammo.

class BattleShip
{
    void MountAndFire(AmmoBase ammo_in)
    {

        //if it's a gun,
        //int ammo_in.Fire(numberofrounds:30);  //returns remaining ammo

        // if it's a missle launcher:
        Fire(new FireArgsMissile { direction = 120, distance = 200 }); // return ammount of heat it generated on the ship

        //cluster bomb
        //  int ammo_in.Fire(Numberofcluster:600, direction:120, Distance:200);// Returns something else

    }
    int Fire(FireArgs a)
    {
        return a.Fire();
    }

}
public class FireArgs
{
    public int Fire()
    {
        return 0;
    }
}
public class FireArgsMissile : FireArgs
{
    public int direction { get; set; }
    public int distance { get; set; }
}

public abstract class AmmoBase
{
    public abstract int Fire(FireArgs a);
}

public class Missile : AmmoBase
{
    public override int Fire(FireArgs a)
    {
        return 0;
    }
}

Bastard Programmer from Hell
If you can't read my code, try converting it here[^]
They hate us for our freedom![^]

interface IShip : IName
{
  IEnumerator<IGun> GunEnumerator
  {
    get;
  }

  IGun ActiveGun
  {
     get;
  }

  void ActivateGun(IGun gun);

  IAmmoInventory AmmoInventory
  {
    get;
  }
}

interface IGun : IName
{
  // point at something
  bool Aim(Vector3 directionLocal);
  
  // IGun knows its parent - IShip - with IAmmoInventory
  bool Fire();

}

interface IAmmoInventory
{
  IEnumerator<IAmmo> AmmoEnumerator
  {
    get;
  }

  void SelectAmmo(IAmmo ammo);

  IAmmo SelectedAmmo
  {
     get;
  }

  bool Add(IAmmo ammo);

  bool Remove(IAmmo ammo);
}

interface IAmmo : IName
{

  int Damage
  {
    get;
  }

  int Count
  {
     get;
  }
}

interface IName
{
  string Name
  {
    get;
  }
}