Click here to Skip to main content
14,362,338 members

Welcome to the Lounge

   

For discussing anything related to a software developer's life but is not for programming questions. Got a programming question?

The Lounge is rated Safe For Work. If you're about to post something inappropriate for a shared office environment, then don't post it. No ads, no abuse, and no programming questions. Trolling, (political, climate, religious or whatever) will result in your account being removed.
 
GeneralRe: Maybe we DO need professionals licensing Pin
Mark_Wallace3-Jul-19 9:42
memberMark_Wallace3-Jul-19 9:42 
GeneralRe: Maybe we DO need professionals licensing Pin
decaffeinatedMonkey4-Jul-19 3:04
memberdecaffeinatedMonkey4-Jul-19 3:04 
GeneralRe: Maybe we DO need professionals licensing Pin
David Crow3-Jul-19 10:48
memberDavid Crow3-Jul-19 10:48 
GeneralRe: Maybe we DO need professionals licensing Pin
Joe Woodbury3-Jul-19 16:58
professionalJoe Woodbury3-Jul-19 16:58 
GeneralRe: Maybe we DO need professionals licensing Pin
Sander Rossel3-Jul-19 23:39
professionalSander Rossel3-Jul-19 23:39 
GeneralRe: Maybe we DO need professionals licensing Pin
Slow Eddie4-Jul-19 5:37
professionalSlow Eddie4-Jul-19 5:37 
GeneralRe: Maybe we DO need professionals licensing Pin
obermd4-Jul-19 10:21
memberobermd4-Jul-19 10:21 
GeneralRe: Maybe we DO need professionals licensing Pin
Sander Rossel4-Jul-19 11:57
professionalSander Rossel4-Jul-19 11:57 
Slow Eddie wrote:
all of the people in this post would be surprised at what another programmer would find to criticize and complain about in his or her code
I try to make a difference between "facts" and "preference".
For example:
// My style
public void DoSomething(string input)
{
   // Code...
}

// Someone else's style
public void do_something ( string input ) {

   // Code...

}
My code is C# style, the other isn't. It's some sort of Java(Script)ish with some extra space.
But it's still (more or less) the same code.
I'd probably tell this person something about C# coding styles and I'd enforce some default coding style (at least to normalize the casing).
When a team uses different coding styles it tends to mess up your source control (because of automatic styling, which makes it look like everyone is changing complete files even when just a single line was fixed), so it's still important, but not necessarily wrong.

Then there's this:
// My code
try
{
   using (var connection = new SqlConnection(connString))
   using (var command = connection.CreateCommand())
   {
      command.CommandText = "...WHERE Id = @Id";
      // Etc...
   }
}
catch (Exception ex)
{
   logger.LogError(ex);
   throw;
}

// Someone else's code
try
{
   var connection = new SqlConnection(connString);
   var command = connection.CreateCommand();
   command.CommandText = "...WHERE Id = " + id;
   // Etc...
}
catch (Exception ex)
{
   logger.LogError(ex);
}
Now we're talking about different code, good code and BAD code!
Some people would say usage of var is bad practice, but that's what I consider style (after all, compiled it's still the same).
However, every skilled programmer would notice the lack of using (or alternatively Dispose in a finally block), the swallowing of the Exception and the potential SQL injection.
This isn't a matter of style, it's a matter of factually good and bad code.

So when we're talking about people here I expect to find lots of different preferences which may not be mine (and which I might even find horrible to read), but I expect to find little actual errors.
For some reason I tend to think that people who are on CodeProject know the difference between good code and bad code, whatever their style may be Smile | :)

GeneralRe: Maybe we DO need professionals licensing Pin
Member 118167764-Jul-19 1:53
memberMember 118167764-Jul-19 1:53 
GeneralRe: Maybe we DO need professionals licensing Pin
Nelek4-Jul-19 2:03
protectorNelek4-Jul-19 2:03 
GeneralRe: Maybe we DO need professionals licensing Pin
Daniel Wilianto4-Jul-19 6:49
memberDaniel Wilianto4-Jul-19 6:49 
GeneralRe: Maybe we DO need professionals licensing Pin
agolddog5-Jul-19 4:37
memberagolddog5-Jul-19 4:37 
GeneralRe: Maybe we DO need professionals licensing Pin
PNutHed5-Jul-19 7:18
memberPNutHed5-Jul-19 7:18 
GeneralRe: Maybe we DO need professionals licensing Pin
rjmoses6-Jul-19 10:25
professionalrjmoses6-Jul-19 10:25 
GeneralRe: Maybe we DO need professionals licensing Pin
PNutHed8-Jul-19 8:34
memberPNutHed8-Jul-19 8:34 
GeneralRe: Maybe we DO need professionals licensing Pin
rjmoses9-Jul-19 1:12
professionalrjmoses9-Jul-19 1:12 
GeneralRe: Maybe we DO need professionals licensing Pin
Member 916705715-Jul-19 0:24
memberMember 916705715-Jul-19 0:24 
GeneralYou learn something new every day... (and I'm putting this on my résumé!) Pin
Sander Rossel3-Jul-19 1:56
professionalSander Rossel3-Jul-19 1:56 
GeneralRe: You learn something new every day... (and I'm putting this on my résumé!) Pin
Johnny J.3-Jul-19 2:18
professionalJohnny J.3-Jul-19 2:18 
GeneralRe: You learn something new every day... (and I'm putting this on my résumé!) Pin
OriginalGriff3-Jul-19 2:26
protectorOriginalGriff3-Jul-19 2:26 
GeneralRe: You learn something new every day... (and I'm putting this on my résumé!) Pin
Peter Shaw4-Jul-19 2:17
professionalPeter Shaw4-Jul-19 2:17 
GeneralRe: You learn something new every day... (and I'm putting this on my résumé!) Pin
OriginalGriff4-Jul-19 2:26
protectorOriginalGriff4-Jul-19 2:26 
GeneralRe: You learn something new every day... (and I'm putting this on my résumé!) Pin
Peter Shaw4-Jul-19 4:26
professionalPeter Shaw4-Jul-19 4:26 
GeneralRe: You learn something new every day... (and I'm putting this on my résumé!) Pin
jsc423-Jul-19 2:59
professionaljsc423-Jul-19 2:59 
GeneralRe: You learn something new every day... (and I'm putting this on my résumé!) Pin
Fueled By Caffeine3-Jul-19 3:27
memberFueled By Caffeine3-Jul-19 3:27 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.