Welcome to the Lounge

honey the codewitch wrote:

you haven't lived died inside until you've used a dictionary keyed by collections of collections.

honey the codewitch wrote:

collection equality comparison

honey the codewitch wrote:

it implements System.IProgress<T>

honey the codewitch wrote:

You should see my _LRItemSetComparer class. It's awful.

honey the codewitch wrote:

to drive you to drink.

Sander Rossel wrote:

lack of braces and leading underscores

for(int ic=Count,i=0;i<ic;++i)
{
    foreach(var kvp in this[i])
    {
        if (!nts.Contains(kvp.Value.Left))
            nts.Add(kvp.Value.Left);
    }
}

for(int ic=Count,i=0;i<ic;++i)
    foreach(var kvp in this[i])
        if (!nts.Contains(kvp.Value.Left))
            nts.Add(kvp.Value.Left);

Jon McKee wrote:

Now tremble before me

if (whatever)
    DoSomething();
    DoSomethingElse();
    DoAThirdThing();

Sander Rossel wrote:

I want to think about what my code is doing and should be doing

Jon McKee wrote:

on the flip-side you can accidentally add code inside a brace that isn't meant to be looped (albeit probably less common)

Jon McKee wrote:

braces vs no braces is exactly a specification of what the code should or should not be doing on a static basis

if (x)
//   DoSomething(); Commented out for now.
AlwaysDoThis();

if (x)
   if (y)
      DoSomething();
   else
      DoSomethingElse();

Sander Rossel wrote:

Only as you said, should do one thing vs. should do x things, but that's something that changes with specs, and both can be easily changed.
The difference is that when the specs are changed to "if x do y and now also z" the code with braces is almost certain to be changed correctly, but without braces that change is more likely to cause a bug.

//if (x)
//   DoSomething(); Commented out for now.
AlwaysDoThis();

if (x)
{
//   DoSomething(); Commented out for now.
}
AlwaysDoThis();

if (x)
{
   if (y)
      DoSomething();
   else
      DoSomethingElse();
}

							}
						}
					}
				}
			}
		}
        ++i;
	}
}

void ProcessThing(Thing thingy)
{
   try
   {
      ProcessFoos(thingy.Foos);
   }
   catch (Exception ex)
   {
      // Handle error.
   }
}

void ProcessFoos(List<Foo> foos)
{
   foreach (var foo in foos)
   {
      ProcessBars(foo.Bars);
   }
}

void ProcessBars(List<Bar> bars)
{
   foreach (var bar in bars)
   {
      ProcessStuff(bar.Stuff);
   }
}

// ...