C#

1. The you should add the parameters before the loop
2. The values of the parameters should be set inside the loop
3. The ExecuteNonQuery should happen inside the loop for each item

public void UpdateMessageToIncludeMarkedNumber()
{    SqlCommand cmd = new SqlCommand();
    //.......
    for (int t = 0; t < Set10bytesMessage.Count; t++)
    {
        MarkedNumber mNumber = (MarkedNumber)Set10bytesMessage[t];
        for (int f = 0; f < Set30bytesMessage.Count; f++)
        {
                VopMessage vms = (VopMessage)Set30bytesMessage[f];
                if (mNumber.Byte4 == vms.Byte24 & mNumber.Byte5 == vms.Byte4)
                {
                    <big>//You repeatedly add the parameters here, not allowed</big>
                }
                //.......
            }
        }
        con.Open();
        <big>//You execute here: once!</big>
        cmd.ExecuteNonQuery();
        con.Close();
     }
}

Eddy Vluggen wrote:

wouldn't clearing the Parameters collection more efficient?

Mark Nischalke wrote:

After clearing the collection you would need to add the parameters again, creating more objects each time the loop runs.

I are Troll

if (mNumber.Byte4 == vms.Byte24 && mNumber.Byte5 == vms.Byte4)

SqlCommand cmd = new SqlCommand();
cmd.CommandText = "update VopMessage_tbl set MarkedNumber=@MarkedNumber  where Byte24=@Byte24 and Byte4=@Byte4";
cmd.Connection = con;
cmd.Parameters.Add("@Byte24", ...);
cmd.Parameters.Add("@Byte4", ...);
cmd.Parameters.Add("@MarkedNumber", ...);

cmd.Parameters["@Byte24"] = vms.Byte24;
cmd.Parameters["@Byte4"] = vms.Byte4;
string All2BytesOfTwoMarkedNumber = mNumber.Byte4 + mNumber.Byte5;
cmd.Parameters["@MarkedNumber"] = All2BytesOfTwoMarkedNumber;

cmd.ExecuteNonQuery();

using(SqlCommand cmd = new SqlCommand("update VopMessage_tbl set MarkedNumber=@MarkedNumber  where Byte24=@Byte24 and Byte4=@Byte4", conn)
{

}

PropertyInfo[] myPropertyInfo;
// Get the properties of 'Type' class object.
myPropertyInfo = Type.GetType("System.Type").GetProperties();

string x = "";<br />
x.GetType().GetProperties()