Re: Socket chat client & Server help - C# Discussion Boards

21-Jan-13 11:52

Hey I have problem running my code, the client seems to not connect with the server, hope someone can help me I have been trying to fix this out for 5 days now.

2 Projects. sockerServer contain a client class and socketClient with chatroom GUI

sockerServer

using System.Windows.Forms;
using System.Net.Sockets;
using System.Threading;
using System.Collections;
using System.Net;

namespace SocketServer
{
    public delegate void LogUpdater(string msg);

    public partial class Form1 : Form
    {
        ////Private Variables
       
        private Thread serverThread;
        private TcpListener serverListener;
        private Hashtable clientTable;

        
        public Form1()
        {
            InitializeComponent();
            clientTable = new Hashtable();
            //Start a thread on the startListen method
            serverThread = new Thread(new ThreadStart(startListen));
            serverThread.Start();
            AddLog("Socket Server Started");
        }
        public void startListen()
        {
            try
            {
                //Start the tcpListner
                serverListener = new TcpListener(IPAddress.Any, 5151);
                serverListener.Start();
                do
                {
                    //Create a new class when a new Chat Client connects
                    Client newClient = new Client(serverListener.AcceptTcpClient());
                    //Attach the Delegates
                    newClient.Disconnected += new DisconnectDelegate(OnDisconnected);
                    newClient.Connected += new ConnectDelegate(this.OnConnected);
                    newClient.MessageReceived += new MessageDelegate(OnMessageReceived);
                    //Connect to the clients
                    newClient.Connect();
                }
                while (true);
            }
            catch
            {
                serverListener.Stop();
            }
        }
        //EvntsHandler fo the Connected event
        public void OnConnected(object sender, EventArgs e)
        {
            //Get the client that raised the vent
            Client temp = (Client)sender;
            //Add the client to the Hashtable
            clientTable.Add(temp.ID, temp);
            Client tempClient;
            AddLog("Client Connected:" + temp.UserName);
            //loop through each client and announce the 
            //client connected
            foreach (DictionaryEntry d in clientTable)
            {
                tempClient = (Client)d.Value;
                tempClient.Send(tempClient.ID + "@Connected@" + temp.UserName);
            }
        }

        public void OnDisconnected(object sender, EventArgs e)
        {
            //Get the Client that raised the Event
            Client temp = (Client)sender;
            //If the Client exists in the Hashtable
            if (clientTable.ContainsKey(temp.ID))
            {
                AddLog("Client Disconnected:" + temp.UserName);
                //Remove the client from the hashtable
                clientTable.Remove(temp.ID);
                //Remove the client from the ClientList class
                ClientList.RemoveClient(temp.UserName, temp.ID);
                Client tempClient;
                //Announce to all the existing clients
                foreach (DictionaryEntry d in clientTable)
                {
                    tempClient = (Client)d.Value;
                    tempClient.Send(tempClient.ID + "@Disconnected@" + temp.UserName);
                }
            }
        }
        public void OnMessageReceived(object sender, MessageEventArgs e)
        {
            //Message sender client
            Client temp = (Client)sender;
            AddLog(temp.UserName + " :" + e.Message);
            Client tempClient;
            //Send the message to each client
            foreach (DictionaryEntry d in clientTable)
            {
                tempClient = (Client)d.Value;
                tempClient.Send(temp.UserName + " :" + e.Message);
            }
        }
        //Method to add the string to the server log
        public void AddLog(string msg)
        {
            logBox.Items.Add(msg);
        }

        private void Form1_Closing(object sender, System.ComponentModel.CancelEventArgs e)
        {
            serverListener.Stop();
        }
    }
}

The Class

using System.Collections;
using System.Net;
using System.Net.Sockets;
using System.Threading;

namespace SocketServer
{
    public delegate void ConnectDelegate(object sender, EventArgs e);
    public delegate void DisconnectDelegate(object sender, EventArgs e);
    public delegate void MessageDelegate(object sender, MessageEventArgs e);

    public class MessageEventArgs : EventArgs
    {
        private string msg;
        public string Message
        {
            get
            {
                return this.msg;
            }
            set
            {
                this.msg = value;
            }
        }
    }

    public class Client
    {
        //Events Defination
        public event ConnectDelegate Connected;
        public event DisconnectDelegate Disconnected;
        public event MessageDelegate MessageReceived;
        //Some Variables
        private bool firstTime = true;
        private bool connected = false;
        private byte[] recByte = new byte[1024];
        private StringBuilder myBuilder = new StringBuilder();
        private TcpClient myClient;
        private string userName, clientID;

        public Client(TcpClient myClient)
        {
            this.myClient = myClient;
        }
        //Connect method used to connect to Client
        public void Connect()
        {

            //Assign a new Guid
            this.clientID = Guid.NewGuid().ToString();
            //Start Receiving the Messages
            AsyncCallback GetStreamMsgCallback = new AsyncCallback(GetStreamMsg);
            myClient.GetStream().BeginRead(recByte, 0, 1024, GetStreamMsgCallback, null);
        }

        public string UserName
        {
            get
            {
                return this.userName;
            }
        }

        public string ID
        {
            get
            {
                return this.clientID;
            }
        }

        public void GetStreamMsg(IAsyncResult ar)
        {
            int intCount;
            try
            {
                //Lock the Client Stream
                lock (myClient.GetStream())
                {
                    //Receive the Bytes
                    intCount = myClient.GetStream().EndRead(ar);
                }
                if (intCount < 1)
                {
                    //If a value less than 1 received that means that 
                    //client disconnected
                    myClient.Close();
                    //raise the Disconnected Event
                    if (Disconnected != null)
                    {
                        EventArgs e = new EventArgs();
                        Disconnected(this, e);
                    }
                }
                //Send the received message from processing
                BuildText(recByte, 0, intCount);
                if (!firstTime)
                {
                    //if its not the first time then restart the listen process
                    lock (myClient.GetStream())
                    {
                        AsyncCallback GetStreamMsgCallback = new AsyncCallback(GetStreamMsg);
                        myClient.GetStream().BeginRead(recByte, 0, 1024, GetStreamMsgCallback, null);
                    }
                }
            }
            catch
            {
                myClient.Close();
                if (Disconnected != null)
                {
                    EventArgs e = new EventArgs();
                    Disconnected(this, e);
                }
            }
        }

        public void Disconnect()
        {
            this.connected = false;
            myClient.Close();
        }
        //Method that takes the Usernam and does some processing
        public void CheckUserName(string userName)
        {
            if (userName.Length > 20)
            {
                Send("sorry@Username too long, enter a Username less than 20 Characters!!");
                Disconnect();
                return;
            }
            else if (userName.IndexOf("@") >= 0)
            {
                Send("sorry@Invalid Character in Username!!");
                Disconnect();
                return;
            }
            else if (!ClientList.AddClient(userName, this.clientID))
            {
                //Check if the username is duplicate
                Send("sorry@Duplicate Username, try another Username!!");
                Disconnect();
                return;
            }
            else
            {
                //If name is not duplicate then the client is connected
                this.connected = true;
                this.userName = userName;
                //Build the Usernames list and send it to the client
                StringBuilder userList = new StringBuilder();
                userList.Append(this.clientID);
                Hashtable clientTable = ClientList.GetList;
                foreach (DictionaryEntry d in clientTable)
                {
                    //Seperate the usernames by a '@'
                    userList.Append("@");
                    userList.Append(d.Value.ToString());
                }
                //Start the llistening
                lock (myClient.GetStream())
                {
                    AsyncCallback GetStreamMsgCallback = new AsyncCallback(GetStreamMsg);
                    myClient.GetStream().BeginRead(recByte, 0, 1024, GetStreamMsgCallback, null);
                }
                //Send the Userlist
                Send(userList.ToString());
                //Raise the Connected Event
                if (Connected != null)
                {
                    EventArgs e = new EventArgs();
                    Connected(this, e);
                }
            }
        }

        //Method to process the Messages
        public void BuildText(byte[] dataByte, int offset, int count)
        {

            for (int i = 0; i < count; i++)
            {
                //Check is a line terminator is encountered
                if (dataByte[i] == 13)
                {

                    if (firstTime)
                    {
                        //If first time then call the CheckUserName method
                        CheckUserName(myBuilder.ToString().Trim());
                        firstTime = false;
                    }
                    else if (MessageReceived != null && connected)
                    {
                        //Else raise the MessageReceived Event 
                        //and pass the message along
                        MessageEventArgs e = new MessageEventArgs();
                        e.Message = (myBuilder.ToString()).Trim();
                        MessageReceived(this, e);
                    }
                    //Clear the StringBuilder
                    myBuilder = new System.Text.StringBuilder();
                }
                else
                {
                    //Append the Byte to the StringBuilder
                    myBuilder.Append(Convert.ToChar(dataByte[i]));
                }
            }
        }

        //Method to send the message
        public void Send(string msg)
        {
            lock (myClient.GetStream())
            {
                System.IO.StreamWriter myWriter = new System.IO.StreamWriter(myClient.GetStream());
                myWriter.Write(msg);
                myWriter.Flush();
            }
        }
    }

    //Class to maintain the Userlist
    public class ClientList
    {
        private static Hashtable clientTable = new Hashtable();

        //Method to add a new user
        public static bool AddClient(string userName, string id)
        {
            lock (clientTable)
            {
                //If username exists return false
                if (clientTable.ContainsValue(userName))
                {
                    return false;
                }
                else
                {
                    //Or add the username to the list and return true
                    clientTable.Add(id, userName);
                    return true;
                }
            }
        }

        //Method to remove the user
        public static bool RemoveClient(string userName, string id)
        {
            lock (clientTable)
            {
                if (clientTable.ContainsValue(userName))
                {
                    clientTable.Remove(id);
                    return true;
                }
                else
                {
                    return false;
                }
            }
        }
        //Property to get the Users list
        public static Hashtable GetList
        {
            get
            {
                return clientTable;
            }
        }

    }
}

using System.Windows.Forms;
using System.Net.Sockets;
using System.Net;
using System.Threading;
using System.Collections;


namespace SocketClient
{
    public delegate void displayMessage(string msg);

    public partial class Form1 : Form
    {
        //Some required Variables
        private string userID, userName;
        //Flag to check if this is the first communication with the server
        bool firstTime = true;
        private TcpClient chatClient;
        private byte[] recByte = new byte[1024];
        private StringBuilder myBuilder;
        public Form1()
        {
            InitializeComponent();
            myBuilder = new System.Text.StringBuilder();
        }
        //Method use to process incomming messages
        public void GetMsg(IAsyncResult ar)
        {
            int byteCount;
            try
            {
                //Get the number of Bytes received
                byteCount = (chatClient.GetStream()).EndRead(ar);
                //If bytes received is less than 1 it means
                //the server has disconnected
                if (byteCount < 1)
                {
                    //Close the socket
                    Disconnect();
                    MessageBox.Show("Disconnected!!");
                    return;
                }
                //Send the Server message for parsing
                BuildText(recByte, 0, byteCount);
                //Unless its the first time start Asynchronous Read
                //Again
                if (!firstTime)
                {
                    AsyncCallback GetMsgCallback = new AsyncCallback(GetMsg);
                    (chatClient.GetStream()).BeginRead(recByte, 0, 1024, GetMsgCallback, this);
                }
            }
            catch (Exception ed)
            {
                Disconnect();
                MessageBox.Show("Exception Occured :" + ed.ToString());
            }
        }

        //Method to Process Server Response
        public void BuildText(byte[] dataByte, int offset, int count)
        {
            //Loop till the number of bytes received
            for (int i = offset; i < (count); i++)
            {
                //If a New Line character is met then
                //skip the loop cycle
                if (dataByte[i] == 10)
                    continue;
                //Add the Byte to the StringBuilder in Char format
                myBuilder.Append(Convert.ToChar(dataByte[i]));
            }
            char[] spliters = { '@' };
            //Check if this is the first message received
            if (firstTime)
            {
                //Split the string received at the occurance of '@'
                string[] tempString = myBuilder.ToString().Split(spliters);
                //If the Server sent 'sorry' that means there was some error
                //so we just disconnect the client
                if (tempString[0] == "sorry")
                {
                    object[] temp = { tempString[1] };
                    this.Invoke(new displayMessage(DisplayText), temp);
                    Disconnect();
                }
                else
                {
                    //Store the Client Guid 
                    this.userID = tempString[0];
                    //Loop through array of UserNames
                    for (int i = 1; i < tempString.Length; i++)
                    {
                        object[] temp = { tempString[i] };
                        //Invoke the AddUser method
                        //Since we are working on another thread rather than the primary 
                        //thread we have to use the Invoke method
                        //to call the method that will update the listbox
                        this.Invoke(new displayMessage(AddUser), temp);
                    }
                    //Reset the flag
                    firstTime = false;
                    //Start the listening process again 
                    AsyncCallback GetMsgCallback = new AsyncCallback(GetMsg);
                    (chatClient.GetStream()).BeginRead(recByte, 0, 1024, GetMsgCallback, this);
                }

            }
            else
            {
                //Generally all other messages get passed here
                //Check if the Message starts with the ClientID
                //In which case we come to know that its a Server Command
                if (myBuilder.ToString().IndexOf(this.userID) >= 0)
                {
                    string[] tempString = myBuilder.ToString().Split(spliters);
                    //If its connected command then add the user to the ListBox
                    if (tempString[1] == "Connected")
                    {
                        object[] temp = { tempString[2] };
                        this.Invoke(new displayMessage(AddUser), temp);
                    }
                    else if (tempString[1] == "Disconnected")
                    {
                        //If its disconnected command then remove the 
                        //username from the list box
                        object[] temp = { tempString[2] };
                        this.Invoke(new displayMessage(RemoveUser), temp);
                    }
                }
                else
                {
                    //For regular messages append a Line terminator
                    myBuilder.Append("\r\n");
                    object[] temp = { myBuilder.ToString() };
                    //Invoke the DisplayText method
                    this.Invoke(new displayMessage(DisplayText), temp);
                }
            }
            //Empty the StringBuilder
            myBuilder = new System.Text.StringBuilder();
        }

        //Method to remove the user from the ListBox
        private void RemoveUser(string user)
        {
            if (userlistBox.Items.Contains(user))
                userlistBox.Items.Remove(user);
            //Display the left message
            DisplayText(user + " left chat\r\n");
        }

        //Method to Add a user to the ListBox
        private void AddUser(string user)
        {
            if (!userlistBox.Items.Contains(user))
                userlistBox.Items.Add(user);
            //If not for first time then display a connected message
            if (!firstTime)
                DisplayText(user + " joined chat\r\n");
        }
        //Method to send a message to the server
        public void SendText(string msg)
        {
            //Get a StreamWriter 
            System.IO.StreamWriter chatWriter = new System.IO.StreamWriter(chatClient.GetStream());
            chatWriter.WriteLine(msg);
            //Flush the stream
            chatWriter.Flush();
        }

        //Method to Display Text in the TextBox
        public void DisplayText(string msg)
        {
            msgViewBox.AppendText(msg);
        }

        private void sendButton_Click(object sender, EventArgs e)
        {
            if (sendBox.Text != "")
            {
                //Send Message
                SendText(sendBox.Text);
                sendBox.Text = "";
            }
        }
        private void Disconnect()
        {
            if (chatClient != null)
            {
                chatClient.Close();
                chatClient = null;
            }
            //Reset the Buttons and Variables
            userlistBox.Items.Clear();
            sendButton.Enabled = false;
            connectButton.Text = "Connect";
            usernameBox.Enabled = true;
            sendBox.Enabled = false;
            this.AcceptButton = connectButton;
            firstTime = true;
            userID = "";
        }

        private void connectButton_Click(object sender, EventArgs e)
        {

            //If user Cliked Connect
            if (connectButton.Text == "Connect" && usernameBox.Text != "")
            {
                try
                {
                    //Connect to server
                    chatClient = new TcpClient("localhost", 5151);
                    DisplayText("Connecting to Server ...\r\n");
                    //Start Reading
                    AsyncCallback GetMsgCallback = new AsyncCallback(GetMsg);
                    (chatClient.GetStream()).BeginRead(recByte, 0, 1024, GetMsgCallback, null);
                    //Send the UserName
                    SendText(usernameBox.Text);
                    this.userName = usernameBox.Text;
                    this.Text = "Chat Client :" + userName;
                    usernameBox.Text = "";
                    connectButton.Text = "Disconnect";
                    usernameBox.Enabled = false;
                    sendButton.Enabled = true;
                    sendBox.Enabled = true;
                    this.AcceptButton = sendButton;
                }
                catch
                {
                    Disconnect();
                    MessageBox.Show("Can't connect to Server...");
                }
            }
            else if (connectButton.Text == "Disconnect")
            {
                Disconnect();
            }

        }

    }
}

Eddy Vluggen21-Jan-13 13:00

21-Jan-13 13:00

Dioblos wrote:
the client seems to not connect with the server

What does that mean? Did you get an exception? If yes, what did it say?

Also check your firewall and router, might be blocking the port you're talking on.

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]
They hate us for our freedom![^]

Dioblos21-Jan-13 13:24

21-Jan-13 13:24

That when I click on the connect button on the Cleint, nothing happens at all, and yes I have checked the firewall and router, I have also tried to run the projekt on other computers but didn't work...So you mean there is nothing wrong with the code?

Eddy Vluggen21-Jan-13 13:37

21-Jan-13 13:37

Dioblos wrote:
So you mean there is nothing wrong with the code?

I'm too lazy to check, nothing obvious; if you don't get any exceptions, nothing is wrong. So, what was that exception-message again? Smile | :)

"It doesn't work" doesn't explain much.

There's an example online[^] in the docs, if you want to verify your code against the example.

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]
They hate us for our freedom![^]

Dioblos21-Jan-13 14:30

21-Jan-13 14:30

Well nothing happend when I click on the connect button on the Client... Nothing at all, You want me to send you the project?

Eddy Vluggen21-Jan-13 14:42

21-Jan-13 14:42

Dioblos wrote:
Well nothing happend when I click on the connect button on the Client... Nothing at all

Not even the message "Connecting to Server ..."? Are you running it from an IDE or standalone? You're running both a client AND a server? (otherwise, nothing would happen)

Dioblos wrote:
You want me to send you the project?

You already posted the entire project, as it seems Smile | :)

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]
They hate us for our freedom![^]

Dioblos21-Jan-13 14:49

21-Jan-13 14:49

Yes Dude ofcorse!! Im running i from the bin/Debug mapp and starting with the server... This is basic I know how it should starts

Eddy Vluggen21-Jan-13 14:56

21-Jan-13 14:56

Hehe, I like the reaction; so you're sure you have two applications running? Both a client and a server? Smile | :)

You should at least see a message "Connecting to Server ..." appearing. Does it not? Explain with lots o' details, it might not only be helpful to me, but for others as well.

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]
They hate us for our freedom![^]

Dioblos21-Jan-13 15:01

21-Jan-13 15:01

Yes ofcorse Im running both client and server comman dude Im not stupid Wink | ;)

!! No I don't see any connection or something as I said!! Nothing is happening at all when I Click on the Connection button on the Client GUI.. If you are that good let me send you the projekt and you can run and se by yourself

Dave Kreskowiak21-Jan-13 15:58

Dave Kreskowiak

21-Jan-13 15:58

You don't have to send it to anyone. Just set a breakpoint on the Click event handler of your "Connect" button and hit F11 to step through your code line-by-line to see what's happening.

A guide to posting questions on CodeProject[^]

Dave Kreskowiak

pt140121-Jan-13 19:55

pt1401

21-Jan-13 19:55

Are you sure your Connect button is even wired up to your event handler?
I know you said you're not stupid, but that's the only way I can see that you won't get a message saying either "Connecting to server..." or "Can't connect to server...".

Slightly off-topic, I can only think that the only reason people use sockets is that they've never come across ZeroMQ. See this thread:-
http://www.codeproject.com/Forums/1649/Csharp.aspx?fid=1649&fr=276#xx0xx[^]

modified 22-Jan-13 2:14am.

J4amieC21-Jan-13 21:47

J4amieC

21-Jan-13 21:47

Regarding the handler for the connect button.

if (connectButton.Text == "Connect" && usernameBox.Text != "")

When you set a breakpoint on that line (You have set a breakpoint and stepped through your code, right? You said you know the basics!) What is the value of connectButton.Text and usernameBox.Text?

Dioblos22-Jan-13 4:54

22-Jan-13 4:54

I did and got a message window from VS

Entering break mode failed for the following reason: Sourse file C\Users\*********\Program.cs does not belong to the project being debugged

Usually, this condition occurs when the project was not rebuilt prior to starting the debugging session, when the assembly file for the prohect is out of date, or when the oroject source files wre moved to a different disk location between the time the project was built and the debugging session was started

J4amieC22-Jan-13 5:25

J4amieC

22-Jan-13 5:25

So you "know the basics" but you are clueless on how to debug your program?!?

Richard MacCutchan21-Jan-13 22:25

Richard MacCutchan

21-Jan-13 22:25

Put a breakpoint on the line :

if (connectButton.Text == "Connect" && usernameBox.Text != "")

and see what happens when you click the button.

pt140122-Jan-13 3:26

pt1401

22-Jan-13 3:26

Hmmm...all gone quiet.
I suspect he's now realised that he's dropped a clanger & not wired up his event handler Smile | :)

C# 2010 object

dcof21-Jan-13 8:57

dcof

21-Jan-13 8:57

In a C# 2010 desktop application I have the following line of code that gets executed continually from calling a mthod:

Attachment att = helper.createAttachmentFromInput(strExcelLocation);

This method never complains about the 'att' object already existing. I never set the value to null.

This may not be causing an issue since when the method goes out of scope, the object is destroyed?

Can you tell me if my assumption is correct or not? Can you also explain your answer to me?

Re: C# 2010 object

Jibesh21-Jan-13 12:00

Jibesh

21-Jan-13 12:00

Quote:
This may not be causing an issue since when the method goes out of scope, the object is destroyed?

because the variable 'att' is declared as a local variable in your application and its scope is limited to that function/method block. when your application completes the execution of this method 'att' goes out of scope, and destroys.

Also the 'att' object life cycle is based on how this object is constructed inside the method 'createAttachmentFromInput'.If createAttachmentFromInput method returns a new instance of 'Attachement' and does not maintain a reference of the same within the helper class the 'att' will destroy the instance when it reaches out of scope.

Jibesh V P

Re: C# 2010 object

Eddy Vluggen21-Jan-13 13:01

21-Jan-13 13:01

dcof wrote:
This may not be causing an issue since when the method goes out of scope, the object is destroyed?

Where does it go out of scope? Find the next "}", and you'll know.

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]
They hate us for our freedom![^]

Re: C# 2010 object

Freak3021-Jan-13 21:53

Freak30

21-Jan-13 21:53

Assuming you aren't using a using statement the object will not be destructed immediately when going out of scope. The garbage collector will take care of the unreferenced Attachment objects from time to time.

C#.net with postGis

tashee21-Jan-13 3:47

tashee

21-Jan-13 3:47

Hello,

I need to create a desktop application using C# as frontend and postgresql/postgis for the database.
I have google maps V3 embedded into web browser control.
My question is, is there any way to visualize geometry column of postgis into google maps using C#.

Thanks in advance

Re: C#.net with postGis

Eddy Vluggen21-Jan-13 13:03