Re: c#Move music files in listbox up or down - C# Discussion Boards

27-Oct-17 5:00

Thank you all for taking your time to help.

Had an issue with adding in music files, now that is resolved. However the path to the music files is in a certain sequence. I tried to move that sequence by using remove and insert however that removes the path to the file so when I click on the file I want to play, it doesn't play. Below is the code I have just for up button. So How can I move an item in the 'path' list to move without removing it?

public partial class JukeBox : Form
    {
        private readonly List<string> paths = new List<string>();
        
        public JukeBox()
        {
            InitializeComponent();
        }

        private void btnFiles_Click(object sender, EventArgs e)
        {
            OpenFileDialog openFileDialog1 = new OpenFileDialog();
            openFileDialog1.Multiselect = true;

            if (openFileDialog1.ShowDialog() == System.Windows.Forms.DialogResult.OK)
            {
                paths.AddRange(openFileDialog1.FileNames);

                string[] files = openFileDialog1.SafeFileNames;
                for (int i = 0; i < files.Length; i++)
                {
                    listBox1.Items.Add(files[i]);
                }
            }
        }

        private void btnPlay_Click(object sender, EventArgs e)
        {
            axWindowsMediaPlayer1.URL = paths[listBox1.SelectedIndex];
        }

        private void btnUp_Click(object sender, EventArgs e)
        {
            if (listBox1.SelectedItems.Count > 0)
            {
                object selected = listBox1.SelectedItem;
                string lbName = listBox1.GetItemText(listBox1.SelectedItem);
                int lbIndex = listBox1.Items.IndexOf(selected);
                int lbTotal = listBox1.Items.Count;
                int pathIndex = paths.IndexOf(lbName);

                if (lbIndex == 0)
                {
                    paths.Remove(lbName);
                    paths.Insert(lbTotal - 1,lbName);
                    listBox1.Items.Remove(selected);
                    listBox1.Items.Insert(lbTotal - 1, selected);
                    listBox1.SetSelected(lbTotal - 1, true);
                }
                else
                {

                    paths.Remove(lbName);
                    paths.Insert(lbIndex - 1, lbName);
                    listBox1.Items.Remove(selected);
                    listBox1.Items.Insert(lbIndex - 1, selected);
                    listBox1.SetSelected(lbIndex - 1, true);
                }
            }
        }

Richard MacCutchan27-Oct-17 5:11

27-Oct-17 5:11

Why not use a different collection class, or a List of KeyValuePair(TKey, TValue) Structure (System.Collections.Generic)[^] items? That way you can keep your music title and file path together all the time.

Member 1348924427-Oct-17 5:18

27-Oct-17 5:18

Richard,
The reason for this layout, I've tried a lot of ways to add music files to a listbox than add some more files and they wouldn't play due to out of range error. With this layout it allows me to add music files to my list box and if I want to add some more I can.

Thank you

Richard MacCutchan27-Oct-17 5:51

27-Oct-17 5:51

Yes, except it still does not work. And if you get of range errors you need to diagnose the problem and fix your code rather than just ignoring it.

Member 1348924427-Oct-17 6:18

27-Oct-17 6:18

Richard,
Coming to this site doesn't mean that I was ignoring the problem, one cannot complete a task if they ignore the problems. Me coming to this site was me asking for help for an issue that I've been trying to fix for some time. I kindly ask, if you cannot help with the issue please don't reply again.

Thank you

Richard MacCutchan27-Oct-17 6:42

27-Oct-17 6:42

Well I did try to help, by suggesting a class that would make your application much easier to manage. But if you want to dismiss it out of hand that is fine with me.

Ralf Meier28-Oct-17 12:20

Ralf Meier

28-Oct-17 12:20

For your Info (if you don't know it) : with Richard you got one of the most famous members of this forum. I would suggest that you try to understand what he has suggested to you :
You can also create a Class which contains different information. This Class could be added as well to your ListBox and allows you to do what you are missing in the moment. Perhaps you re-think this ...

Richard MacCutchan28-Oct-17 22:08

28-Oct-17 22:08

jschell27-Oct-17 7:39

jschell

27-Oct-17 7:39

Member 13489244 wrote:
OpenFileDialog openFileDialog1

Perhaps there is an incorrect assumption here.

If you get a list of files from a file dialog you cannot "move" anything.
That list of files represent real resources on the OS. If you want to move a file (not an entry in the list) then you must move it. And the only way you can "move" it is by changing the directory.

If you want to change the order in a directory you must rename it.

And regardless of what you are doing if you modify the file name or location then you need to requery the OS for an updated list of files. You shouldn't attempt to modify the list yourself.

Alternatively perhaps you want to order the list based on criteria that the OS does not know about. That however is much more complicated and it REQUIRES that you store files and the additional data is some persistent data store (file, database, etc.) You would then load that, load the current file list from the OS, correlate the two and then with a brand new list that you created manage the files themselves and associated data for each file. On exit you would then update your persistent data store with changes.

c# Need to be able to play music files that were additional items to the list box

Gerry Schmitz28-Oct-17 3:31

Gerry Schmitz

28-Oct-17 3:31

Use an ObservableCollection as the data source for your listbox.

ObservableCollection has a "move" command:

.Move( oldIndex, newIndex )

"(I) am amazed to see myself here rather than there ... now rather than then".
― Blaise Pascal

Member 1348924427-Oct-17 3:52

Re: c# Need to be able to play music files that were additional items to the list box

27-Oct-17 3:52

Than you for taking the time to look over my problem.

I'm trying to make a playlist in c# that will allow me to play music. Below is the code that I have so far. I have the ability to add files from a fold and play they on the media player. However the issue is when I add additional music files is gives me an error message that reads IndexOutOfRange. So my question is: How can I add music files to a listbox than add some mote music files and be able to play them?

public MusicBox()
        {
            InitializeComponent();
        }

        private void btnFiles_Click(object sender, EventArgs e)
        {
            OpenFileDialog openFileDialog1 = new OpenFileDialog();
            openFileDialog1.Multiselect = true;

            if (openFileDialog1.ShowDialog() == System.Windows.Forms.DialogResult.OK)
            {
                files = openFileDialog1.SafeFileNames;
                paths = openFileDialog1.FileNames;

                for (int i = 0; i < files.Length; i++)
                {
                    listBox1.Items.Add(files[i]);
                }
            }
        }

        private void btnPlay_Click(object sender, EventArgs e)
        {
            axWindowsMediaPlayer1.URL = paths[listBox1.SelectedIndex];
        }

OriginalGriff27-Oct-17 3:57

OriginalGriff

27-Oct-17 3:57

Use the debugger: check the value of listBox1.SelectedIndex and the number of items in paths

Either listBox1.SelectedIndex will be too big, or it will be negative.

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...
AntiTwitter: @DalekDave is now a follower!

Re: c# Need to be able to play music files that were additional items to the list box

Richard Deeming27-Oct-17 4:04

Richard Deeming

27-Oct-17 4:04

You're appending the new files to the list, but replacing the paths variable with the new paths.

So, for example, if you've already selected files A, B and C:

List = { A, B, C }
Paths = { A, B, C }

and you then select D and E:

List = { A, B, C, D, E }
Paths = { D, E }

if you try to play A, you'll get D; if you try to play B, you'll get E; if you try to play anything else, you'll get an IndexOutOfRangeException.

If you want to replace the list of files, you'll need to call listBox1.Items.Clear() before adding the new files.

If you want to append the list of files, you'll need to append them to the paths list as well. The simplest option would probably be to change it to be a List<string> instead of an array:

private readonly List<string> paths = new List<string>();

private void btnFiles_Click(object sender, EventArgs e)
{
    OpenFileDialog openFileDialog1 = new OpenFileDialog();
    openFileDialog1.Multiselect = true;
    
    if (openFileDialog1.ShowDialog() == System.Windows.Forms.DialogResult.OK)
    {
        paths.AddRange(openFileDialog1.FileNames);
        
        string[] files = openFileDialog1.SafeFileNames;
        for (int i = 0; i < files.Length; i++)
        {
            listBox1.Items.Add(files[i]);
        }
    }
}

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

SOLVEDRe: c# Need to be able to play music files that were additional items to the list box

Member 1348924427-Oct-17 4:18