|
Tss.... They want to sell their product for automatically inspecting coding standards.
We use ReSharper, which can automatically apply the standards we defined.
But there are things it cannot do, that is conceptual errors. It cannot see that someone wrote to many if-else (or switch case) where base class plus some derived classes are the solution. It cannot see that some highly intelligent guy added an extra parameter to a method in order to make a class which caches some values not use the cache (instead of using the - long existing! - non-caching class. Or creates concrete dependencies instead of abstractions and dependency injection. And so on.
Still I doubt that code reviews / code inspection are really the solution. When people do not want to learn, that causes friction only. An open mindset is most important: then people will want to learn from each others' experiences.
Oh sanctissimi Wilhelmus, Theodorus, et Fredericus!
|
|
|
|
|
Bernhard Hiller wrote: Still I doubt that code reviews / code inspection are really the solution.
You are right. The solution is to learn properly or hire competent people (just see the QA section  )
M.D.V. 
If something has a solution... Why do we have to worry about?. If it has no solution... For what reason do we have to worry about?
Help me to understand what I'm saying, and I'll explain it better to you
Rating helpful answers is nice, but saying thanks can be even nicer.
|
|
|
|
|
Even that won't catch the fact that new hires are not familiar with the code base, and a code reviewer may recognise that there is a better way of doing something, based on their better knowledge of existing code.
"If you don't fail at least 90 percent of the time, you're not aiming high enough."
Alan Kay.
|
|
|
|
|
Bernhard Hiller wrote: It cannot see that someone wrote to many if-else (or switch case)
There's a plugin[^] for that. 
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
Hmm. The one code review we had at my employer ended with the developer in question threatening to quit if they ever did it again (I wasn't the developer, BTW).
Software Zen: delete this;
|
|
|
|
|
I would have fired him right then on the spot.
#SupportHeForShe
Government can give you nothing but what it takes from somebody else. A government big enough to give you everything you want is big enough to take everything you've got, including your freedom.-Ezra Taft Benson
You must accept 1 of 2 basic premises: Either we are alone in the universe or we are not alone. Either way, the implications are staggering!-Wernher von Braun
|
|
|
|
|
Ah, but context is everything.
The code review was poorly managed with no concrete goals and no definite process. The code that was reviewed was firmware for an embedded application. None of the reviewers (myself included) had familiarity with the target environment or the tool-chain. The end result was a mish-mash of stylistic nit-picking that served no useful purpose and pissed off a conscientious, hard-working engineer with a shitload of experience and irreplaceable expertise.
Software Zen: delete this;
|
|
|
|
|
Well, then he was justified in his declaration. Sounds like a stupid manager in that case.
#SupportHeForShe
Government can give you nothing but what it takes from somebody else. A government big enough to give you everything you want is big enough to take everything you've got, including your freedom.-Ezra Taft Benson
You must accept 1 of 2 basic premises: Either we are alone in the universe or we are not alone. Either way, the implications are staggering!-Wernher von Braun
|
|
|
|
|
What's really bad is having non-programmers do code-reviews. This has actually happened to me. I quit the next day.
".45 ACP - because shooting twice is just silly" - JSOP, 2010
-----
You can never have too much ammo - unless you're swimming, or on fire. - JSOP, 2010
-----
When you pry the gun from my cold dead hands, be careful - the barrel will be very hot. - JSOP, 2013
|
|
|
|
|
John Simmons / outlaw programmer wrote: having non-programmers do code-reviews
Wow  . And I thought our one code review was ineptly handled (see thread above).
Software Zen: delete this;
|
|
|
|
|
In the beginning of 2018 we surveyed 6,000 developers to identify the State of Developer Ecosystem. Predator devs consume the herbivore devs, that consume the plant devs?
|
|
|
|
|
The preferred music genre is "Electronic"; that puts the sanity of their user base in serious doubt.
|
|
|
|
|
Many organizations don’t realize how powerful documentation can be as a marketing tool. Just don't bother, people will figure it out?
|
|
|
|
|
If I ask for documentation, the last thing I want is marketing-drivel.
Bastard Programmer from Hell 
If you can't read my code, try converting it here[^]
"If you just follow the bacon Eddy, wherever it leads you, then you won't have to think about politics." -- Some Bell.
|
|
|
|
|
I've been writing end-user documentation since I started programming. In the early 90's, the user manuals for the apps I wrote won awards in the industry for which the associated software was developed. That's back when I was a programmer, documentation writer, tester, and tech support. When you work tech support on your applications, you learn a valuable lessons with regards to quality of code and quality of documentation.
The REAL problem is that developers aren't held to as high a standard as they used to be, and they're not exposed to the other aspects of software development. Granted, end users are generally f*ckin idiots, but that's when you learn that your UI and docs have to be tailored for those users.
Lastly, end-user documentation is NOT a marketing tool.
".45 ACP - because shooting twice is just silly" - JSOP, 2010
-----
You can never have too much ammo - unless you're swimming, or on fire. - JSOP, 2010
-----
When you pry the gun from my cold dead hands, be careful - the barrel will be very hot. - JSOP, 2013
|
|
|
|
|
John Simmons / outlaw programmer wrote: developers aren't held to as high a standard as they used to be, and they're not exposed to the other aspects of software development
True. I worked as a grunt contract programmer while I was in college [some time during the early Cretaceous]. One of the most useful jobs I had was in a technical writer slot. I learned how to write, which most engineers do poorly if at all. As a tech writer you (hopefully) learn how to put yourself in your audience's position. Ultimately this makes you a better programmer, especially if you do UI.
Software Zen: delete this;
|
|
|
|
|
John Simmons / outlaw programmer wrote: When you work tech support on your applications, you learn a valuable lessons with regards to quality of code and quality of documentation.
As the kids say, "this". 
TTFN - Kent
|
|
|
|
|
A new file type format added in Windows 10 can be abused for running malicious code on users' computers, according to Matt Nelson, a security researcher for SpecterOps. Because it was so hard to find those settings before (hidden in Control Panel!)
An XML file with a link to an executable?! No one thought this might be a problem?
|
|
|
|
|
Quote: Nelson contacted Microsoft, but the OS maker did not consider this a vulnerability in the OS.
I guess we'll have to wait for a few thousand PCs to get compromised / infected via this route before they deign to fix it.
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
I was going to call you cynic, but then I remembered we are speaking about the current Mocosoft  
M.D.V.
If something has a solution... Why do we have to worry about?. If it has no solution... For what reason do we have to worry about?
Help me to understand what I'm saying, and I'll explain it better to you
Rating helpful answers is nice, but saying thanks can be even nicer.
|
|
|
|
|
The browser maker is now serving replacement ads to as many as 1,000 volunteers who agreed to help test out the company's plans. Not ad block, but ad replace?
|
|
|
|
|
Easy answer: $$$$$
M.D.V.
If something has a solution... Why do we have to worry about?. If it has no solution... For what reason do we have to worry about?
Help me to understand what I'm saying, and I'll explain it better to you
Rating helpful answers is nice, but saying thanks can be even nicer.
|
|
|
|
|
A new attack prompted OpenBSD's developers to disable hyperthreading by default. When you've lost OpenBSD, you know you're doomed
|
|
|
|
|
I read up on this earlier. It sounds like yet another exploit that can be reproduced in an artificial setup, but it really hard to make practical in the real world.
|
|
|
|
|
Former Microsoft CEO Steve Ballmer has been rather candid since his departure from the worlds leading software providing company. Kick more chairs?
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
