Click here to Skip to main content
14,328,905 members
   

C#

 
GeneralRe: Iterating in a list of data and search that data in another datatable for update first list Pin
Mou_kol11-Apr-19 8:58
memberMou_kol11-Apr-19 8:58 
GeneralRe: Iterating in a list of data and search that data in another datatable for update first list Pin
Luc Pattyn11-Apr-19 9:17
professionalLuc Pattyn11-Apr-19 9:17 
QuestionHow to do three join between three list Pin
Mou_kol7-Apr-19 8:12
memberMou_kol7-Apr-19 8:12 
AnswerRe: How to do three join between three list Pin
Vinod Jangle9-Apr-19 3:22
memberVinod Jangle9-Apr-19 3:22 
QuestionRepeated join causing poor performance in for loop Pin
Mou_kol7-Apr-19 8:10
memberMou_kol7-Apr-19 8:10 
AnswerRe: Repeated join causing poor performance in for loop Pin
jschell7-Apr-19 8:57
memberjschell7-Apr-19 8:57 
GeneralRe: Repeated join causing poor performance in for loop Pin
Mou_kol8-Apr-19 9:07
memberMou_kol8-Apr-19 9:07 
AnswerRe: Repeated join causing poor performance in for loop Pin
Luc Pattyn7-Apr-19 15:44
professionalLuc Pattyn7-Apr-19 15:44 
Hi,

First of all, I agree with jschell.

Then, I haven't read all that, however I did notice you are wasting cycles by performing complex operations twice.

Instead of

string brokerBogeypath = File.Exists(@Path.Combine(ConfigurationManager.AppSettings["DBPath"].ToString(), cmbTicker.Text, "###~$$$~Bogey.xml".Replace("###", cmbTicker.Text).Trim().Replace("$$$", objbrokerBrogeyData.Broker).Trim())) ?
        @Path.Combine(ConfigurationManager.AppSettings["DBPath"].ToString(), cmbTicker.Text, "###~$$$~Bogey.xml".Replace("###", cmbTicker.Text).Trim().Replace("$$$", objbrokerBrogeyData.Broker).Trim()) : ""; ;

which is hard to read and understand, you'd better do
string brokerBogeypath = Path.Combine(ConfigurationManager.AppSettings["DBPath"].ToString(), cmbTicker.Text, "###~$$$~Bogey.xml".Replace("###", cmbTicker.Text).Trim().Replace("$$$", objbrokerBrogeyData.Broker).Trim());
if (!File.Exists(brokerBogeypath)) brokerBogeypath="";

which is both more readable and faster.

Next, you have a lot of calls to ToUpper(), Trim(), and Replace(...); each of them will cost a fwe microseconds, which accumulates when executed a lot of times. You probably could reorganise them so they are each required only once, maybe at the expense of some extra storage.

Same for ConfigurationManager.AppSettings["DBPath"].ToString()

Finally, I would suggest shortening some of the identifiers in order to improve readability; this won't change execution speed however it may make it easier for you (or others) to see what is really going on...

Smile | :)
Luc Pattyn [My Articles] Nil Volentibus Arduum

GeneralRe: Repeated join causing poor performance in for loop Pin
Mou_kol8-Apr-19 9:13
memberMou_kol8-Apr-19 9:13 
GeneralRe: Repeated join causing poor performance in for loop Pin
Luc Pattyn8-Apr-19 9:14
professionalLuc Pattyn8-Apr-19 9:14 
QuestionC# List: How to do 3 joins for better performance Pin
Mou_kol7-Apr-19 2:44
memberMou_kol7-Apr-19 2:44 
AnswerRe: C# List: How to do 3 joins for better performance Pin
Gerry Schmitz7-Apr-19 6:17
mveGerry Schmitz7-Apr-19 6:17 
GeneralRe: C# List: How to do 3 joins for better performance Pin
Mou_kol7-Apr-19 8:06
memberMou_kol7-Apr-19 8:06 
AnswerRe: C# List: How to do 3 joins for better performance Pin
Dave Kreskowiak7-Apr-19 6:39
mveDave Kreskowiak7-Apr-19 6:39 
GeneralRe: C# List: How to do 3 joins for better performance Pin
Mou_kol7-Apr-19 8:05
memberMou_kol7-Apr-19 8:05 
GeneralRe: C# List: How to do 3 joins for better performance Pin
Dave Kreskowiak7-Apr-19 8:29
mveDave Kreskowiak7-Apr-19 8:29 
GeneralRe: C# List: How to do 3 joins for better performance Pin
Mou_kol8-Apr-19 9:06
memberMou_kol8-Apr-19 9:06 
GeneralRe: C# List: How to do 3 joins for better performance Pin
Dave Kreskowiak8-Apr-19 9:24
mveDave Kreskowiak8-Apr-19 9:24 
AnswerRe: C# List: How to do 3 joins for better performance Pin
Mycroft Holmes7-Apr-19 12:17
memberMycroft Holmes7-Apr-19 12:17 
GeneralRe: C# List: How to do 3 joins for better performance Pin
Mou_kol8-Apr-19 9:09
memberMou_kol8-Apr-19 9:09 
QuestionHow to make code run differently depending on the platform it is running on? Pin
Xarzu5-Apr-19 6:44
memberXarzu5-Apr-19 6:44 
AnswerRe: How to make code run differently depending on the platform it is running on? Pin
Richard Deeming5-Apr-19 7:15
mveRichard Deeming5-Apr-19 7:15 
AnswerRe: How to make code run differently depending on the platform it is running on? Pin
Gerry Schmitz5-Apr-19 9:54
mveGerry Schmitz5-Apr-19 9:54 
AnswerRe: How to make code run differently depending on the platform it is running on? Pin
jschell7-Apr-19 9:00
memberjschell7-Apr-19 9:00 
Questionc# Pin
Member 142150015-Apr-19 4:29
memberMember 142150015-Apr-19 4:29 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.