Visual Basic

Member Alienoiz10-Jun-23 6:59

10-Jun-23 6:59

this is the full code im using for this...

<pre>  Dim items = ListBox1.SelectedItem()
                For Each items In ListBox1.SelectedItems()

                    If CheckBox1.Checked = True Then
                        myMp3.ID3v2Tag.Title = TextBox1.Text
                        myMp3.Write()
                    End If


                    If CheckBox2.Checked = True Then
                        myMp3.ID3v2Tag.Artist = TextBox2.Text
                        myMp3.Write()
                    End If


                    If CheckBox3.Checked = True Then
                        myMp3.ID3v2Tag.Album = TextBox3.Text
                        myMp3.Write()
                    End If


                    If CheckBox4.Checked = True And TextBox4.Text <> "" Then
                        On Error Resume Next
                        myMp3.ID3v2Tag.Year = Short.Parse(TextBox4.Text)
                        myMp3.Write()
                        On Error Resume Next
                    End If


                    If CheckBox5.Checked = True And TextBox5.Text <> "" Then
                        myMp3.ID3v2Tag.TrackNum = Short.Parse(TextBox5.Text)
                        myMp3.Write()
                        On Error Resume Next
                    End If


                    If CheckBox6.Checked = True Then
                        myMp3.ID3v2Tag.Comments = TextBox6.Text
                        myMp3.Write()
                    End If

                    If CheckBox7.Checked = True Then
                        If ComboBox1.Text = "01 - User" Then
                            myMp3.ID3v2Tag.Genre = TextBox7.Text
                            myMp3.Write()
                        Else
                            myMp3.ID3v2Tag.Genre = ComboBox1.Text
                            myMp3.Write()
                        End If

                    End If

                Next

Dave Kreskowiak10-Jun-23 19:21

10-Jun-23 19:21

If the ListBox contains your MP3 filepaths, you have to loop through the selected items in the ListBox.

VB.NET

' You don't need the "Dim items" line...
For Each item in ListBox1.SelectedItems
    ' Create your MP3 object for the selected file here...

    ' Then go though your CheckBoxes and makes each selected change to the MP3 object
    ' You probably do NOT have to call .Write on every change. You can wait until the
    ' end of the changes and then call .Write once to write the changes back to the MP3.
Next

Asking questions is a skill
CodeProject Forum Guidelines
Google: C# How to debug code
Seriously, go read these articles.

Dave Kreskowiak

Member Alienoiz10-Jun-23 23:05

10-Jun-23 23:05

what do you mean by :

Create your MP3 object for the selected file here...

Sorry..im dumb..i might quit this project Frown | :(

Richard MacCutchan11-Jun-23 1:31

11-Jun-23 1:31

Member Alienoiz wrote:
i might quit this project

I suggest you do. There are far too many gaps in your understanding of the basics to make this a viable and successful project. What I would suggest is that you get yourself some good training materials on Visual Basic and the .NET framework; and I mean books or written tutorials, not Youtube videos.

Member Alienoiz11-Jun-23 1:49

11-Jun-23 1:49

Yes im going to quit just because i cannot make mass edit on my listbox and because you do not want to provide a code snippet to help me...lol...sure

Richard MacCutchan11-Jun-23 1:58

11-Jun-23 1:58

We have all tried to help you. But the main problem is that you do not even understand the code you have, so whatever we have suggested you are still lost. That is why I gave you the suggestion in my previous message. If you do not understand the basics of any programming language, then posting questions here will largely be a waste of your time.

Member Alienoiz11-Jun-23 2:45

11-Jun-23 2:45

Hey..i know im lame..but i have (and sorry for the exctensive code) written all this just using internet snippets and my own knowledge without asking for help to anyone...but...yes...i cannot solve the listbox mass edit..
anyway..thanks for replying...

VB.NET

<pre>Imports System.IO
Imports System.Net.Security
Imports System.Net.WebRequestMethods
Imports System.Runtime
Imports System.Security.Cryptography
Imports System.Windows.Forms.VisualStyles.VisualStyleElement
Imports HundredMilesSoftware.UltraID3Lib

Public Class Form1

    Dim myMp3 As New UltraID3()

    Private Sub Button1_Click(sender As Object, e As EventArgs) Handles Button1.Click
        If FolderBrowserDialog1.ShowDialog() = DialogResult.OK Then

            ListBox1.Items.Clear()
            Dim fileNames = My.Computer.FileSystem.GetFiles(FolderBrowserDialog1.SelectedPath, FileIO.SearchOption.SearchTopLevelOnly, "*.mp3")

            For Each fileName As String In fileNames
                Dim result As String = Path.GetFileName(fileName)
                ListBox1.Items.Add(result)
            Next


        End If
        Label1.Text = "Title :"
        Label2.Text = "Artist :"
        Label3.Text = "Album :"
        Label4.Text = "Year :"
        Label5.Text = "Track :"
        Label6.Text = "Comment :"
        Label7.Text = "Genre : "

    End Sub



    Private Sub Button2_Click(sender As Object, e As EventArgs) Handles Button2.Click
        ListBox1.Items.Clear()
        If FolderBrowserDialog1.SelectedPath = "" Then
            Dim r8 As DialogResult = MessageBox.Show(Me, "You need to load a folder.",
                                   "Load Files", MessageBoxButtons.OK)
        Else
            Dim fileNames = My.Computer.FileSystem.GetFiles(FolderBrowserDialog1.SelectedPath, FileIO.SearchOption.SearchTopLevelOnly, "*.mp3")

            For Each fileName As String In fileNames
                Dim result As String = Path.GetFileName(fileName)
                ListBox1.Items.Add(result)
            Next

        End If


        Label1.Text = "Title :"
        Label2.Text = "Artist :"
        Label3.Text = "Album :"
        Label4.Text = "Year :"
        Label5.Text = "Track :"
        Label6.Text = "Comment :"
        Label7.Text = "Genre : "
    End Sub



    Private Sub ListBox1_SelectedIndexChanged(sender As Object, e As EventArgs) Handles ListBox1.SelectedIndexChanged

        If ListBox1.SelectedItem = "" Then
            On Error Resume Next
        Else

            myMp3.Read(FolderBrowserDialog1.SelectedPath & "\" & ListBox1.SelectedItem)

            Label1.Text = "Title : " & myMp3.ID3v2Tag.Title
            Label2.Text = "Artist : " & myMp3.ID3v2Tag.Artist
            Label3.Text = "Album : " & myMp3.ID3v2Tag.Album
            Label4.Text = "Year : " & myMp3.ID3v2Tag.Year.ToString
            Label5.Text = "Track : " & myMp3.ID3v2Tag.TrackNum.ToString
            Label6.Text = "Comment : " & myMp3.ID3v2Tag.Comments
            Label7.Text = "Genre : " & myMp3.ID3v2Tag.Genre
            On Error Resume Next
            Dim pics = myMp3.ID3v2Tag.Frames.GetFrames(CommonMultipleInstanceID3v2FrameTypes.Picture)
            PictureBox1.Image = CType(pics(0), ID3v2PictureFrame).Picture

        End If

    End Sub

    Private Sub Button3_Click(sender As Object, e As EventArgs) Handles Button3.Click


        If ListBox1.SelectedItem = "" Then
            Dim r8 As DialogResult = MessageBox.Show(Me, "No File Selected!",
                                   "Select Files", MessageBoxButtons.OK)


        Else
            If CheckBox1.Checked = False And CheckBox2.Checked = False And CheckBox3.Checked = False And CheckBox4.Checked = False And CheckBox5.Checked = False And CheckBox6.Checked = False And CheckBox7.Checked = False And CheckBox8.Checked = False Then
                Dim r8 As DialogResult = MessageBox.Show(Me, "Select a tag to enter!",
                                  "Select Tags", MessageBoxButtons.OK)
            Else
                If CheckBox1.Checked = True Then
                    myMp3.ID3v2Tag.Title = TextBox1.Text
                    myMp3.Write()
                End If

                If CheckBox2.Checked = True Then
                    myMp3.ID3v2Tag.Artist = TextBox2.Text
                    myMp3.Write()
                End If


                If CheckBox3.Checked = True Then
                    myMp3.ID3v2Tag.Album = TextBox3.Text
                    myMp3.Write()
                End If


                If CheckBox4.Checked = True And TextBox4.Text <> "" Then
                    On Error Resume Next
                    myMp3.ID3v2Tag.Year = Short.Parse(TextBox4.Text)
                    myMp3.Write()

                End If
                If CheckBox5.Checked = True And TextBox5.Text <> "" Then
                    On Error Resume Next
                    myMp3.ID3v2Tag.TrackNum = Short.Parse(TextBox5.Text)
                    myMp3.Write()

                End If
                If CheckBox6.Checked = True Then
                    myMp3.ID3v2Tag.Comments = TextBox6.Text
                    myMp3.Write()
                End If

                If CheckBox7.Checked = True Then
                    If ComboBox1.Text = "01 - User" Then
                        myMp3.ID3v2Tag.Genre = TextBox7.Text
                        myMp3.Write()
                    Else
                        myMp3.ID3v2Tag.Genre = ComboBox1.Text
                        myMp3.Write()
                    End If

                    If CheckBox8.Checked = True Then
                        Dim AlbumArt As ID3v2PictureFrame = New ID3v23PictureFrame(System.Drawing.Bitmap.FromFile("E:\teste\img.jpg"), PictureTypes.CoverFront, "Attached picture", TextEncodingTypes.ISO88591)
                        AlbumArt.Picture = PictureBox1.Image
                        myMp3.ID3v2Tag.Frames.Add(AlbumArt)
                        myMp3.Write()
                    End If

                End If
            End If
            Dim r9 As DialogResult = MessageBox.Show(Me, "Operation Complete!",
                          "Tagged Files!", MessageBoxButtons.OK)
        End If
    End Sub

    Private Sub Button4_Click(sender As Object, e As EventArgs) Handles Button4.Click
        ListBox1.Items.Clear()
    End Sub

    Private Sub TextBox5_KeyPress(sender As Object, e As KeyPressEventArgs) Handles TextBox5.KeyPress
        Dim ch As Char = e.KeyChar
        If Not Char.IsDigit(ch) AndAlso Asc(ch) <> 8 Then
            e.Handled = True
        End If
    End Sub

    Private Sub TextBox4_KeyPress(sender As Object, e As KeyPressEventArgs) Handles TextBox4.KeyPress
        Dim ch As Char = e.KeyChar
        If Not Char.IsDigit(ch) AndAlso Asc(ch) <> 8 Then
            e.Handled = True
        End If
    End Sub

    Private Sub Button5_Click(sender As Object, e As EventArgs) Handles Button5.Click
        On Error Resume Next
        My.Computer.FileSystem.RenameFile(FolderBrowserDialog1.SelectedPath & "\" & ListBox1.SelectedItem, TextBox8.Text & ".mp3")

        ListBox1.Items.Clear()

        Dim Fils = My.Computer.FileSystem.GetFiles(FolderBrowserDialog1.SelectedPath, FileIO.SearchOption.SearchTopLevelOnly, "*.mp3")

        For Each fil As String In Fils
            Dim result As String = Path.GetFileName(fil)
            ListBox1.Items.Add(result)
        Next
    End Sub

    Private Sub Button7_Click(sender As Object, e As EventArgs) Handles Button7.Click
        On Error Resume Next
        Dim FileName = ListBox1.SelectedItem

        Dim FilePath = TextBox9.Text & "\" & FileName  'First Name of Directory and Then Name of Folder if it exists and then attach the name of file you want to search.

        If System.IO.File.Exists(FilePath) Then
            Dim r9 As DialogResult = MessageBox.Show(Me, "File Exists!",
                           "Duplicated Files!", MessageBoxButtons.OK)
        Else
            My.Computer.FileSystem.MoveFile(FolderBrowserDialog1.SelectedPath & "\" & ListBox1.SelectedItem, TextBox9.Text & "\" & ListBox1.SelectedItem)
            ListBox1.Items.Clear()
            Dim fils2 = My.Computer.FileSystem.GetFiles(FolderBrowserDialog1.SelectedPath, FileIO.SearchOption.SearchTopLevelOnly, "*.mp3")

            For Each fil3 As String In fils2
                Dim result As String = Path.GetFileName(fil3)
                ListBox1.Items.Add(result)
            Next

        End If

    End Sub

    Private Sub Button9_Click(sender As Object, e As EventArgs) Handles Button9.Click
        If FolderBrowserDialog2.ShowDialog() = DialogResult.OK Then
            TextBox9.Text = FolderBrowserDialog2.SelectedPath
        End If
    End Sub

    Private Sub Button6_Click(sender As Object, e As EventArgs) Handles Button6.Click
        On Error Resume Next

        Dim FileName = ListBox1.SelectedItem

        Dim FilePath = TextBox10.Text & "\" & FileName  'First Name of Directory and Then Name of Folder if it exists and then attach the name of file you want to search.

        If System.IO.File.Exists(FilePath) Then
            Dim r9 As DialogResult = MessageBox.Show(Me, "File Exists!",
                           "Duplicated Files!", MessageBoxButtons.OK)
        Else
            My.Computer.FileSystem.CopyFile(FolderBrowserDialog1.SelectedPath & "\" & ListBox1.SelectedItem, TextBox10.Text & "\" & ListBox1.SelectedItem, overwrite:=False)

            ListBox1.Items.Clear()
            Dim fils4 = My.Computer.FileSystem.GetFiles(FolderBrowserDialog1.SelectedPath, FileIO.SearchOption.SearchTopLevelOnly, "*.mp3")

            For Each fil4 As String In fils4
                Dim result As String = Path.GetFileName(fil4)
                ListBox1.Items.Add(result)
            Next
        End If
    End Sub

    Private Sub Button10_Click(sender As Object, e As EventArgs) Handles Button10.Click
        If FolderBrowserDialog3.ShowDialog() = DialogResult.OK Then
            TextBox10.Text = FolderBrowserDialog3.SelectedPath
        End If
    End Sub

    Private Sub Button8_Click(sender As Object, e As EventArgs) Handles Button8.Click
        On Error Resume Next
        My.Computer.FileSystem.DeleteFile(FolderBrowserDialog1.SelectedPath & "\" & ListBox1.SelectedItem)
        ListBox1.Items.Clear()
        Dim fils5 = My.Computer.FileSystem.GetFiles(FolderBrowserDialog1.SelectedPath, FileIO.SearchOption.SearchTopLevelOnly, "*.mp3")

        For Each fil5 As String In fils5
            Dim result As String = Path.GetFileName(fil5)
            ListBox1.Items.Add(result)
        Next

    End Sub

    Private Sub Button11_Click(sender As Object, e As EventArgs) Handles Button11.Click
        Dim ofd As New OpenFileDialog
        If ofd.ShowDialog = DialogResult.OK Then
            If ofd.FileName <> String.Empty Then
                Me.PictureBox1.Image = Bitmap.FromFile(ofd.FileName)
            End If
        End If
    End Sub

    Private Sub Button12_Click(sender As Object, e As EventArgs) Handles Button12.Click
        For i As Integer = 0 To ListBox1.SelectedIndices.Count - 1
            ListBox1.Items.RemoveAt(ListBox1.SelectedIndex)
        Next

    End Sub

    Private Sub TextBox11_TextChanged(sender As Object, e As EventArgs) Handles TextBox11.TextChanged
        If TextBox11.Text = "" Then
            ListBox1.Items.Clear()
            Dim fileNames = My.Computer.FileSystem.GetFiles(FolderBrowserDialog1.SelectedPath, FileIO.SearchOption.SearchTopLevelOnly, "*.mp3")

            For Each fileName As String In fileNames
                Dim result As String = Path.GetFileName(fileName)
                ListBox1.Items.Add(result)
            Next
        Else

            Dim items = From it In ListBox1.Items.Cast(Of Object)()
                        Where it.ToString().IndexOf(TextBox11.Text, StringComparison.CurrentCultureIgnoreCase) >= 0
            Dim matchingItemList As List(Of Object) = items.ToList()
            ListBox1.BeginUpdate()
            ListBox1.Items.Clear()
            For Each item In matchingItemList
                ListBox1.Items.Add(item)
            Next
            ListBox1.EndUpdate()
        End If
    End Sub

    Private Sub Button13_Click(sender As Object, e As EventArgs) Handles Button13.Click
        If Button13.Text = "Mass Edit" Then
            Button13.Text = "Single Edit"
        Else
            Button13.Text = "Mass Edit"
        End If

        If Button5.Enabled = True Then
            Button5.Enabled = False
        Else
            Button5.Enabled = True
        End If
        If Button6.Enabled = True Then
            Button6.Enabled = False
        Else
            Button6.Enabled = True
        End If
        If Button7.Enabled = True Then
            Button7.Enabled = False
        Else
            Button7.Enabled = True
        End If
        If Button8.Enabled = True Then
            Button8.Enabled = False
        Else
            Button8.Enabled = True
        End If
        If ListBox1.SelectionMode = SelectionMode.One Then
            ListBox1.SelectionMode = SelectionMode.MultiExtended
        Else
            ListBox1.SelectionMode = SelectionMode.One
        End If


    End Sub
End Class

Dave Kreskowiak11-Jun-23 4:38

11-Jun-23 4:38

Quote:
i have ... written all this just using internet snippets

And there's the problem. You haven't written anything. You've copied and pasted code snippets and hoping it all works together. You don't really understand much of anything.

How do I know this? You just asked me how you create an object! That's something you do ALL THE TIME in writing code, and you don't have a clue what that means, even though you already did it in your own code.

VB.NET

Dim myMp3 As New UltraID3()

The problem with that statement though, is you don't have a clue what it means, nor what's wrong with it. You created a UltraID3 object, but you don't know how to use it or even tell it which file you're trying to work with. You made a bunch of changes to it in your code, but you're not actually changing anything when you call .Write on it! Write to what!?!?

Asking questions is a skill
CodeProject Forum Guidelines
Google: C# How to debug code
Seriously, go read these articles.

Dave Kreskowiak

Member Alienoiz11-Jun-23 5:01

11-Jun-23 5:01

No no...the code is working good...i can do all i want to do...i just cannot make mass edit with my listbox...all rest is working like a charm and almost no bugs....
Yes...im lame..but i understand what im doing...i just cannot generate all code...admit it..even you use the "Bible" sometimes...lol

Dave Kreskowiak11-Jun-23 5:10

11-Jun-23 5:10

The code is giving you the ILLUSION it's "working good". It's not. Not even close.

The reason it's not writing anything to the MP3 files is because you never told your UltraID3 object instance, what you're calling "myMp3", which file you're trying to modify.

Asking questions is a skill
CodeProject Forum Guidelines
Google: C# How to debug code
Seriously, go read these articles.

Dave Kreskowiak

Member Alienoiz11-Jun-23 5:13

11-Jun-23 5:13

The code is writting all tags in the mp3s...just not in mass selection...i can edit one by one in the listbox

Dave Kreskowiak11-Jun-23 5:23

11-Jun-23 5:23

The code you posted isn't writing a damn thing to the MP3's.

Asking questions is a skill
CodeProject Forum Guidelines
Google: C# How to debug code
Seriously, go read these articles.

Dave Kreskowiak

Member Alienoiz11-Jun-23 5:29

11-Jun-23 5:29

Yes it is ...i might make a video later when im home

Dave Kreskowiak12-Jun-23 2:20

12-Jun-23 2:20

I don't f'ing care.

Asking questions is a skill
CodeProject Forum Guidelines
Google: C# How to debug code
Seriously, go read these articles.

Dave Kreskowiak

Member Alienoiz11-Jun-23 23:37

11-Jun-23 23:37

@moderators please let me post this video...i need to prove the code is working..Thanks

@Dave Kreskowiak the code is working with almost no bugs Smile | :)

im just having problems with the image (i can read but i cannot write it) and i wish mass edit in my listbox...then i just need to make the graphics Smile | :)

Video: Untitled.mp4 - Google Drive[^]

Richard MacCutchan12-Jun-23 2:05

12-Jun-23 2:05

You are not allowed to post videos in the forums. It would just let spammers to post inappropriate material.

Dave Kreskowiak11-Jun-23 4:52

11-Jun-23 4:52

Quote:
because you do not want to provide a code snippet to help me...lol...sure

After looking at the post where you showed all the code, there isn't a single code snippet that's going to help you fix that code. IT HAS TO BE SCRAPED AND COMPLETELY REWRITTEN from scratch to get it to work properly. Yes! It's that far gone.

Asking questions is a skill
CodeProject Forum Guidelines
Google: C# How to debug code
Seriously, go read these articles.

Dave Kreskowiak

Member Alienoiz11-Jun-23 5:02

11-Jun-23 5:02

I do not believe in that...the code is working good for all i want...just the listbox mass edit is not working..

Member Alienoiz10-Jun-23 9:53

10-Jun-23 9:53

ok...so i have the items and i need to open each one individualy and apply the modifications to each one individualy...while loop through the listbox...i would like to know how can i do that?? Thank You!

Ralf Meier10-Jun-23 10:52

Ralf Meier

10-Jun-23 10:52

show the code of myMP3.write ...
My GlassOrb supposes that there is the fault ...

Richard MacCutchan10-Jun-23 21:23

10-Jun-23 21:23

I spent far too much time telling him that, and other things, yesterday at Crash on converting string to byte - Visual Basic Discussion Boards[^]. He is not a great one for taking advice.

Richard MacCutchan10-Jun-23 21:11

10-Jun-23 21:11

I explained yesterday why that code was wrong, and how it should be changed. It seems you have no interest in actually trying to write the correct code.

Andre Oosthuizen12-Jun-23 23:59

Andre Oosthuizen

12-Jun-23 23:59

I am probably jumping into a rabbit hole here...
@Member Alienoiz, as per most posters above, you need to understand the code and it's operations that you got from another source. I agree that you do not have to re-invent the wheel but you need to understand why the wheel were invented and why/what it's function is before you can implement it into a real world scenario - you will not attach a wheel to a kettle but you might attach it to a car.

That being said, the following is some good practices to follow, which you probably would have done if you understood the code completely. I have used your class post from above, an answer to your 'listbox only updating item 1' will follow after -

Here are a few few suggestions for improving your code's efficiency and readability so anybody can understand it.
1. Make use of conventional naming practice's i.e 'Button1' can be named 'btn_Load_folder' which will point anyone else reading your code to your LoadFolder function. No-one will know what Button1, Label7, Text9 etc. do without going to the actual control to try and figure out what it's function is.
2. Remove unused imports such as System.Net.Security, System.Net.WebRequestMethods, System.Runtime, and System.Security.Cryptography. Including these unnecessary imports can clutter the code and affect your app's performance.
3. It's good practice to use explicit access modifiers i.e, Private, Public for your methods and variables. Not using an access modifier will always default to Private, it is however better to be explicit to improve your code readability.
4. You are repeating certain code over and over. In your Button1_Click and Button2_Click event handlers, you have duplicate code for retrieving the file names and populating the ListBox1 control. You should consider extracting this code into a separate method and calling it from both event handlers to avoid redundancy.
5. Combine event handlers into one event. Your event handlers for Button4_Click, Button6_Click, Button8_Click, and Button12_Click have similar code. You can combine them into a single event handler and determine the action or the expected behavior's based on the sender's ID etc.
6. Use 'Try...Catch' blocks instead of 'On Error Resume Next' to handle exceptions. By resuming next you just ignore the error and hope for the best, which is probably why you kept on stating that your code "works fine" whil;st it actually does not, you just skipped the errors. Using the 'Try...Catch' blocks allows you to handle specific exceptions and provide appropriate error messages or take necessary actions so your app does not crash somewhere along the line.
7. In some places, you read, write, move, or delete files within a loop or repeatedly. Consider combining these operations by making less calls to file system operations or you can use bulk operations where possible.
8. You have multiple places where you update the labels' text in your code. Rather combine this functionality into a separate method to avoid code duplication and improve maintainability with less stress on your app.

Below is the code for your class and it's methods. I suggest that you work through each line, let Google be your friend here and research each item that you do not understand. I do not claim this to be the best code, there might be better practice's but I am confident this will point you in the right direction to start learning why a wheel goes on a car and not a kettle -

Imports System.IO
Imports HundredMilesSoftware.UltraID3Lib

Public Class Form1
    Dim myMp3 As New UltraID3()

    ' Event handler for loading files from a folder
    Private Sub Button1_Click(sender As Object, e As EventArgs) Handles Button1.Click, Button2.Click
        Dim isLoadFolder As Boolean = (sender Is Button1)
        Dim selectedPath As String = FolderBrowserDialog1.SelectedPath

        If isLoadFolder Then
            ' Show the folder browser dialog to select a folder
            If FolderBrowserDialog1.ShowDialog() = DialogResult.OK Then
                selectedPath = FolderBrowserDialog1.SelectedPath
            Else
                Return
            End If
        End If

        ListBox1.Items.Clear()
        ' Get all the .mp3 files in the selected folder
        Dim fileNames = Directory.GetFiles(selectedPath, "*.mp3", SearchOption.TopDirectoryOnly)

        ' Add the file names to the list box
        For Each fileName As String In fileNames
            Dim result As String = Path.GetFileName(fileName)
            ListBox1.Items.Add(result)
        Next

        ' Reset the label values
        ResetLabelValues()
    End Sub

    ' Event handler for selecting a file in the list box
    Private Sub ListBox1_SelectedIndexChanged(sender As Object, e As EventArgs) Handles ListBox1.SelectedIndexChanged
        If ListBox1.SelectedItem Is Nothing Then Return

        ' Read the selected MP3 file using UltraID3
        myMp3.Read(Path.Combine(FolderBrowserDialog1.SelectedPath, ListBox1.SelectedItem.ToString()))

        ' Update the labels with the ID3 tag information
        Label1.Text = "Title: " & myMp3.ID3v2Tag.Title
        Label2.Text = "Artist: " & myMp3.ID3v2Tag.Artist
        Label3.Text = "Album: " & myMp3.ID3v2Tag.Album
        Label4.Text = "Year: " & myMp3.ID3v2Tag.Year.ToString()
        Label5.Text = "Track: " & myMp3.ID3v2Tag.TrackNum.ToString()
        Label6.Text = "Comment: " & myMp3.ID3v2Tag.Comments
        Label7.Text = "Genre: " & myMp3.ID3v2Tag.Genre

        ' Update the picture box with the album art if available
        Dim pics = myMp3.ID3v2Tag.Frames.GetFrames(CommonMultipleInstanceID3v2FrameTypes.Picture)
        If pics.Length > 0 Then
            PictureBox1.Image = CType(pics(0), ID3v2PictureFrame).Picture
        End If
    End Sub

    ' Event handler for saving the edited tags to the MP3 file
    Private Sub Button3_Click(sender As Object, e As EventArgs) Handles Button3.Click
        If ListBox1.SelectedItem Is Nothing Then
            MessageBox.Show(Me, "No File Selected!", "Select Files", MessageBoxButtons.OK)
            Return
        End If

        ' Check if any of the tag checkboxes are checked
        Dim anyCheckBoxChecked = CheckBox1.Checked OrElse CheckBox2.Checked OrElse CheckBox3.Checked OrElse
                                 (CheckBox4.Checked AndAlso Not String.IsNullOrEmpty(TextBox4.Text)) OrElse
                                 (CheckBox5.Checked AndAlso Not String.IsNullOrEmpty(TextBox5.Text)) OrElse
                                 CheckBox6.Checked OrElse CheckBox7.Checked

        If Not anyCheckBoxChecked Then
            MessageBox.Show(Me, "Select a tag to enter!", "Select Tags", MessageBoxButtons.OK)
            Return
        End If

        ' Update the ID3 tags based on the checkbox values
        If CheckBox1.Checked Then
            myMp3.ID3v2Tag.Title = TextBox1.Text
        End If

        If CheckBox2.Checked Then
            myMp3.ID3v2Tag.Artist = TextBox2.Text
        End If

        If CheckBox3.Checked Then
            myMp3.ID3v2Tag.Album = TextBox3.Text
        End If

        If CheckBox4.Checked AndAlso Not String.IsNullOrEmpty(TextBox4.Text) Then
            Short.TryParse(TextBox4.Text, myMp3.ID3v2Tag.Year)
        End If

        If CheckBox5.Checked AndAlso Not String.IsNullOrEmpty(TextBox5.Text) Then
            Short.TryParse(TextBox5.Text, myMp3.ID3v2Tag.TrackNum)
        End If

        If CheckBox6.Checked Then
            myMp3.ID3v2Tag.Comments = TextBox6.Text
        End If

        If CheckBox7.Checked Then
            myMp3.ID3v2Tag.Genre = If(ComboBox1.Text = "01 - User", TextBox7.Text, ComboBox1.Text)
        End If

        ' Write the changes to the MP3 file
        myMp3.Write()

        ' Show operation complete message
        MessageBox.Show(Me, "Operation Complete!", "Tagged Files!", MessageBoxButtons.OK)
    End Sub

    ' Event handler for clearing the list box
    Private Sub Button4_Click(sender As Object, e As EventArgs) Handles Button4.Click, Button8.Click
        ListBox1.Items.Clear()
    End Sub

    ' Event handler for handling key press events in TextBox5 and TextBox4
    ' Only allows digits and backspace to be entered
    Private Sub TextBox5_KeyPress(sender As Object, e As KeyPressEventArgs) Handles TextBox5.KeyPress, TextBox4.KeyPress
        Dim ch As Char = e.KeyChar
        If Not Char.IsDigit(ch) AndAlso Asc(ch) <> 8 Then
            e.Handled = True
        End If
    End Sub

    ' Event handler for renaming the selected file
    Private Sub Button5_Click(sender As Object, e As EventArgs) Handles Button5.Click
        If ListBox1.SelectedItem Is Nothing Then
            MessageBox.Show(Me, "No File Selected!", "Select Files", MessageBoxButtons.OK)
            Return
        End If

        ' Rename the selected file
        My.Computer.FileSystem.RenameFile(Path.Combine(FolderBrowserDialog1.SelectedPath, ListBox1.SelectedItem.ToString()), TextBox8.Text & ".mp3")

        ' Refresh the list box
        RefreshListBox()
    End Sub

    ' Event handler for moving the selected file to a different folder
    Private Sub Button7_Click(sender As Object, e As EventArgs) Handles Button7.Click
        If ListBox1.SelectedItem Is Nothing Then
            MessageBox.Show(Me, "No File Selected!", "Select Files", MessageBoxButtons.OK)
            Return
        End If

        Dim selectedFilePath As String = Path.Combine(FolderBrowserDialog1.SelectedPath, ListBox1.SelectedItem.ToString())
        Dim destinationFilePath As String = Path.Combine(TextBox9.Text, ListBox1.SelectedItem.ToString())

        ' Check if the destination file already exists
        If File.Exists(destinationFilePath) Then
            MessageBox.Show(Me, "File Exists!", "Duplicated Files!", MessageBoxButtons.OK)
            Return
        End If

        ' Move the file to the destination folder
        My.Computer.FileSystem.MoveFile(selectedFilePath, destinationFilePath)

        ' Refresh the list box
        RefreshListBox()
    End Sub

    ' Event handler for copying the selected file to a different folder
    Private Sub Button6_Click(sender As Object, e As EventArgs) Handles Button6.Click
        If ListBox1.SelectedItem Is Nothing Then
            MessageBox.Show(Me, "No File Selected!", "Select Files", MessageBoxButtons.OK)
            Return
        End If

        Dim selectedFilePath As String = Path.Combine(FolderBrowserDialog1.SelectedPath, ListBox1.SelectedItem.ToString())
        Dim destinationFilePath As String = Path.Combine(TextBox10.Text, ListBox1.SelectedItem.ToString())

        ' Check if the destination file already exists
        If File.Exists(destinationFilePath) Then
            MessageBox.Show(Me, "File Exists!", "Duplicated Files!", MessageBoxButtons.OK)
            Return
        End If

        ' Copy the file to the destination folder
        My.Computer.FileSystem.CopyFile(selectedFilePath, destinationFilePath, overwrite:=False)

        ' Refresh the list box
        RefreshListBox()
    End Sub

    ' Event handler for selecting the destination folder for move operation
    Private Sub Button9_Click(sender As Object, e As EventArgs) Handles Button9.Click
        If FolderBrowserDialog2.ShowDialog() = DialogResult.OK Then
            TextBox9.Text = FolderBrowserDialog2.SelectedPath
        End If
    End Sub

    ' Event handler for selecting the destination folder for copy operation
    Private Sub Button10_Click(sender As Object, e As EventArgs) Handles Button10.Click
        If FolderBrowserDialog3.ShowDialog() = DialogResult.OK Then
            TextBox10.Text = FolderBrowserDialog3.SelectedPath
        End If
    End Sub

    ' Event handler for selecting a new album art image
    Private Sub Button11_Click(sender As Object, e As EventArgs) Handles Button11.Click
        Dim ofd As New OpenFileDialog()
        If ofd.ShowDialog() = DialogResult.OK Then
            If Not String.IsNullOrEmpty(ofd.FileName) Then
                PictureBox1.Image = Bitmap.FromFile(ofd.FileName)
            End If
        End If
    End Sub

    ' Event handler for deleting selected files
    Private Sub Button12_Click(sender As Object, e As EventArgs) Handles Button12.Click
        For i As Integer = ListBox1.SelectedIndices.Count - 1 To 0 Step -1
            ListBox1.Items.RemoveAt(ListBox1.SelectedIndices(i))
        Next
    End Sub

    ' Event handler for filtering the list box based on the search text
    Private Sub TextBox11_TextChanged(sender As Object, e As EventArgs) Handles TextBox11.TextChanged
        RefreshListBox()
    End Sub

    ' Event handler for toggling between mass edit and single edit mode
    Private Sub Button13_Click(sender As Object, e As EventArgs) Handles Button13.Click
        If Button13.Text = "Mass Edit" Then
            Button13.Text = "Single Edit"
        Else
            Button13.Text = "Mass Edit"
        End If

        ToggleFileActionButtons()
        ToggleSelectionMode()
    End Sub

    ' Helper method to reset the label values
    Private Sub ResetLabelValues()
        Label1.Text = "Title:"
        Label2.Text = "Artist:"
        Label3.Text = "Album:"
        Label4.Text = "Year:"
        Label5.Text = "Track:"
        Label6.Text = "Comment:"
        Label7.Text = "Genre:"
        PictureBox1.Image = Nothing
    End Sub

    ' Helper method to refresh the list box
    Private Sub RefreshListBox()
        Dim selectedPath As String = FolderBrowserDialog1.SelectedPath
        ListBox1.Items.Clear()

        If Not String.IsNullOrEmpty(selectedPath) Then
            Dim fileNames = Directory.GetFiles(selectedPath, "*.mp3", SearchOption.TopDirectoryOnly)

            For Each fileName As String In fileNames
                Dim result As String = Path.GetFileName(fileName)
                ListBox1.Items.Add(result)
            Next
        End If

        ResetLabelValues()
    End Sub

    ' Helper method to toggle the enabled state of file action buttons
    Private Sub ToggleFileActionButtons()
        Button5.Enabled = Not Button5.Enabled
        Button6.Enabled = Not Button6.Enabled
        Button7.Enabled = Not Button7.Enabled
        Button8.Enabled = Not Button8.Enabled
    End Sub

    ' Helper method to toggle the selection mode of the list box
    Private Sub ToggleSelectionMode()
        If ListBox1.SelectionMode = SelectionMode.One Then
            ListBox1.SelectionMode = SelectionMode.MultiExtended
        Else
            ListBox1.SelectionMode = SelectionMode.One
        End If
    End Sub
End Class

Now, to your original problem where only the first item in your listbox is updated. This is because your 'myMp3.Write()' method inside the loop. This causes the changes to be written to the MP3 file immediately after each update. You need to move the 'myMp3.Write()' method outside the loop -

Dim items = ListBox1.SelectedItems
For Each item In items
    If CheckBox1.Checked = True Then
        myMp3.ID3v2Tag.Title = TextBox1.Text
    End If

    If CheckBox2.Checked = True Then
        myMp3.ID3v2Tag.Artist = TextBox2.Text
    End If

    If CheckBox3.Checked = True Then
        myMp3.ID3v2Tag.Album = TextBox3.Text
    End If

    If CheckBox4.Checked = True And TextBox4.Text <> "" Then
        On Error Resume Next
        myMp3.ID3v2Tag.Year = Short.Parse(TextBox4.Text)
        On Error Resume Next
    End If

    If CheckBox5.Checked = True And TextBox5.Text <> "" Then
        myMp3.ID3v2Tag.TrackNum = Short.Parse(TextBox5.Text)
    End If

    If CheckBox6.Checked = True Then
        myMp3.ID3v2Tag.Comments = TextBox6.Text
    End If

    If CheckBox7.Checked = True Then
        If ComboBox1.Text = "01 - User" Then
            myMp3.ID3v2Tag.Genre = TextBox7.Text
        Else
            myMp3.ID3v2Tag.Genre = ComboBox1.Text
        End If
    End If

    ' Write the changes to the MP3 file
    myMp3.Write()
Next

Last but not least, I could not see 1 poster that tried to help you show arrogance or attacking your methods, rather I saw them offering help but you insisted that you are not willing to learn or accept criticism to enable you to become a better developer. Rather sit back, swallow your pride and accept their answers or direction and I promise you taht you will become a top notch coder!

Member Alienoiz13-Jun-23 1:03

13-Jun-23 1:03

@Andre Hi..thanks..im still not alble to make the listbox mass edit..i must use the myMp3.Write() in each condition statement so tthat it writes only the selected tags one by one...
This is what im trying

<pre>Dim fils = ListBox1.SelectedItems
                For Each item In fils

                    If CheckBox1.Checked = True Then
                        myMp3.ID3v2Tag.Title = TextBox1.Text
                        myMp3.Write()
                    End If

                    If CheckBox2.Checked = True Then
                        myMp3.ID3v2Tag.Artist = TextBox2.Text
                        myMp3.Write()
                    End If


                    If CheckBox3.Checked = True Then
                        myMp3.ID3v2Tag.Album = TextBox3.Text
                        myMp3.Write()
                    End If


                    If CheckBox4.Checked = True And TextBox4.Text <> "" Then
                        On Error Resume Next
                        myMp3.ID3v2Tag.Year = Short.Parse(TextBox4.Text)
                        myMp3.Write()

                    End If
                    If CheckBox5.Checked = True And TextBox5.Text <> "" Then
                        On Error Resume Next
                        myMp3.ID3v2Tag.TrackNum = Short.Parse(TextBox5.Text)
                        myMp3.Write()

                    End If
                    If CheckBox6.Checked = True Then
                        myMp3.ID3v2Tag.Comments = TextBox6.Text
                        myMp3.Write()
                    End If

                    If CheckBox7.Checked = True Then
                        If ComboBox1.Text = "01 - User" Then
                            myMp3.ID3v2Tag.Genre = TextBox7.Text
                            myMp3.Write()
                        Else
                            myMp3.ID3v2Tag.Genre = ComboBox1.Text
                            myMp3.Write()
                        End If

                    End If
                Next

i also tried:

<pre>Dim fils = ListBox1.SelectedItems
                For Each item In fils

                    myMp3.Read(FolderBrowserDialog1.SelectedPath & "\" & ListBox1.SelectedItem)


                    If CheckBox1.Checked = True Then
                        myMp3.ID3v2Tag.Title = TextBox1.Text
                        myMp3.Write()
                    End If

                    If CheckBox2.Checked = True Then
                        myMp3.ID3v2Tag.Artist = TextBox2.Text
                        myMp3.Write()
                    End If


                    If CheckBox3.Checked = True Then
                        myMp3.ID3v2Tag.Album = TextBox3.Text
                        myMp3.Write()
                    End If


                    If CheckBox4.Checked = True And TextBox4.Text <> "" Then
                        On Error Resume Next
                        myMp3.ID3v2Tag.Year = Short.Parse(TextBox4.Text)
                        myMp3.Write()

                    End If
                    If CheckBox5.Checked = True And TextBox5.Text <> "" Then
                        On Error Resume Next
                        myMp3.ID3v2Tag.TrackNum = Short.Parse(TextBox5.Text)
                        myMp3.Write()

                    End If
                    If CheckBox6.Checked = True Then
                        myMp3.ID3v2Tag.Comments = TextBox6.Text
                        myMp3.Write()
                    End If

                    If CheckBox7.Checked = True Then
                        If ComboBox1.Text = "01 - User" Then
                            myMp3.ID3v2Tag.Genre = TextBox7.Text
                            myMp3.Write()
                        Else
                            myMp3.ID3v2Tag.Genre = ComboBox1.Text
                            myMp3.Write()
                        End If

                    End If
                Next