Returning a enumeration in a method

Question

0.00/5 (No votes)

See more:

I am trying to make a simple shotgun game where the user vs the CPU and the both pick shot, shield or reload but In my GetOptionFromUser method I am not sure how to return value from the enumeration method depending on what the user chose.

Any Guidance would be appreciated Here is my methods

C#

enum ShotgunOption
         {
             Shoot = 1,
             Reload = 2,
             Shield = 3,
          
             
         }
        static void DisplayMenu()
        {
             
            Console.WriteLine("Please pick an item:");
            Console.WriteLine("S - Shoot");
            Console.WriteLine("P - Shield");
            Console.WriteLine("R - Reload");         
            Console.WriteLine("X - Exit");
            
        }

       
            static ShotgunOption GetOptionFromUser()
    {
               
        char menuItem;
            DisplayMenu();
            menuItem = char.ToUpper(char.Parse(Console.ReadLine()));
            if (menuItem == 'S')
            {
                return ShotgunOption.Shoot;
            }
            else if (menuItem == 'P')
            {
                return ShotgunOption.Shield;
            }
            else if (menuItem == 'R')
            {
                return ShotgunOption.Reload;
            }
            while (menuItem != 'F' && menuItem != 'C' &&
                menuItem != 'I' && menuItem != 'X' && menuItem != 'R' && menuItem != 'D')
            {
                Console.WriteLine("Error - Invalid menu item");
                DisplayMenu();
                menuItem = char.ToUpper(char.Parse(Console.ReadLine()));
            }
        }

        
    
        
        static void DisplayResults(ShotgunOption UserOption,ShotgunOption CPUOption, int UserScore, int UserBullets, int CPUBullets)
    {
        Console.Clear();
        Console.WriteLine("Giving up?");
        Console.WriteLine("You Chose {0}, The Computer Chose{1} Your Score is {3} . You had {4} Bullet(s). The CPU had {5} bullets(s).", UserOption, CPUOption, UserScore, UserBullets, CPUBullets);
        Console.WriteLine("Thanks for playing!");
        Console.ReadKey();

    }

Posted 23-Jun-15 20:12pm

Josh909

Add a Solution

2 solutions

Solution 2

You major problem is not what you described, but the way you write your code. You violate the SPOT principle, which makes your code unsupportable and development error-prone. Not only you hard-code immediate constants (as far as your enumeration problem is concerned, these are strings/characters), but you repeat the same "magic strings" in more than one place of the code.
Please see: http://en.wikipedia.org/wiki/Single_Point_of_Truth[^].

Big bunch of problems related to enumerations are solved in two my articles. It includes enumeration looping through the enumeration type members, using enumeration types as array indices and definition and use of human-readable enumeration member names:
Enumeration Types do not Enumerate! Working around .NET and Language Limitations[^],
Human-readable Enumeration Meta-data[^].

You can also learn other useful techniques related to enumerations.

—SA

Posted 23-Jun-15 21:11pm

Sergey Alexandrovich Kryukov

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sinisa Hajnal · Accepted Answer · 2015-06-23T20:27:00

Your while conditions don't match menu options...other then that it seems you're returning options just fine. Remove first set of if conditions, replace while loop with do..while and put those ifs inside:

C#

static ShotgunOption GetOptionFromUser()
  {

      char menuItem;
          
          
          do 
    {
        DisplayMenu();
          menuItem = char.ToUpper(char.Parse(Console.ReadLine()));

              if (menuItem == 'S')
          {
              return ShotgunOption.Shoot;
          }
          else if (menuItem == 'P')
          {
              return ShotgunOption.Shield;
          }
          else if (menuItem == 'R')
          {
              return ShotgunOption.Reload;
          }
else {
Console.WriteLine("Error - Invalid menu item");
}
while (menuItem != 'F' && menuItem != 'C' &&
              menuItem != 'I' && menuItem != 'X' && menuItem != 'R' && menuItem != 'D')

          }
      }

I didn't touch the conditions because they do not relate to the menu so maybe you have some more application logic hidden...play with it for a bit.

Good luck.