ASP.NET image control is not showing latest uploaded photo

Question

0.00/5 (No votes)

See more:

Hi,

In Page_Load, I am assigning an image to:

XML

<asp:image id="imgPhoto" runat="server" xmlns:asp="#unknown"></asp:image>

Here is my code:

page_load
============

C#

string photo = siteurl + DBUtilities.ExecuteScalar(DBConnections.GetSQLConnectionString(), CommandType.Text, "select photo from visitors_images where visitor_id='" + Request.QueryString["visitor_no"].ToString() + "'").ToString();
            if (IsExists(photo))
                imgPhoto.ImageUrl = photo;
            else
                imgPhoto.ImageUrl = "~/includes/images/no_person.jpg";

Submit_button
=============

C#

fulPhoto.SaveAs(Server.MapPath("~/includes/visitors/" + IMGNAME));
DBUtilities.ExecuteNonQuery(DBConnections.GetSQLConnectionString(), CommandType.Text, "UPDATE visitors_images SET photo='" + IMGNAME + "' WHERE visitor_id='" + Request.QueryString["visitor_no"].ToString() + "'");
Response.Redirect(Request.RawUrl.ToString());

But, if I refresh manually, it shows the latest photo. Can you please give some suggestion.

Thanks!

Posted 22-Aug-10 23:45pm

ntrraorao

Updated 23-Aug-10 8:28am

Deeksha Shenoy

v5

Add a Solution

Comments

Ankur^\m/ 23-Aug-10 5:56am

I tried improving your question but it seems you didn't write the 'image button' part correctly. Please modify it.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Christian Graus · Answer 1 · 2010-08-22T23:53:00

Well, you should perhaps read a book on ASP.NET, and know a bit about your subject before you call yourself 'hire me for your work'. Your issues are legion, your code is a disaster, and I could easy erase your database because your site is insecure and poorly written.

Your core issue is that you don't understand the ASP.NET page lifecycle. Do you know how to use the debugger ? If you did, and you set some breakpoints, you'd notice that page load runs BEFORE your button event, so it loads the OLD photo, then your event changes the photo, so the next time you refresh, you'll see the new one. If you can't write this code properly ( and if you cannot, I hope no poor sucker has 'hired you' to write it ), then at least move it to page prerender, and it will work fine.

Bryian Tan · Answer 2 · 2010-08-23T01:35:00

hello,

I agree with the post above, the current code is open to SQL Injection.[^]

Here is a quick solution to bypass the browser cache, try append a random number in the query string. Make sure you fix the problems mentioned by Christian.

MIDL

Random r = new Random();
        int RandomNumber = r.Next();

Response.Redirect(Request.RawUrl.ToString()+"?r=" + RandomNumber.ToString();

Abhishek Sur · Answer 3 · 2010-08-23T09:22:00

Why dont you set the

imgPhoto.ImageUrl

after you upload the image.
Means after you do
fulPhoto.SaveAs(Server.MapPath("~/includes/visitors/" + IMGNAME));

This will make sure that the proper image link is transferred to the control.

If there is a full postback, and you save the file synchronously, the image should be displayed. Dont use any thread to save the file.

ASP.NET image control is not showing latest uploaded photo

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0