Problem in displaying a button in my main window

Question

0.00/5 (No votes)

See more:

Sir, I have a problem in creating some buttons in my main window.
I have no errors and no warnings in creating a button but I cannot see my button on my main window,

C++

//My code in initializing the instance function [ BOOL  InitInstance(HINSTANCE hInstance, int nCmdShow) ]

HWND button1;

button1 = CreateWindow(L"button", L"Run Timer", WS_CHILD | WS_VISIBLE | BS_DEFPUSHBUTTON | BS_FLAT, 0, 180, 197, 90, button1, (HMENU)IDC_VS_TIME, hInst, NULL);
ShowWindow(button1, nCmdShow);
UpdateWindow(button1);

What I have tried:

Since I am learning I am not sure of spotting the bug,
I see my main window displaying so I tried copying its HWND variable hWnd to my button 1 like this,

C++

button1 = CreateWindow(L"button", L"Run Timer", WS_CHILD | WS_VISIBLE | BS_DEFPUSHBUTTON | BS_FLAT, 0, 180, 197, 90, hWnd, (HMENU)IDC_VS_TIME, hInst, NULL);
//changed button1 to hWnd

ShowWindow(hWnd, nCmdShow);
UpdateWindow(hWnd);

I changed button1 to hWnd and my button gets displayed I did also compared both the code but I can't find anything.

Posted 24-Feb-16 4:02am

VISWESWARAN1998

Updated 24-Feb-16 6:52am

KarstenK

v2

Add a Solution

Comments

Jochen Arndt 24-Feb-16 10:21am

And what is the problem now after passing the correct parameters to CreateWindow()?

Read the documentation at https://msdn.microsoft.com/en-us/library/windows/desktop/ms632679(v=vs.85).aspx:

hWndParent
A handle to the parent or owner window of the window being created. To create a child window or an owned window, supply a valid window handle.

A button is a child window (located inside another - the parent - window). So you must pass a handle to that window.

[no name] 24-Feb-16 11:28am

Sir, From the link you have given to me I find that my try is the correct one because hWnd is the variable which handles the man window.Sir, is this a correct one or not? because I see my buttons when I use hWnd.

Thank you for your kind help.

Richard MacCutchan 24-Feb-16 11:47am

The HWND variable in the CreateWindow call must be the handle of the parent window where the button is to be displayed. Thus your second version is correct.

[no name] 25-Feb-16 11:46am

Thank you sir for your kind help

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

KarstenK · Accepted Answer · 2016-02-24T06:52:00

The parent in your first call is a bug, because it is the button1 and NOT a parent windows.

C++

HWND button1;
 
button1 = CreateWindow(L"button", L"Run Timer", WS_CHILD | WS_VISIBLE | BS_DEFPUSHBUTTON | BS_FLAT, 0, 180, 197, 90, button1, (HMENU)IDC_VS_TIME, hInst, NULL);

The answer from Richard is right: You must provide a valid parent window as your second code shows .