Delete multiple checked checkbox

Question

2.00/5 (1 vote)

See more:

hi, my JSP code doesn't work... i cant find a solution for this..

my checkbox are select but doesn't do the SQL part.. Take a look pls

JavaScript

	Statement psSelectRecord = null;
	ResultSet rsSelectRecord = null;
	String sqlSelectRecord = null;
	String check[] = request.getParameterValues("checkbox");
	String subm = request.getParameter("submit");
	Connection conn = (Connection) ses.getAttribute("conn");
	
	
	try{
		if(check != null ){
			for(int i = 0; i< check.length;i++){
				String x = check[i];
				
				sqlSelectRecord ="DELETE FROM utilizador WHERE id='"+x+"'";
				psSelectRecord=conn.createStatement();
				psSelectRecord.executeUpdate(sqlSelectRecord);
				
			}
			
		}
		
		}catch (Exception e) {
	%>
		<script type="text/javascript">alert("Não selecionou nenhum user!")
		window.location= "javascript:history.back()";</script>
</html>
	<%
	}
	
	%>

<pre lang="HTML">

ASP.NET

<%@ page language="java" import="java.sql.*"%>
<%@ page contentType="text/html; charset=UTF-8"%>
<%@ include file="basedados.h" %>
<%
String usertype = (String) session.getAttribute("descricao");
Connection conn = (Connection) ses.getAttribute("conn");	
try{
		if( usertype.equals("presidente") ) {
			
			Statement psSelectRecord = null;
			ResultSet rsSelectRecord = null;
			String sql = null;
			sql = "SELECT * FROM utilizador";
			psSelectRecord = conn.createStatement();
			rsSelectRecord = psSelectRecord.executeQuery(sql);
	%>
<html>
    <body>
        <form>
		<form action=apagar_utilizadorX.jsp" method="get">
		<table border="1" cellspacing="1" cellpadding="1">
            <tr>
                <th>ID</th>
                <th>Nome</th>
				<th>Login</th>
                <th>Password</th>
				<th>Tipo de Utilizador</th>
				<th>Telefone</th>
				<th>Morada</th>
				<th>Email</th>
				<th>Cartao Cidadao</th>
				<th>Cartao Caça</th>
				<th>NIF</th>
				<th></th>
			</tr>
            <%
            int cnt=1; 
            while(rsSelectRecord.next()){
            %>
            <tr>
                <td><%=rsSelectRecord.getString("id")%>&nbsp;</td>
                <td><%=rsSelectRecord.getString("nome")%>&nbsp;</td>
                <td><%=rsSelectRecord.getString("login")%>&nbsp;</td>
				<td><%=rsSelectRecord.getString("password")%>&nbsp;</td>
                <td><%=rsSelectRecord.getString("utilizadortipo")%>&nbsp;</td>
                <td><%=rsSelectRecord.getString("telefone")%>&nbsp;</td>
				<td><%=rsSelectRecord.getString("morada")%>&nbsp;</td>
				<td><%=rsSelectRecord.getString("email")%>&nbsp;</td>
				<td><%=rsSelectRecord.getString("cartaoCidadao")%>&nbsp;</td>
				<td><%=rsSelectRecord.getString("cartaoCaca")%>&nbsp;</td>
				<td><%=rsSelectRecord.getString("nif")%>&nbsp;</td>
				<td><input type="checkbox" name="checkbox" value="<%=cnt%>"><br></td>
			</tr>
           <%
            cnt++; 
            } 
            %>
				 <input type="submit" name ="submit" value="Eliminar!">
		</table>
    <form/>
	</body>
 </html>
	<%
	
		
		} 
	}catch (Exception e) {
	%>
		<script type="text/javascript">alert("Acesso Restrito")
		window.location= "javascript:history.back()";</script>
</html>
	<%
	}
	%>

What I have tried:

My error is on connection with database .. i know it but i cant find a solution

Posted 10-Jun-16 8:50am

Member 12577124

Add a Solution

Comments

Richard Deeming 10-Jun-16 14:08pm

Your code is vulnerable to SQL Injection[^]. NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]

Sergey Alexandrovich Kryukov 10-Jun-16 14:43pm

What does it mean: "my checkbox are select but doesn't do the SQL part"?
—SA

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Delete multiple checked checkbox

Add your solution here

Preview 0

Delete multiple checked checkbox

Add your solution here

Preview 0

Existing Members

...or Join us