How can I calculate the correct grade

Question

1.00/5 (1 vote)

See more:

hi
I wonder if someone can help me with this issue.

The issue is i am having is that the correct grade and score is not being calculated when the person selects P/m/d grades. btw this is not homework i was creating this script to help students with calculating their grade

would appreciate it if i can get some help in resolving this

What I have tried:

JavaScript

var units = 3;
var ocr = 0;
var grade = "";
var feedback = "";

function runCert()
{
document.getElementById("o1").disabled=false;
document.getElementById("o2").disabled=false;
document.getElementById("o3").disabled=true;
document.getElementById("o1").style.backgroundColor="#CCFFCC";
document.getElementById("o2").style.backgroundColor="#CCFFCC";
document.getElementById("o3").style.backgroundColor="#FFCCCC";
units = 2;
}

function runScore()
{
	ocr = 0;
	
	
	function assistScore(con1)
{
	if (document.getElementById("o1").disabled=false == "P") ocr = ocr + 21;
	if (document.getElementById("o1").disabled=false == "M") ocr = ocr + 24;
	if (document.getElementById("o1").disabled=false == "D") ocr = ocr + 27;
	
	if (document.getElementById("o2").disabled=false == "P") ocr = ocr + 21;
	if (document.getElementById("o2").disabled=false == "M") ocr = ocr + 24;
	if (document.getElementById("o2").disabled=false == "D") ocr = ocr + 27;
	
	if (document.getElementById("o3").disabled=false == "P") ocr = ocr + 14;
	if (document.getElementById("o3").disabled=false == "M") ocr = ocr + 16;
	if (document.getElementById("o3").disabled=false == "D") ocr = ocr + 18;	
}
	
	
	
if (units == 2)
	{
		assistScore(document.getElementById("o1").value);
		assistScore(document.getElementById("o2").value);
			

		if (ocr >= 52)
		{
			ucas = 28;
			grade = "D*";
			feedback = "This is the highest grade available";
		}
		else if (ocr >= 50)
		{
			ucas = 24;
			grade = "D";
			feedback = "You are " + (50 - ocr) + " ocr points short of the next grade boundary";
		}
		else if (ocr >= 46)
		{
			ucas = 40;
			grade = "M";
			feedback = "You are " + (46 - ocr) + " ocr points short of the next grade boundary";
		}
		else
		{
			ucas = 8;
			grade = "P";
			feedback = "You are " + (42 - ocr) + " ocr points short of the next grade boundary";
		}
		
		
	}
	
	alert("ocr Score: " + ocr + "\n\nocr Grade: " + grade + "\n\nUCAS Points: " + ucas + "\n\n" + feedback);


}

HTML

<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Untitled Document




  
    
      
      
    
    
      
      
      
      
    
    
      
      
      
      
    
    
      
      
      
      
    
    
      
      
      
      
    
  <table width="933" height="251" border="1"><tbody><tr><td colspan="3">OCR grade calculator </td><td width="199"> </td></tr><tr><td width="201">unit #</td><td width="217">name </td><td width="288">mark </td><td>your course</td></tr><tr><td style="width: 98px">1</td><td style="width: 221px">Fundamentals of IT</td><td>
        Select
        P
        M
        D
      </td><td>
Certificate (2 units)</td></tr><tr><td style="width: 98px">2</td><td style="width: 221px">Global Information</td><td>
        Select
        P
        M
        D
      </td><td></td></tr><tr><td style="width: 98px">3</td><td style="width: 221px">Cyber Security</td><td>
        Select
        P
        M
        D
      </td><td> </td></tr></tbody></table>
  <p> </p>
  <p> </p>
  <p> </p>
  <p> </p>

Posted 19-May-17 0:45am

Member 13210587

Updated 19-May-17 11:34am

phil.o

v2

Add a Solution

Comments

Richard MacCutchan 19-May-17 7:06am

You have not explained what the problem is. And please format your code properly with <pre> tags, so it is readable

phil.o 19-May-17 8:23am

I formatted the code for you. This is malformed. There is a closing bracket missing in the javascript part, and the html part is not valid xml, yet html. Is this a copy/paste error, or is it your actual code? Please clarify.

Member 13210587 19-May-17 8:57am

Hi Phil.o many thanks for formatting this. the script allows students to select their grade for unit 1 and 2 and then calculate their final grade, score and ucas points. the script is still work in progress. current issue is that when the users select their grade the system does not calculate the correct score and grade
regards

ZurdoDev 19-May-17 9:19am

All you have to do is debug it. Put a breakpoint on one of the lines and step through and see what is happening. Very simple.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

W∴ Balboos, *GHB* · Answer 1 · 2017-05-19T05:35:00

Solution 1

You have at least nine of these, with various "o#" and letters.

if (document.getElementById("o1").disabled=false == "P") ocr = ocr + 21;

They will always evaluate to false, since

document.getElementById("o1").disabled=false

doesn't return a character value

So the incrementing of ocr will never occur and the value will never be correct.

Posted 19-May-17 5:35am

W∴ Balboos, GHB

Comments

Maciej Los 19-May-17 14:53pm

5ed!

Patrice T · Answer 2 · 2017-05-19T11:34:00

When you don't understand what your code is doing or why it does what it does, the answer is debugger.
Use the debugger to see what your code is doing. Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute, it is an incredible learning tool.

Debugger - Wikipedia, the free encyclopedia[^]
JavaScript Debugging[^]
Chrome DevTools | Web | Google Developers[^]
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't find bugs, it just help you to. When the code don't do what is expected, you are close to a bug.