Click here to Skip to main content
15,745,574 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
below is my code plz someone debug this

What I have tried:

using namespace std;
void SortingOfString(char c[])
    int length = strlen(c);
    for(int i = 0; i < length; i++)
        if(int(c[i]) > int(c[i + 1]))
            char temp = c[i+1];
            c[i+1] = c[i];
            c[i] = temp;

cout << c;


int main()
    char c[50];
    cout << "enter a string" <<endl;
Updated 16-Jun-17 5:17am

You program is trying, without luck, to sort the characters of a C-like string.
Either if you need to sort characters or actual strings, I suggest you to use C++ Standard Library classes for the purpose. See, for instance sort - C++ Reference[^].
Share this answer
Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
private int Double(int value)
   return value * value;

Once you have an idea what might be going wrong, start using teh debugger to find out why. Put a breakpoint on your line:

and run your app. Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?

This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!

Yes, I could probably tell you what "the problem" is - but it's not difficult to do this yourself, and you will learn something really worthwhile at the same time!
Share this answer
How to do sorting in strings by alphabetical order?

First of all, your code try to sort the contain of 1 string, it does not try to sort strings.
below is my code plz someone debug this

You do not stated a problem. In fact, your code is not a sorting routine at all.
About half the code is missing, and what is here have bugs.
Length is the number of chars in the string, i is from 0 to Length-1, but you compare with char i+1 which ends 1 char afyer the end of string.

My solution: Learn Debugger.
There is a tool that allow you to see what your code is doing, its name is debugger.
It is also a great learning tool because it show you reality and you can see which expectation match reality.
Use the debugger to see what your code is doing. Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute, it is an incredible learning tool.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't find bugs, it just help you to. When the code don't do what is expected, you are close to a bug.
Share this answer

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900