Click here to Skip to main content
14,836,622 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
To write a c program to find the biggest of n numbers.
The output doesn't show the print statement. And having confusion on where to use the break statement.

What I have tried:

c
#include <conio.h>
#include <stdio.h>

int main(){
	
	int total[100];
	int count = 0, i=0;
	int num, j, k;
	
	printf("Enter the number: \t");
	scanf(" %d", &num);
	
	
	while(num!=0){
	
		total[i] = num%10;
		
		count++; // for every number it increments i.e. it is the length of the num entered.
		
		num /= 10 ;
		i++;
	}

	
/*	printf(" %d \n", count);
	
	for(j=0;j<=count-1; j++){
		
		printf(" %d", total[j]);
	}
*/	
	
	for(j=1; j<=count; j++){
		
		for(k=1; k<=count; k++){
			
			if(total[j] > total[k]){	/*for total[j] it will check if it is greater then all the
										others	or not */
										
				printf(" %d is the greatest number", total[j]);
				
				//break;
			}
			
			//break;
		}
	}
	
	getch();
	return 0;
}
Posted
Updated 5-Oct-17 12:33pm
v2

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
C#
int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using teh debugger to find out why. Put a breakpoint on your line:
C#
for(j=1; j<=count; j++){

and run your app. Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Use the debugger to look at what values variables contain. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?

This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
   
It is not the printing but the logic of your program. Instead of printing every time when an item is greater than the other, you should use a variable to hold the maximum number found so far and print that after all items has been checked:
C++
// Assume first number is max for now
int max = total[0];
for (j = 1; j < count; j++)
{
    if (total[j] > max)
        max = total[j];
}
printf(" %d is the greatest number\n", max);
Or if you need the index for the maximum number:
C++
int max_index = 0;
for (j = 1; j < count; j++)
{
    if (total[j] > total[max_index])
        max_index = j;
}
printf(" %d is the greatest number\n", total[max_index]);
   
Comments
CPallini 5-Oct-17 8:37am
   
Also, the for loop should set j initial value to 0.
Jochen Arndt 5-Oct-17 9:02am
   
I have initialised max / max_index (see also the comment on the first code snippet) so that the check can start at j = 1.

Or do you refer to the original code?
CPallini 5-Oct-17 10:46am
   
Oh, never mind. My bad.
Tarun Jha 8-Oct-17 2:28am
   
the original code please. it will be easier to understand
It looks you are trying to find out the greatest digit of the input number. For such a task you don't need neither the array nor the for loops: just extract it -on-the-fly:
C
#include <stdio.h>

int main()
{
  int num;
  int greatest_digit = 0;

  printf("Enter the number: \t");
  scanf(" %d", &num);

  while( num != 0 )
  {
    int digit = num % 10;
    if (greatest_digit < digit) greatest_digit = digit;
    num /= 10 ;
  }

  printf("the greatest digit is %d\n", greatest_digit);

  getchar();

  return 0;
}
   
Quote:
Having problems with for loop in C, it doesn't print the output ?

When you don't understand why your code fail, it is time use debugger.

There is a tool that allow you to see what your code is doing, its name is debugger. It is also a great learning tool because it show you reality and you can see which expectation match reality.
When you don't understand what your code is doing or why it does what it does, the answer is debugger.
Use the debugger to see what your code is doing. Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't find bugs, it just help you to. When the code don't do what is expected, you are close to a bug.
   

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)




CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900