Click here to Skip to main content
15,999,717 members
Please Sign up or sign in to vote.
0.00/5 (No votes)
See more:
DataTable dt = new DataTable();
OleDbConnection conn = GetConnectionMDB1();
OleDbDataAdapter da = new OleDbDataAdapter("Select distinct srno,EntryDate,EntryTime,EmpCode from AttenInfo", conn);
da.Fill(dt);
int TotalRow = dt.Rows.Count;
string[] res = new string[TotalRow];
for (int i = 0; i < TotalRow; i++)
{
OleDbConnection conn1 = GetConnectionMDB2();
OleDbCommand cmd = new OleDbCommand();
cmd.CommandType = CommandType.Text;
cmd.Connection = conn1;
DataTable dt2 = new DataTable();
OleDbDataAdapter da2 = new OleDbDataAdapter("select * from AttenInfo where EntryDate =Format('" + dt.Rows[i][1].ToString().Substring(0, 10) + "', 'dd/mm/yyyy') and EntryTime='" + dt.Rows[i][2].ToString() + "' and srno=" + dt.Rows[i][0].ToString() + " and EmpCode='" + dt.Rows[i][3].ToString()+"'", conn1);
da2.Fill(dt2);

}

What I have tried:

I have take a data from one MDB to insert data in another data avoid duplicate data but in some time this error is occurred.
Posted
Updated 18-Dec-17 20:04pm
v2

1 solution

Don't do it like that! Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'
The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'
Which SQL sees as three separate commands:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';
A perfectly valid SELECT
SQL
DROP TABLE MyTable;
A perfectly valid "delete the table" command
SQL
--'
And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?

Fix that, and the chances are that your other problem will disappear at the same time.
 
Share this answer
 

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900