Even when I successfully login it still prints the string "user incorrect" how do I stop this from happening?

Question

0.00/5 (No votes)

See more:

Python

# Test Login 

userlist = {"user" : "password", "user2" : "password2"}

login = input('do you have an account (Y/N)?')
if (login == 'n'):
    New_User = input('create user: ')
    New_Pass = input('create password: ')
    userlist[New_User] = New_Pass

loop = 'true'
while (loop == 'true'):
    username = input("Please enter your username: ")
    for x in userlist:
        if (username == x):
            password = input("Please enter your password: ")
            if (password == userlist[x]):
                print ("Logged in successfully as " + username)
                loop = 'false'
            else:
                print ("Password incorrect!")
        else: 
            print ("User incorrect")

What I have tried:

Python

# Test Login 

userlist = {"user" : "password", "user2" : "password2"}

login = input('do you have an account (Y/N)?')
if (login == 'n'):
    New_User = input('create user: ')
    New_Pass = input('create password: ')
    userlist[New_User] = New_Pass

loop = 'true'
while (loop == 'true'):
    username = input("Please enter your username: ")
    for x in userlist:
        if (username == x):
            password = input("Please enter your password: ")
            if (password == userlist[x]):
                print ("Logged in successfully as " + username)
                loop = 'false'
            else:
                print ("Password incorrect!")
    else: 
        print ("User incorrect")

Posted 26-Jan-18 17:20pm

Member 13646633

Updated 26-Jan-18 20:18pm

PIEBALDconsult

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Answer 1 · 2018-01-26T19:35:00

For debuf purpose, change your code to:

Python

userlist = {"user" : "password", "user2" : "password2", "user3" : "password3", "user4" : "password4", "user5" : "password5"}

and:

Python

print ("User incorrect "+x)

and run the code.

You will see that the message is printed every time the input is not the username you check. The problem is your logic, you know the user is incorrect only once you have checked against every usernames in your list and that there was no match.
What you have to do:

Python

loop in userlist
  check for a match with input
if there was no match
  user is inxorrect

There is a tool that allow you to see what your code is doing, its name is debugger. It is also a great learning tool because it show you reality and you can see which expectation match reality.
When you don't understand what your code is doing or why it does what it does, the answer is debugger.
Use the debugger to see what your code is doing. Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]
27.3. pdb — The Python Debugger — Python 3.6.1 documentation[^]
Debugging in Python | Python Conquers The Universe[^]
pdb – Interactive Debugger - Python Module of the Week[^]
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't find bugs, it just help you to. When the code don't do what is expected, you are close to a bug.