I am try to insert sequence numbers into a SQL table

Question

0.00/5 (No votes)

See more:

I am trying to insert a sequence number into a table using sql but it is only inserting one record

What I have tried:

alter PROCEDURE NumGen
(
@Numgen BIGINT
) 

AS
DECLARE @Counter BIGINT
SET @Counter = 1000

WHILE @Counter = @Numgen
BEGIN 
INSERT INTO dbo.NumberGen
(
    Num
)
SELECT  @Counter
	SET @Counter = @Counter + 1 ;
END 

SELECT * FROM dbo.NumberGen

Posted 15-Aug-18 2:45am

MarkNinja

Updated 15-Aug-18 3:07am

Add a Solution

Comments

Herman<T>.Instance 15-Aug-18 8:47am

WHILE @Counter = @Numgen ...... WHILE @Counter < @Numgen ??

SET @Counter = 1000 ???

What are you trying?

MarkNinja 15-Aug-18 9:26am

i am trying to do this

116049610000000
116049610000001
116049610000002
116049610000003
116049610000004
116049610000005
116049610000006
116049610000007
116049610000008
116049610000009
116049610000010
116049610000011
116049610000012
116049610000013
116049610000014
116049610000015

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2018-08-15T03:07:00

Solution 1

Look at your code:

SQL

SET @Counter = 1000
WHILE @Counter = @Numgen
BEGIN  
   ...
   SET @Counter = @Counter + 1 ;
END

It will only insert one row, if you start by asking for a thousand...
Perhaps <, <=, >=, or > would be better?

Posted 15-Aug-18 3:07am

OriginalGriff

Comments

Herman<T>.Instance 15-Aug-18 9:29am

indeed a mix up of variables to use and good logic