Can anyone explain why my code deletes indiscriminately?

Question

0.00/5 (No votes)

See more:

Hi there, I'm pretty new to linq and I've decided to make a program which takes in a file directory, read in a file extension and the age of the target file(s). The main objective is to simply delete files using file extension but to only target older files(1 week old, 3 month old or more).

I've tested the winform which houses the linq statement on older files however it seems to be unable to distinguish the old from the new.(of course I created a back up for those files in case some goes horrible wrong).

Any help would be greatly appreciated and sorry for the presentation of the code below as it has taken on a different form after the copy and paste.

What I have tried:

protected void log()
        {
           
            string path = fileLocation.Text;
            string fullPath = string.Format(@"{0}\File_Deletion_Log.txt", path);
            File.AppendAllLines(fullPath, new[] {"File Deletion Complete    " + string.Format("{0:yyyy-MM-dd}   ",DateTime.Now) + string.Format("Files Deleted: {0}",Count)});
            Count = 0;
        }
        protected void button1_Click(object sender, EventArgs e)
        {   
                string extensions = fileExtension.Text;

                    var files = new DirectoryInfo(fileLocation.Text).GetFiles("*", SearchOption.AllDirectories)
                                     .Select(p => new FileInfo(Convert.ToString(p)))
                                     .Where(p => p.CreationTime < DateTime.Now.Subtract(TimeSpan.FromDays(Convert.ToInt32(fileAge.Text))))
                                     .Where(p => string.Compare(p.Extension, extensions, true) == 0);
                    foreach (var file in files)
                    {
                        file.Attributes = FileAttributes.Normal;
                        File.Delete(file.FullName);
                        Count++;
                    }
                    MessageBox.Show(string.Format("Total Number of files deleted:   {0}", Count));
                    log();

Posted 7-Mar-19 22:11pm

Graeme Cooper

Updated 7-Mar-19 23:41pm

Add a Solution

2 solutions

Solution 2

It is not clear where your fileAge comes from but you could try TimeSpan.FromDays(90) to narrow the problem down. And skip the delete while debugging. Just print the filenames.

Posted 7-Mar-19 23:41pm

megaadam

v2

Comments

Graeme Cooper 8-Mar-19 6:40am

Sorry about that, fileAge.Text is the user input.
fileAge.Text: How old is your file you wish to delete or another way of saying Delete files that are older than x days.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2019-03-07T22:23:00

Without your files to test against, we can't do much at all - so start by "breaking down" the Linq into separate statements:

C#

var files = new DirectoryInfo(fileLocation.Text).GetFiles("*", SearchOption.AllDirectories);
var selected = files.Select(p => new FileInfo(Convert.ToString(p))).ToList();
DateTime limit = DateTime.Now.Subtract(TimeSpan.FromDays(Convert.ToInt32(fileAge.Text)));
var where = selected.Where(p => p.CreationTime < limit).ToList();
var where2 = where.Where(p => string.Compare(p.Extension, extensions, true) == 0).ToList();

Then you can step through looking at each stage in the process to see exactly what is being processed and what results you get.

Hopefully, that will give you some info on where teh problem is.