Change Label.Text in any step in the loop

Question

4.00/5 (1 vote)

See more:

I want in this code in the any step label show the Number of that step.
In the my code just show last number in the label!

I also Label.Invalidate() the done, but do not work.

private void button1_Click(object sender, EventArgs e)
   {
       int i = 0;
       while (i<100)
       {
           i++;
           label1.Text = string.Format("Step is :{0}", i);
           System.Threading.Thread.Sleep(1000);
       }
   }

Posted 2-Feb-11 8:53am

User 7427435

Updated 2-Feb-11 14:38pm

Sergey Alexandrovich Kryukov

v4

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Henry Minute · Answer 1 · 2011-02-02T09:03:00

Your Label is unable to display the step numbers either because your steps complete so quickly that it the last number is the only one on screen long enough to register, or, more likely, because the main thread, which also deals with displaying the GUI, is so busy doing your steps that it has no time to display the numbers.

I'll let you guess which is happening.

Here[^] is an article that does roughly what you need. See if you can adapt the code in it for your application.

Sergey Alexandrovich Kryukov · Answer 2 · 2011-02-02T10:29:00

I already gave a comprehensive answer to another question, see

Changes step by step to show a control[^].

You can use BackgroundWorker class.

What you're trying to do is a big sin: 1) your are blocking UI thread with you sleep, 2) you're assigning property in the loop, but in can not be processed because you are blocking event processing of the main UI loop; DoEvent is a big no-no (as a rule of thumb).

—SA

AspDotNetDev · Answer 3 · 2011-02-02T12:42:00

There are better ways, but here is the simple way that will show you the basics:

C#

private void button1_Click(object sender, EventArgs e)
{
    var t = new System.Threading.Thread(new System.Threading.ThreadStart(() =>
    {
        int i = 0;
        while (i < 10)
        {
            i++;
            var ts = new System.Threading.ThreadStart(() =>
            {
                label1.Text = string.Format("Step is: {0}", i.ToString());
            });
            if (this.InvokeRequired)
                this.Invoke(ts);
            else
                ts();
            System.Threading.Thread.Sleep(1000);
        }
    }));
    t.Start();
}

Basically, you run your code on a different thread than the main thread. This frees the main thread to perform UI updates. Whenever you need to change the UI, you must invoke your code on the main thread.

Change Label.Text in any step in the loop

3 solutions

Solution 2

Solution 4

Solution 5

Add your solution here

Preview 0