Help needed creating methods within a simple program

Question

1.00/5 (1 vote)

See more:

I need help creating a method within a simple program.

I basically created a grade report sheet where I input 5 grades it returns the average score. I also have a combobox in which you have to select a major. I used an if statement to retrieve the letter grade and use a switch to determine the grade you need to get into a major.

The basic format I was shown was:

VB

public string DetermineLetterGrade
            (double courseAverage)

and then obviously a return of lettergrade

C#

private void btnCalculateGrade_Click_1(object sender, RoutedEventArgs e)
        {
            string studentName;
            int homework1;
            int homework2;
            int quiz1;
            int quiz2;
            int finalExam;
            string letterGrade = "Incomplete";
            string major = "unknown";
            double homeworkContribution;
            double quizContribution;
            double finalExamContribution;
            double courseAverage;

            const double homeworkWeight = 0.25;
            const double quizWeight = .35;
            const double finalExamWeight = .40;

           

            studentName = (tbStudentName.Text);
            homework1 = Convert.ToInt32(tbHomework1.Text);
            homework2 = Convert.ToInt32(tbHomework2.Text);
            quiz1 = Convert.ToInt32(tbQuiz1.Text);
            quiz2 = Convert.ToInt32(tbQuiz2.Text);
            finalExam = Convert.ToInt32(tbFinal.Text);
            major = Convert.ToString(cbDepartment.SelectionBoxItem);
            homeworkContribution = (homework1 + homework2) / 2 * homeworkWeight;
            quizContribution = (quiz1 + quiz2) / 2 * quizWeight;
            finalExamContribution = (finalExam) * finalExamWeight;
            courseAverage = homeworkContribution + quizContribution + finalExamContribution;


   


            if (courseAverage >= 90)
            {
                letterGrade = "A";
            }
            else if (courseAverage > 80)
            {
                letterGrade = "B";
            }
            else if (courseAverage > 70)
            {
                letterGrade = "C";
            }
            else if (courseAverage > 60)
            {
                letterGrade = "D";
            }
            else
            {
                letterGrade = "F";
            }




    string businessCollegeRequirement = "unknown";
            switch (major)
            {
                case "Accounting":
                case "MIS":
                    businessCollegeRequirement = "need at least an B";
                    break;
                case "Economics":
                case "Finance":
                case "Marketing":
                    businessCollegeRequirement = "Need at least a C";
                    break;
                case "Management":
                    businessCollegeRequirement = "Need at least a D";
                    break;

            }

            lblResult.Content = studentName + "'s" + "Course Average:" + courseAverage;
            lblResult.Content += "\nletterGrade:" + letterGrade;
            lblResult.Content += "\nRequirement: " + businessCollegeRequirement;
            lblResult.Content += "\nMajor: " + major;


        }
    }//end class
}//end namespace

C#

if (courseAverage >= 90)
           {
               letterGrade = "A";
           }
           else if (courseAverage > 80)
           {
               letterGrade = "B";
           }
           else if (courseAverage > 70)
           {
               letterGrade = "C";
           }
           else if (courseAverage > 60)
           {
               letterGrade = "D";
           }
           else
           {
               letterGrade = "F";
           }

Posted 16-Mar-11 18:40pm

surveygirl13

Updated 16-Mar-11 19:26pm

v3

Add a Solution

Comments

GauravKP 17-Mar-11 1:02am

so where is your problem...

Sergey Alexandrovich Kryukov 17-Mar-11 2:32am

OP commented:

I have no problem using the plain if structure to retrieve my grade but I have no Idea how to convert it to a method. It is probably something simple but I'm clueless.

For example if I just add public String GetGrade(double courseAverage) I get an extraordinary amount of errors.

It tells me I need a } after my variables and constants (in between them and the if structure)

Toli Cuturicu 17-Mar-11 8:33am

No question. Just statements.

3 solutions

Solution 1

Then what is your problem , you can get the grade easily, make your problem clear..

C#

private String GetGrade(int courseAverage)
        {
            string letterGrade = "";
            if (courseAverage >= 90)
                letterGrade = "A";
            else if (courseAverage > 80)
                letterGrade = "B";
            else if (courseAverage > 70)
                letterGrade = "C";
            else if (courseAverage > 60)
                letterGrade = "D";
            else
                letterGrade = "F";
            return letterGrade;
        }

Posted 16-Mar-11 18:56pm

GauravKP

Comments

Sergey Alexandrovich Kryukov 17-Mar-11 2:31am

Well, numeric literals (immediate constants, hard-coded) in the code, long "if" (could be longer), no abstraction. How to support it?

Using string type is very bad. "" should not be used, use string.Empty instead.
The function does not use "this", so should be static (the code will compile, but will not pass standard FxCop validation with error class "performance" -- performance mistake).

Will work but not passing.

Please see my Answer.
--SA

Solution 3

C#

const double homeworkWeight = 0.25;
        const double quizWeight = .35;
        const double finalExamWeight = .40;

        private String CalculateGrade(string studentName, int homework1, int homework2, int quiz1, int quiz2, int finalExam)
        {
            string letterGrade = "Incomplete";

            double homeworkContribution = 0;
            double quizContribution = 0;
            double finalExamContribution = 0;

            homeworkContribution = (homework1 + homework2) / 2 * homeworkWeight;
            quizContribution = (quiz1 + quiz2) / 2 * quizWeight;
            finalExamContribution = (finalExam) * finalExamWeight;
            double courseAverage = homeworkContribution + quizContribution + finalExamContribution;

            if (courseAverage >= 90)
                letterGrade = "A";
            else if (courseAverage > 80)
                letterGrade = "B";
            else if (courseAverage > 70)
                letterGrade = "C";
            else if (courseAverage > 60)
                letterGrade = "D";
            else
                letterGrade = "F";

            return studentName + "'s" + "\nCourse Average : " + courseAverage + "\nletterGrade : " + letterGrade;

        }

Posted 16-Mar-11 19:55pm

GauravKP

Comments

Sergey Alexandrovich Kryukov 17-Mar-11 2:32am

What's the difference? more code...
--SA

GauravKP 17-Mar-11 3:03am

How can you achieve this in less code lines ?

Sergey Alexandrovich Kryukov 17-Mar-11 3:25am

:-)
--SA

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2011-03-16T20:29:00

Solution 4

I don't like any of the Answers so far, not at all. Data should be separated from the code; code should not contain any immediate constants (hard-coded). It should be something like that:

C#

//data associated with symbols:
enum Grade { F = -1, D = 60, C = 70, B = 80, A = 90, }

//...

//code, no numeric literals:
static Grade GetGrade(double age) {
    for (Grade grade = Grade.A; grade > Grade.F; grade--)
        if (age > (int)grade)
            return grade;
    return Grade.F;
} //GetGrade

—SA

Posted 16-Mar-11 20:29pm

Sergey Alexandrovich Kryukov

Comments

GauravKP 17-Mar-11 3:08am

nice .. but it is only replacement of the elseif loop...
How can you say that enum Grade is not hardcoded ...

Sergey Alexandrovich Kryukov 17-Mar-11 3:10am

What do your think? Data separated from code.
You think it should be voted 1?
--SA

GauravKP 17-Mar-11 3:14am

Enum vs string, refer to comment, how is it related to performance. I like if you explain the concept...can be usefull for further work.

Sergey Alexandrovich Kryukov 17-Mar-11 3:18am

You did not understand. Performance is your mistake. Should say "static"
--SA

Sergey Alexandrovich Kryukov 17-Mar-11 3:18am

I did not here you. Did you vote 1?
--SA

GauravKP 17-Mar-11 3:28am

end this topic here , i think surveygirl13 got the solution ...
SA- the Enum implementation is better and can be integrated with the original code. quite helpfull for "comaprision "

Sergey Alexandrovich Kryukov 17-Mar-11 4:11am

Yep, thank you very much.
--SA

Olivier Levrey 17-Mar-11 8:47am

Cleaner code always means easier to maintain. A 5.

Sergey Alexandrovich Kryukov 17-Mar-11 13:08pm

It does. Thank you, Olivier.
--SA

Espen Harlinn 17-Mar-11 15:43pm

Nice effort, my 5

Sergey Alexandrovich Kryukov 17-Mar-11 16:04pm

Thank you, Espen.
--SA