Passing parameters in ADO.NET

Question

0.00/5 (No votes)

See more:

I know this is a very basic issue, but for some reason this is eluding me.. I keep getting the following error:

" Message=Procedure or function 'GetMembersOfAMemberType' expects parameter '@MemberType', which was not supplied."

I am able to execute the SProc in SQL Server.
Here is the code:

C#

public DataSet GetMembersByType(int memID)
        {
            DataSet ds = new DataSet();
            SqlConnection con = new SqlConnection(cnn);
            con.Open();
            SqlCommand cmd = new SqlCommand("GetMembersOfAMemberType", con);
            cmd.CommandType = CommandType.StoredProcedure;
            SqlParameter param = new SqlParameter();
            param.ParameterName = "@MemberType";
            param.Value = memID;
            cmd.Parameters.Add(param);
           
            try
            {
                SqlDataAdapter da = new SqlDataAdapter("GetMembersOfAMemberType", con);
                int i = cmd.ExecuteNonQuery(); // for debugging - I always get a -1 here, telling me that the code was not executed.
                da.Fill(ds, "MemTable");
                return ds;
            }
            catch
            {
                throw;
            }
            finally
            {
                con.Close();
            }
            
        }

Posted 2-Jul-12 14:28pm

Gymnast

Updated 2-Jul-12 15:08pm

JOAT-MON

v2

Add a Solution

Comments

barneyman 2-Jul-12 20:36pm

don't you have to give the sqlparameter a direction, input/output/retval?

3 solutions

Solution 1

You need to apply the type of the input parameter.
For e.g. param.DbType = DbType.String;.

Besides you should also mention the Direction i.e. Input or Output.

Posted 2-Jul-12 16:00pm

Abhinav S

Comments

Gymnast 3-Jul-12 14:24pm

Added this and still get the same error.

Solution 3

Maybe this will help you guys understand this better..

Source code:

XML

<asp:ObjectDataSource ID="odsGVMembers" runat="server"
         SelectMethod="getMemtype" TypeName="WCSMemberManagement.BAL">
         <SelectParameters>
             <asp:ControlParameter ControlID="ddlMemberType" DefaultValue="9" Name="MemID"
                 PropertyName="SelectedValue" Type="Int32" />
         </SelectParameters>
     </asp:ObjectDataSource>

Stored Procedure:

ALTER PROCEDURE [dbo].[GetMembersOfAMemberType]

@MemberType INT

AS
BEGIN

SET NOCOUNT ON;

SELECT

m.MemberID
, m.FirstName
, m.LastName
, m.MemberTypeID
, mt.MemberTypeDescription
FROM dbo.tblMember m
INNER JOIN dbo.lkpMembershipType mt
ON m.MemberTypeID = mt.MemberTypeID
WHERE m.MemberTypeID = @MemberType
END

Posted 3-Jul-12 10:21am

Gymnast

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

DamithSL · Accepted Answer · 2012-07-02T18:39:00

C#

// if you need to check nomber of records using ExecuteNonQuery
using (var con = new SqlConnection(connectionString))
{
    using (var cmd = con.CreateCommand())
    {
        cmd.CommandText = "GetMembersOfAMemberType";
        cmd.CommandType = CommandType.StoredProcedure;
        cmd.Parameters.AddWithValue("@MemberType", memID);
        con.Open();
        var ret = cmd.ExecuteNonQuery();
    }
}

// if you need to fill DataTabale using Stored Procedure
using (var con = new SqlConnection(connectionString))
{
    using (var cmd = con.CreateCommand())
    {
        cmd.CommandText = "GetMembersOfAMemberType";
        cmd.CommandType = CommandType.StoredProcedure;
        cmd.Parameters.AddWithValue("@MemberType", memID);
        using (var da = new SqlDataAdapter(cmd))
        {
            con.Open();
            DataSet ds = new DataSet();
            da.Fill(ds, "MemTable");
            return ds;
        }
    }
}