C# - Check for empty datareaders

Question

4.50/5 (2 votes)

See more:

, +

Hi guys,

I am running into issues with checking for empty datareaders. I am using Visual Studio 2012 with SQL Server Compact 4.0. The HasRows property is not supported in Compact, so I can't use that.

This is what I have right now.

C#

if ( ( (ac_key_number_dr.Read()) && (cc_key_number_dr.Read()) && (key_number_dr.Read()) && (hybrid_key_number_dr.Read()) && (transmission_key_number_dr.Read()) ) == false )
            {
                loadDefault();
            }

I am checking for all 5 of my datareaders as to whether or not they are empty.

My intended target is that if all 5 are empty to call this function "loadDefault()". Otherwise, if one of the readers has content, this if statement will be skipped.

I'm not getting any error message, but the output right now is that this if statement returns true and this function gets called no matter if all are empty or if one of the readers has content. What am I missing?

Thanks in advance!

Posted 23-Oct-12 8:31am

joshrduncan2012

Add a Solution

2 solutions

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Daxa Rughani · Answer 1 · 2012-10-23T09:31:00

Assuming Read() returns TRUE if Read() succeeds then you want change your logic as below.
If any Read() succeeds loadDefault() will not get called.

C#

if ( ( (ac_key_number_dr.Read()) || (cc_key_number_dr.Read()) || (key_number_dr.Read()) || (hybrid_key_number_dr.Read()) || (transmission_key_number_dr.Read()) ) == false )
            {
                loadDefault();
            }

OriginalGriff · Answer 2 · 2012-10-23T09:16:00

Your logic has a small flaw:
Read returns true if it has data, so

C#

a.Read() && b.Read()

is true if and only if a and b both have data.
Conversely,

C#

(a.Read() && b.Read()) == false

if true if either of a or b does not contain data, or if both do not
If you want your statement executed only when neither have data, then you want

C#

!a.Read() && !b.Read()

Which is true only when they are both empty.

So you want to code it as:

C#

if ( !ac_key_number_dr.Read() && !cc_key_number_dr.Read() && !key_number_dr.Read() && !hybrid_key_number_dr.Read() && !transmission_key_number_dr.Read())
            {
                loadDefault();
            }

C# - Check for empty datareaders

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0

C# - Check for empty datareaders

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0

Existing Members

...or Join us