Click here to Skip to main content
14,427,400 members
Rate this:
Please Sign up or sign in to vote.
See more:
I tried to insert the selected data from Datatable to Datagridview. However, it showed the error like NullReferenceException was unhandled. Could please anyone advise how to solve this error. my code is as following. Thank you.

DataTable LoadData = ConnectionStr.executsql("Select * from ช0210$ WHERE MS_INS_NAME = '" + Combo_CompName.Text + "'");

if (LoadData.Rows.Count > 0)
{
foreach (DataRow dr in LoadData.Rows)
{
dgv.Rows.Add(dr.ItemArray);
}
}

What I have tried:

I Tried to put if to check
if (LoadData.Rows.Count > 0)
Posted
Updated 14-Jan-20 20:51pm
Rate this:
Please Sign up or sign in to vote.

Solution 1

You need to check to see if LoadData is not null; because if it is then there will be neither a Rows property nor the Count property of rows.

You can either wrap the while thing in another if block or you can combine the null check with the Rows.Count check. Here are both choices; choose one
if (LoadData != null)
{
   if (LoadData.Rows.Count > 0)
   {
      foreach (DataRow dr in LoadData.Rows)
      {
         dgv.Rows.Add(dr.ItemArray);
      }
   }
}
/* =====< OR >===== */
if ((LoadData != null) && (LoadData.Rows.Count > 0))
{
   foreach (DataRow dr in LoadData.Rows)
   {
      dgv.Rows.Add(dr.ItemArray);
   }
}
   
Comments
yoecon 15-Jan-20 1:50am
   
Hi MadMyche,
Thank your for advise. It's work. The error is gone.
However, my work is not done and need further help.
I created ComboBox named Combo_CompName which filled with company name already.
What I want to do is to download data from datatable with condition only selected company name in ComboBox to be showm in gridview when Download button is clicked. I tried to create function which is following code and put it in Download button (click event) but it is not work. please kindly adivse.


public void loadshareholder()
{
string selected = CompName.GetItemText(this.Combo_CompName.SelectedItem);
DataTable LoadData = ConnectionStr.executsql("SELECT * FROM ช0210$ WHERE MS_INS_NAME = '" + selected + "'");

if ((LoadData != null) && (LoadData.Rows.Count > 0))
{
foreach (DataRow dr in LoadData.Rows)
{
dgv.Rows.Add(dr.ItemArray);
}
}
MadMyche 15-Jan-20 7:35am
   
Please post this as a separate question, as it is unrelated to the original problem.
I would also fix the SQL Injection vulnerability first
Rate this:
Please Sign up or sign in to vote.

Solution 2

Two things to add to what MadMyche has said:
1) This is one of the most common problems we get asked, and it's also the one we are least equipped to answer, but you are most equipped to answer yourself.

Let me just explain what the error means: You have tried to use a variable, property, or a method return value but it contains null - which means that there is no instance of a class in the variable.
It's a bit like a pocket: you have a pocket in your shirt, which you use to hold a pen. If you reach into the pocket and find there isn't a pen there, you can't sign your name on a piece of paper - and you will get very funny looks if you try! The empty pocket is giving you a null value (no pen here!) so you can't do anything that you would normally do once you retrieved your pen. Why is it empty? That's the question - it may be that you forgot to pick up your pen when you left the house this morning, or possibly you left the pen in the pocket of yesterdays shirt when you took it off last night.

We can't tell, because we weren't there, and even more importantly, we can't even see your shirt, much less what is in the pocket!

Back to computers, and you have done the same thing, somehow - and we can't see your code, much less run it and find out what contains null when it shouldn't.
But you can - and Visual Studio will help you here. Run your program in the debugger and when it fails, VS will show you the line it found the problem on. You can then start looking at the various parts of it to see what value is null and start looking back through your code to find out why. So put a breakpoint at the beginning of the method containing the error line, and run your program from the start again. This time, VS will stop before the error, and let you examine what is going on by stepping through the code looking at your values.

But we can't do that - we don't have your code, we don't know how to use it if we did have it, we don't have your data. So try it - and see how much information you can find out!

2) Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:
SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'
The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:
SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'
Which SQL sees as three separate commands:
SELECT * FROM MyTable WHERE StreetAddress = 'x';
A perfectly valid SELECT
DROP TABLE MyTable;
A perfectly valid "delete the table" command
--'
And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?
   

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)




CodeProject, 503-250 Ferrand Drive Toronto Ontario, M3C 3G8 Canada +1 416-849-8900 x 100