Click here to Skip to main content
15,112,662 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
// SAVE
 MemoryStream ms = new MemoryStream();
                M_PIC.Image.Save(ms, M_PIC.Image.RawFormat);
                byte[] byteImage = ms.ToArray();


// RETRIEVE 

int m_id = Convert.ToInt32(dataGridView1.CurrentRow.Cells["ID"].Value.ToString());
                DataTable tbl1 = DB.GetData("select * from [MEMBERSHIP] where [ID] = " + m_id);

                byte[] image = (byte[])tbl1.Rows[0]["M_IMG"];
                MemoryStream ms = new MemoryStream(image);

               p1.Image = Image.FromStream(ms);


What I have tried:

I USER THIS CODE TO SAVE ON DATABASE COLUMN (IMAGE) TYPE
BUT CANNOT VIEW IT ON PICTURE BOX FROM DATABASE
Posted
Updated 28-Feb-20 4:21am

1 solution

Probably, it's that your code is liable to SQL injection, and that affects what you have actually saved.

The code you show probably isn't vulnerable to SQL Injection because I suspect that m_id is not a string - but it's indicative that the rest of your code is.
Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'
The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'
Which SQL sees as three separate commands:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';
A perfectly valid SELECT
SQL
DROP TABLE MyTable;
A perfectly valid "delete the table" command
SQL
--'
And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?


And that has another effect: it wrecks your data when you try to save it, you don;t know that it;''s happened, and you get a "Parameter is not valid" error when you try to regenerate your images. See here: Why do I get a "Parameter is not valid." exception when I read an image from my database?[^]
   

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)




CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900