Click here to Skip to main content
15,998,003 members
Please Sign up or sign in to vote.
0.00/5 (No votes)
See more:
isFull, addContact, removeContact, and getContactList are not working

What I have tried:

Java
public class ContactList {
    private static int INITIAL_LENGTH = 3;
    private PersonalContact[] contacts;
    private int numContacts;

   
    public ContactList(){
    //TODO 3: implement this method.
      contacts = new PersonalContact[INITIAL_LENGTH];
      numContacts = 0;


    }
    
   /* 
    *  Returns true if the contact list contains no contacts, false otherwise.
    */
    public boolean isEmpty(){
    //TODO 4: implement this method.
      for(PersonalContact u: contacts){
     	    if(u != null){
      	   return false;
      	}
     }
      return true;
      
    }
   
   /* Adds the PersonalContact object to the next available location in the array.
    * Before adding, the list is checked to see if it is full by calling the isFull() method.
    * If the list is full, it must be expanded before the contact can be added. To do this,
    * the expandList method is called, then the contact is added. If the list is not full, the 
    * contact is added. The numContacts can serve as an index number of the next available cell.
    * After adding, numContacts is updated.
    * Note: the array may have fewer contacts (PersonalContact objects) than its length.
    */
    public void addContact(PersonalContact newContact){
    //TODO 7: implement this method.
      	if(isFull()){
	   expandList();
      }
      for (int z  = 0; z< contacts.length-1; z++){
          if(contacts[z] == null){
            contacts[z] = newContact;
		
      numContacts ++;

         }
       }
    }
   
   /* Removes a contact from the list if it is in the list. The name of 
    * the contact is used to find the contact. If a match to the name is found, 
    * the value at that index is overwritten by null. Then the compressList
    * function is called to re-order the list so all objects are next to each other,
    * starting at index 0.
    * This method returns true if a contact was removed, false otherwise. 
    * After removing, numContacts is updated.
    */
    public boolean removeContact(String targetName){
    //TODO 9: implement this method.
    for(PersonalContact x:contacts){
         if(x.getName() == targetName){
            x = null;
		 compressList();
 return true;
   }
 
 
      
  }
  return false;
 }
   
   /* 
    * Return a list that contains only the PersonalContact objects that have been added.
    * This list does not contain any NULL values.
    * If the list does not contain any contacts, this method returns a PersonalContact array 
    * with zero length.
    */
    public PersonalContact[] getContactList(){
    //TODO 10: implement this method.
    int nulls = 0; 
    for(PersonalContact u: contacts){
	  if(u == null){
	   nulls++;
	}
  }
    PersonalContact[] getContactLists = new PersonalContact[contacts.length - nulls];
    compressList();
    for(int i = 0; i < getContactLists.length - 1; i++){
	   getContactLists[i] = contacts[i];
	}
    

      return getContactLists;

    

  }
   
   /* 
    * Removes all items from the list, resulting in an empty list.
    * The capacity of the new list will revert to the INITIAL_LENGTH.
    * numContacts is reset to 0.
    */
    public void clearContactList(){
    //TODO 11: implement this method.
    PersonalContact[] newcontact = new PersonalContact [INITIAL_LENGTH];
    contacts = newcontact;
    numContacts = 0;
    }
    
    /****** Private, "helper" method section ******/
   
   /* 
    * This method returns true if all cells in the array contain a PersonalContact
    * object, false otherwise. 
    */
    private boolean isFull(){
    //TODO 5: implement this method.
      for(int i = 0; i <= contacts.length-1; i++){
      if(contacts[i] == null){
      return false;
      }

    }
      return true;
}   
   /* Creates a new contacts array that is double the size of the current array.
    * It then copies the contacts from the current array to the new array. 
    * Note that the new array will contain the contacts from the current array followed 
    * by NULL values.
    */
    private void expandList(){
    //TODO 6: implement this method.
    PersonalContact [] expandcontacts = new PersonalContact[contacts.length *2];
      for(int i = 0; i < expandcontacts.length-1; i++){
         if(contacts[i] != null){
            expandcontacts[i] = contacts[i];
            } 
            contacts = expandcontacts;
      }




    }
    
   /* 
    * This method ensures that all PersonalContact objects in the contact list
    * are stored contiguously: next to each other (with no null value between any 
    * of them) starting at index 0. 
    * The method traverses the list and if it finds a null value it moves all objects 
    * to maintain contiguous storage. Design an algorithm to do this and implement it.
    * 
    */
    private void compressList(){
    //TODO 8: implement this method.
    for(int i = 0; i < contacts.length-1; i++){
	  if(contacts[i] == null){
		for(int j = i; j < contacts.length-1; j++){
		    contacts[contacts.length-1] = null;
		    contacts[j] = contacts[j+1];
			}
		}
	}

  }

 }
Posted
Updated 6-Apr-20 6:28am
v3
Comments
Patrice T 5-Apr-20 22:42pm    
define 'not working'

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
C#
int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!

You should should also start to learn how to ask a question: "It's not working" is one of the most useless problem descriptions we get: it tells us absolutely nothing about the problem. We don't know if you get an error message, or the wrong data, or even that that code compiles successfully!
Remember that we can't see your screen, access your HDD, or read your mind - we only get exactly what you type to work with.
So tell us what happens when you run that code, what you expected to happen, how you checked what happened. Help us to help you!
 
Share this answer
 
Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

http://docs.oracle.com/javase/7/docs/technotes/tools/windows/jdb.html[^]
https://www.jetbrains.com/idea/help/debugging-your-first-java-application.html[^]

The debugger is here to only show you what your code is doing and your task is to compare with what it should do.
 
Share this answer
 

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900