I have an amount field being limited to only 3 digits. I get the message in the text field of "THIS IS a BAD VALUE"

Question

0.00/5 (No votes)

See more:

Not knowing enough about javascript I tried to make changes to the code but it didn't work. Can anyone please help identify for me where I can expand the field to accept amounts more than $123. I should be able to see $1234.00 or $12345.

What I have tried:

https://***REDACTED***/buynow.html is the page that is not working correctly.

Here is the code:

function totalamountdue() {
    var inputs = document.getElementsByTagName("INPUT");
    var runningTotal = 0;
    for (i = 0; i < inputs.length; i++) {
        if (inputs[i].id == "total") { inputs[i].value = runningTotal }
        if (inputs[i].id.indexOf("amount") == 0) {
            if (/^[1-9][0-9]{0,2}(,[0-9]{3})*(\.[0-9]{2})?$/.test(inputs[i].value)) {
                runningTotal += +inputs[i].value;
            } else {
                if (inputs[i].value == "THIS IS A BAD VALUE") { inputs[i].value = ""; }
                if (inputs[i].value) { inputs[i].value = "THIS IS A BAD VALUE"; }
            }
        }

    }
}

Posted 5-May-20 10:15am

esebagel

Updated 5-May-20 10:58am

phil.o

v3

Add a Solution

2 solutions

Solution 2

Quote:
I have an amount field being limited to only 3 digits.

If you study RegEx, you will see that input is not limited to 3 digits values, instead of 12345 , it accept 12.345 .

Just a few interesting links to help building and debugging RegEx.
Here is a link to RegEx documentation:
perlre - perldoc.perl.org[^]
Here is links to tools to help build RegEx and debug them:
.NET Regex Tester - Regex Storm[^]
Expresso Regular Expression Tool[^]
RegExr: Learn, Build, & Test RegEx[^]
Online regex tester and debugger: PHP, PCRE, Python, Golang and JavaScript[^]
This one show you the RegEx as a nice graph which is really helpful to understand what is doing a RegEx: Debuggex: Online visual regex tester. JavaScript, Python, and PCRE.[^]
This site also show the Regex in a nice graph but can't test what match the RegEx: Regexper[^]

Posted 5-May-20 10:59am

Patrice T

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

phil.o · Accepted Answer · 2020-05-05T10:25:00

Solution 1

You could try to replace

JavaScript

if (/^[1-9][0-9]{0,2}(,[0-9]{3})*(\.[0-9]{2})?$/.test(inputs[i].value))

with

JavaScript

if (!isNaN(parseFloat(inputs[i].value)) && isFinite(inputs[i].value))

Using a regular expression to validate a number is a terrible choice.

Posted 5-May-20 10:25am

phil.o

Comments

esebagel 5-May-20 16:36pm

You are amazing! Thank you so much! It worked flawlessly!

phil.o 5-May-20 16:42pm

You're welcome. Please mark your question as answered if it's the case.
And please, do not put links in your questions like you did; you could be flagged as spammer over this. I redacted the link to avoid that.