How to fix this issue.

Question

0.00/5 (No votes)

See more:

I want the selected values from the checkbox list called CheckBoxList1 to get saved into the database with the rest of the data mentioned but only the first checked item gets saved into the database. Please help.

protected void Button3_Click1(object sender, EventArgs e)
   {
       using (Stream fs = FileUpload1.PostedFile.InputStream)
       {
           using (BinaryReader br = new BinaryReader(fs))
           {

               byte[] bytes = br.ReadBytes((Int32)fs.Length);
               String strConnString = ConfigurationManager.ConnectionStrings["facultylogConnectionString"].ConnectionString;
               String strQuery = "Insert into Form (Name, Test_Number, Course_Name, Program, Exam_Month, Exam_Year, Course_Code, Semester, Paper, CLOs) VALUES(@Name, @Test_Number, @Course_Name, @Program, @Exam_Month, @Exam_Year, @Course_Code, @Semester, @Paper, @CLOs)";
               SqlConnection con = new SqlConnection(strConnString);
               SqlCommand cmd = new SqlCommand();
               cmd.CommandType = CommandType.Text;
               cmd.CommandText = strQuery;
               cmd.Connection = con;
               cmd.Parameters.AddWithValue("@Name", TextBox1.Text);
               cmd.Parameters.AddWithValue("@Test_Number", DropDownList3.SelectedValue);
               cmd.Parameters.AddWithValue("@Course_Name", DropDownList5.SelectedValue);
               cmd.Parameters.AddWithValue("@Program", DropDownList4.SelectedValue);
               cmd.Parameters.AddWithValue("@Exam_Month", TextBox5.Text);
               cmd.Parameters.AddWithValue("@Exam_Year", TextBox6.Text);
               cmd.Parameters.AddWithValue("@Course_Code", TextBox8.Text);
               cmd.Parameters.AddWithValue("@Semester", DropDownList2.SelectedValue);
               cmd.Parameters.AddWithValue("@Paper", bytes);


               for (int i = 0; i < CheckBoxList1.Items.Count - 1; i++)
               {
                   if (CheckBoxList1.Items[i].Selected)
                   {
                       string var = string.Empty;
                       var += CheckBoxList1.Items[i].Text.ToString() + ",";
                       cmd.Parameters.AddWithValue("@CLOs", var);

                   }

               }

               con.Open();
               cmd.ExecuteNonQuery();
               con.Close();

           } Label15.Visible = true;

       }
   }

What I have tried:

Tried the above code, only the first selected value is getting saved to the database.

Posted 20-Jun-20 12:42pm

candijen

Updated 20-Jun-20 19:07pm

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2020-06-20T19:08:00

Although Garth's solution will work, it's a poor DB design to store comma delimited values in a single column of a database.

It duplicates information, wastes storage space, promotes errors, and makes the data very hard to work with later.

For example, if the course "Basic" needs to be renamed to "Visual Basic" later on, you would need to change it in every row, and be extremely careful not to affect "Basic Maths" when you do it.
Worse, when you need to change a course for an individual - he swaps from "Visual Basic" to "C#" for example - it's horribly complicated to do in SQL because it's string handlking is marginal at best.
Instead, you should be setting up two tables:
Courses

ID    INT, IDENTITY
Name  NVARCHAR

And
CoursesTaken

ID        INT, IDENTITY
UserID    INT, Form.ID
CourseID  INT, foreign key to Courses.ID

Then SQL can do what it does best - process relationships between data - and you use JOIN when you want to retrieve the data.
It makes all processing easier, and only complicates the original INSERT operation a little.

Garth J Lancaster · Answer 2 · 2020-06-20T12:51:00

Solution 1

Think about what the 'string var = string.Empty;' and cmd.Parameters.AddWithValue... is doing INSIDE your loop ... maybe you meant

string var = string.Empty;
for (int i = 0; i < CheckBoxList1.Items.Count - 1; i++)
{
  if (CheckBoxList1.Items[i].Selected)
  {
    var += CheckBoxList1.Items[i].Text.ToString() + ",";
  }
}
cmd.Parameters.AddWithValue("@CLOs", var);

Posted 20-Jun-20 12:51pm

Garth J Lancaster

Updated 20-Jun-20 12:54pm

v3

Comments

candijen 21-Jun-20 5:02am

Hi, still only the first selection appears in the database along with a " , " and nothing else.