Click here to Skip to main content
14,574,673 members
Rate this:
Please Sign up or sign in to vote.
/* so the ques asked is :: Given a Binary Tree, convert it to Binary Search Tree in such a way that keeps the original structure of Binary Tree intact. */

below is my code please tell what is wrong i am unable to contemplate much now,,,,
first function is binarytoBst .... please.... i will be thankfull ... ps:: i am not riichhhhh....

void inorder(Node* root ,vector<int> &a )
    if(root == NULL) return;
    inorder(root->left, a);
void newinorder(Node* root,vector<int> &a,int index)
    if(root == NULL) return ;
    root->data = a[index]; index++;
Node *binaryTreeToBST (Node *root)
    if(root == NULL) return root;
    vector<int> a;
    int index = 0;
    index = 0;
    return root;

What I have tried:

Binary Tree to BST | Practice | GeeksforGeeks[^]
Updated 5 days ago

1 solution

Rate this:
Please Sign up or sign in to vote.

Solution 1

ps:: i am not riichhhhh....

Doesn't matter - help and advice here is free; we are all volunteers. There is no charge, or you would have had to give us credit card details when you signed up! :laugh:

But, your problem is one you can fix: Compiling does not mean your code is right!

Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
int Double(int value)
   return value * value;

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
prash3.1415259265 5 days ago

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CodeProject, 503-250 Ferrand Drive Toronto Ontario, M3C 3G8 Canada +1 416-849-8900 x 100