Click here to Skip to main content
14,883,453 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
how to get rating ajax id from a data list in code behind asp.net.The value of the rating should come from database.

What I have tried:

<asp:datalist id="viewjobdetails" clientidmode="Static" runat="server" datakeynames="Job_ID">
<itemtemplate>
<ajaxtoolkit:rating id="Ratinghk" runat="server" behaviorid="RatingBehavior1"
="" currentrating="0" maxrating="5" starcssclass="ratingStar" waitingstarcssclass="savedRatingStar" filledstarcssclass="filledRatingStar" emptystarcssclass="emptyRatingStar" style="float: left;">
<asp:label id="lblRatingStatus" runat="server">



Code Behind
if (!this.IsPostBack)
{
DataTable dt = this.GetData("SELECT ISNULL(AVG(Reviews), 0) AverageRating, COUNT(Reviews) RatingCount FROM tblHKHOReviews where HK_ID=" + Request.QueryString["ID"]);
Ratinghk.CurrentRating = Convert.ToInt32(dt.Rows[0]["AverageRating"]);
lblRatingStatus.Text = string.Format("{0} Users have rated. Average Rating {1}", dt.Rows[0]["RatingCount"], dt.Rows[0]["AverageRating"]);
}
Posted
Updated 11-Aug-20 22:55pm

1 solution

Don't do it like that! Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'
The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'
Which SQL sees as three separate commands:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';
A perfectly valid SELECT
SQL
DROP TABLE MyTable;
A perfectly valid "delete the table" command
SQL
--'
And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?

And in a web based system? Asking for trouble...
   

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

  Print Answers RSS
Top Experts
Last 24hrsThis month



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900