Click here to Skip to main content
14,635,966 members
Rate this:
Please Sign up or sign in to vote.
See more:
Hello!!!
I want to return a character from a function ,but this is never happened.
I give you the whole code(400+ lines).
See give_char() function and start_game function where I call give_char().
If you run this code ,when program goes to scanf() of give_char() ,the command never runs and program ends there.
When I run ONLY give_char() in main all is good.
I do not know what I have different/wrong (It seems all good to me)

Thanks...

What I have tried:

Code[^]
Posted
Updated 5 days ago
Comments
Patrice T 5 days ago
   
Try to find a way to paste your code in question.
Use Improve question to update your question.
Rate this:
Please Sign up or sign in to vote.

Solution 1

Just too many problems to enumerate in your code. You are using %s format controls to scanf and printf when dealing with single character variables; you should be using %c. You should also specify the length of the destination field when using scanf("%s", array_name). You also need to consume your line end characters where necessary in order to avoid reading them as actual data. I strongly suggest you go and read the MSDN documentation on scanf for full details on how to use it.
   
Rate this:
Please Sign up or sign in to vote.

Solution 2

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
   
Rate this:
Please Sign up or sign in to vote.

Solution 3

I do not understand.
I have these 2 lines of code in start_game() function:
char my_letter = give_char();
printf("%c" , my_letter);

and then I call start_game() in main() and doesn't works.

If I write these commands
char my_letter = give_char();
printf("%c" , my_letter);
in main(and not in start_game) it works.


char give_char()
{
    char character;
    printf("\nGive a character: ");
    //fgets(character , 50 , stdin);
    scanf("%c" , &character);
    return character;
}



it is for laughs and cries.I can't understand why this SIMPLE thing doesn't work.
I just can't.
Strangeness.
   
Comments
Nick_is_asking 5 days ago
   
I found it.
I had to write scanf(" %c" , &character);
with a space before %c.
I don't know why...

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)




CodeProject, 503-250 Ferrand Drive Toronto Ontario, M3C 3G8 Canada +1 416-849-8900 x 100