How to prepare parameterized query in oracle using in clause

Question

0.00/5 (No votes)

See more:

I am using the below query with In clause
strign courceids = comma seperated ids ex "123,456,567,678";
select * from student where studentID= stdId and courseid in ("+ courceids +")
Its working but i want to prevent the sql injection for this query
so could you please assist on this how to use for IN clause in oracle

What I have tried:

I have tried

OracleCommand oraCommand = new OracleCommand("select * from student where studentID= stdId and courseid in = :courceids ", con);
oraCommand.Parameters.Add(new OracleParameter("courceids ", courceids ));

Posted 16-Sep-20 8:54am

DGKumar

Updated 14-Feb-21 4:36am

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Gerry Schmitz · Answer 1 · 2020-09-16T19:39:00

Solution 1

Parameterized IN clauses with ADO.NET and LINQ[^]

Posted 16-Sep-20 19:39pm

Gerry Schmitz

Comments

DGKumar 17-Sep-20 4:34am

Hi Gerry Schmtiz,
we are using direct select commands with in clause (Oracle db ) but we dont have access for db modifications, just we are fetching data by using the select command
For that we need to pass in clause to db with cmd.parameters.

[no name] 17-Sep-20 11:15am

If you had checked the code, you would see it creates parms for each value for the in clause. In other words, brute force instead of some magic expression.

#2 says the same thing.

Richard Deeming · Answer 2 · 2020-09-17T00:47:00

You need to pass multiple parameters, one for each item in your list.

C#

using (var oraCommand = new OracleCommand(null, con))
{
    oraCommand.Parameters.AddWithValue("@studentID", studentID);
    
    var parameterNames = new List<string>(courseIDs.Count);
    for (int index = 0; index < courseIDs.Count; index++)
    {
        string name = "@courseId" + index;
        oraCommand.Parameters.AddWithValue(name, courseIDs[index]);
        parameterNames.Add(name);
    }
    
    oraCommand.CommandText = string.Format("SELECT ... FROM student WHERE studentID = @studentID And courseId In ({0})", string.Join(", ", parameterNames));
    
    ...
}

It might be easier to use Dapper:

C#

IEnumerable<Student> students = connection.Query<Student>("SELECT ... FROM student WHERE studentID = @studentID And courseId In (@courseIDs)", new { studentID = 42, courseIDs = new[] { 1, 2, 3 } });

GitHub - StackExchange/Dapper: Dapper - a simple object mapper for .Net[^]