Click here to Skip to main content
14,830,943 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
PHP
<?php

$servername = "localhost";
$username = "root";
$password = "";
$dbname = "dbname";


$conn = mysqli_connect($servername, $username, $password, $dbname);

$product_name = $_POST['product_name'];
$category_name = $_POST['category_name'];
$date = $_POST['date'];
$quantity = $_POST['quantity'];
$unit_price = $_POST['unit_price'];
$vendor_name = $_POST['vendor_name'];

$sql = "INSERT INTO purchases (product_name,category_name,date,quantity,unit_price,vendor_name) VALUES 
('$product_name','$category_name','$date','$quantity','$unit_price','$vendor_name');";
mysqli_query($conn,$sql);

header("location: ../purchases.php?submit=success");

?>


What I have tried:

When I click the submit button it shows the error above from lines 11 through to line 16 and then 22
Posted
Updated 31-Oct-20 9:06am
v3

Quote:
When I click the submit button it shows the error above from lines 11 through to line 16 and then 22

Unfortunately, we can't do much for you because problem is not in this code.
Problem only become visible in this code.
This code process data from an input form, it expect data in $_POST using spùe indexes named after input fields, problem is that those indexes do not exist.
The only thing to do is either inspect the contain of $_POST with debugger or print its contain with key/values pairs. And check code of input form.
PHP
$sql = "INSERT INTO purchases (product_name,category_name,date,quantity,unit_price,vendor_name) VALUES 
('$product_name','$category_name','$date','$quantity','$unit_price','$vendor_name');";

Not a solution to your question, but another problem you have.
Never build an SQL query by concatenating strings. Sooner or later, you will do it with user inputs, and this opens door to a vulnerability named "SQL injection", it is dangerous for your database and error prone.
A single quote in a name and your program crash. If a user input a name like "Brian O'Conner" can crash your app, it is an SQL injection vulnerability, and the crash is the least of the problems, a malicious user input and it is promoted to SQL commands with all credentials.
SQL injection - Wikipedia[^]
SQL Injection[^]
SQL Injection Attacks by Example[^]
PHP: SQL Injection - Manual[^]
How can I explain SQL injection without technical jargon? - Information Security Stack Exchange[^]
   
Check your HTML code: the chance are you have misspelled you indexes, or have no matching controls on your page. This explains it with simple sample code: PHP $_POST[^]

And as Patrice T has said: Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'
The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'
Which SQL sees as three separate commands:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';
A perfectly valid SELECT
SQL
DROP TABLE MyTable;
A perfectly valid "delete the table" command
SQL
--'
And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?
   

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)




CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900