Click here to Skip to main content
14,735,693 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
Is this programming correct or not
the problem
The group members name, average of prizes and the date in each file did not appear with me in the output 


where problem in me code
i dont know

This question is here and I want to solve it

The Question
Test your project using your group members names. At the end, we expect to have 3 text
files containing a group member’s name, average of prizes and the date in each file. This
should be done through invoking toFile(String fileName) method and the member’s name
should be passed to the method as a fileName

What I have tried:

package b11;
  
import java.io.File;
import java.io.FileOutputStream;
import java.io.IOException;
import java.util.Date;
import java.util.Scanner;

public class PlayerPrizes {
   
     String playerName;
     int playerId;
     double[] prizes;
     private static int numInstntitd = 0;

     public PlayerPrizes() {
      numInstntitd++;
}
  
     public double prizesAvg(double[] prize) {
         double total = 0;
         for (int i = 0; i < prize.length; i++)
             total = total + prizes[i];
             return total / prizes.length;
     }
      
     public void toFile(String fileName) throws IOException {

         File file = new File(fileName+".txt"); 
         FileOutputStream fos=new FileOutputStream(fileName);
         byte[] b = (this.toString()+" "+this.prizesAvg(this.prizes)+" on "+new Date()).getBytes();
             fos.write(b);
             fos.close();
     }
   
     public static int getPlayerPrizesCount() {
         return numInstntitd;
     }
       
     public String String() {
         return "The player " + playerName + " with id " + playerId + " has won " + prizes.length + " prizes";
     }
       
                     // ** main method **
     public static void main(String[] args) throws IOException {
         
         PlayerPrizes player = new PlayerPrizes();
         Scanner sc = new Scanner(System.in);
         System.out.println("Enter Player id");
         int id = sc.nextInt();
         System.out.println("Enter Player name");
         String name = sc.next();
         System.out.println("Enter 5 Player prizes");
         double[] prizes = new double[5];
         for (int i = 0; i < 5; i++)
              prizes[i] = sc.nextDouble();
              player.playerId = id;
              player.playerName = name;
              player.prizes = prizes;
              System.out.println(player.toString());
              player.toFile(player.playerName);
              System.out.println("num of times PlayerPrizes instantiated : " + getPlayerPrizesCount());
                 
        PlayerPrizes player2 = new PlayerPrizes();
             System.out.println("Enter Player id");
             id = sc.nextInt();
             System.out.println("Enter Player name");
             name = sc.next();
             System.out.println("Enter 5 Player prizes");
             prizes = new double[5];
             for (int i = 0; i < 5; i++)
                 prizes[i] = sc.nextDouble();
                 player2.playerId = id;
                 player2.playerName = name;
                 player2.prizes = prizes;
                 System.out.println(player2.toString());
                 player2.toFile(player2.playerName);
                 System.out.println("num of times PlayerPrizes instantiated : " + getPlayerPrizesCount());                                                                                                                                            
           PlayerPrizes player3 = new PlayerPrizes();
                System.out.println("Enter Player id");
                id = sc.nextInt();
                System.out.println("Enter Player name");
                name = sc.next();
                System.out.println("Enter 5 Player prizes");
                prizes = new double[5];
                for (int i = 0; i < 5; i++)
                        prizes[i] = sc.nextDouble();
                player2.playerId = id;
                player2.playerName = name;
                player2.prizes = prizes;
                System.out.println(player2.toString());
                player2.toFile(player2.playerName);
                System.out.println("num of times PlayerPrizes instantiated : " + getPlayerPrizesCount());
        }
}
Posted
Updated 23-Nov-20 11:03am
v8
Comments
Richard MacCutchan 16-Nov-20 9:44am
   
You need to provide more details of what the problem is, and where in your code it occurs.

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
   
Comments
JUma juman 16-Nov-20 10:49am
   
You may not understand me because I am an Arab and I do not know English well, but this is a project and I just want to solve it. I have written the codes and I do not know whether these codes are correct or not
OriginalGriff 16-Nov-20 11:08am
   
So test them, and run them through the debugger to find out why problems exist if you find they don;t do exactly what you expect.
That's part of your task: testign and fixing your code is a large part of development!
You should use a FileWriter (Java Platform SE 7 )[^] to output character data (i.e. Java String types), not a FileOutputStream as you have done.
   
Comments
JUma juman 16-Nov-20 11:13am
   
public void toFile(String fileName) throws IOException {

File file = new File(fileName+".txt");
FileWriter fos=new FileWriter(fileName);
byte[] b = (this.toString()+" "+this.prizesAvg(this.prizes)+" on "+new Date()).getBytes();
fos.write(b);
fos.close();


like this ?
Richard MacCutchan 16-Nov-20 11:54am
   
No, you need to write the data as character strings so they are readable. See OutputStreamWriter (Java Platform SE 7 )[^] for the method details.
Quote:
Is this programming correct or not

I guess your know the answer, it is "No".
Quote:
The group members name, average of prizes and the date in each file did not appear with me in the output

Quote:
where problem in me code i dont know

Since making correct code (at least superficially) is part of the programmer job, you need to learn how to check your code and debug it. And the sooner, the better, secondary effect, it improve your learning curve.

Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

jdb - The Java Debugger[^]
https://www.jetbrains.com/idea/help/debugging-your-first-java-application.html[^]

The debugger is here to only show you what your code is doing and your task is to compare with what it should do.
   

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

  Print Answers RSS
Top Experts
Last 24hrsThis month



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900