Click here to Skip to main content
14,770,630 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
/*coded by Roman R*/


    char P1_Name[20], P2_Name[20];
    char rock, paper, scissors;
    char P1Choice, P2Choice, Greaterchoice;

char determineChoices(char Greaterchoice) {
    if (P1Choice==rock && P2Choice==scissors || P1Choice==scissors && P2Choice==paper || P1Choice==paper && P2Choice==rock) {
        Greaterchoice = 0;
         
    } else if (P1Choice==rock && P2Choice==paper || P1Choice==paper && P2Choice==scissors || P1Choice==scissors && P2Choice==rock) {
        Greaterchoice = 1;
    } else {
    printf("Player2 Enter your name.:");
            scanf ("%s", P2_Name);
    printf("%s%s, Enter rock paper or scissors:\n", P1_Name, P2_Name);
            scanf("%c%c", &P1Choice, &P2Choice);
        return char;
               
int main() {
        if (Greaterchoice = 0) {
        printf("%s", Won, P1_Name);
        }
       
        else if (Greaterchoice = 1) {
        printf("%s", won, P2_Name)
        }
       
        else {
        printf("It,s a draw");
}       }
    return 0;
}

int main()
{
    printf("Hello World");

    return 0;
}
        Greaterchoice = 3;
    }
        return char;
   
    printf("Player1 Enter your name.:")      
            scanf ("%s", P1_Name


What I have tried:

Hello I am doing my best to create see title but I am not sure what is wrong with my program.

So basically 2 players enter there names and it is stored in a string and one player takes a turn selecting rock paper or scissors.

The program will then return a printf message indicating which player won. Here is the code so far.

Code
Posted
Updated 21-Nov-20 11:12am

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
   
I see several problems. You have a global variable called Greaterchoice and the argument passed to determineChoices has the same name. That is a bad thing to do. Pick one and change the name of the other. Personally, I never give a local variable a capitalized name so I would change the argument's name to choice or something similar. You really don't need to have that as global variable anyway. That should be local to the function and NOT passed into it because it is acquired within the function itself.

The second problem is you have three global variables called rock, paper, and scissors who never have a value assigned to them and are used in comparison logic. In my opinion, those should be static variables in the determineChoices function and assigned appropriate values.

The third problem is you never call the determineChoices function. You need to call it from main for anything to happen.

A fourth thing - the function should return zero or one to tell you who won and you should print the winner's name according to the returned value.

Lastly, the bottom part of that code is just a mess. There should one and only one main function and it needs to do the things I mentioned above.

I am not going to write this code for you. YOU need to do it so you understand what you are doing.
   
v3
Comments
Member 14999245 23-Nov-20 10:56am
   
Hello Rick I want to thank you for your input as I take getting help seriously since I am as beginner as one can get as a programmer. Here is my updated code. I am hoping it is a bit better than what I submitted previously. Thank you!

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
/*coded by Roman R*/

char rock, paper, scissors;
char P1Choice, P2Choice, Greaterchoice;

char Greaterchoice() {
if ((P1Choice==rock && P2Choice==scissors || P1Choice == scissors && P2Choice==paper || P1Choice == paper && P2Choice == rock)) {
Greaterchoice = 0;
} else if ((P1Choice==rock && P2Choice==paper || P1Choice==paper && P2Choice==scissors || P1Choice==scissors && P2Choice==rock)) {
Greaterchoice = 1;
} else {
Greaterchoice = 3;
}
}

char P1_Name[20], P2_Name[20];
printf("Player 1 Enter your name.:\n");
scanf ("%s", P1_Name);
printf("Player 2 Enter your name.:\n");
scanf ("%s", P2_Name);

printf("%s%s, Enter rock paper or scissors:\n", P1_Name, P2_Name);
scanf("%c%c", &P1Choice, &P2Choice);
return char;

int main(void)
if (Greaterchoice = 0) {
printf("%s", Won, P1_Name);
} else if (Greaterchoice = 1) {
printf("%s", Won, P2_Name)
} else {
printf("It,s a draw");
}
return 0;
}

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)




CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900