Click here to Skip to main content
15,032,967 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
Im using raycast to create a shooting function in my game and when i click to fire a NullReferenceException comes up, Here is my following code:


void Update()
   {
       if (Input.GetButton("Fire1"))
       {
           Shoot();
       }
   }

   void Shoot()
   {

       Ray ray = mainCam.ScreenPointToRay(new Vector3(0.5f,0.5f,0));
       RaycastHit hit;
       if (Physics.Raycast(ray, out hit, database.weapons[id].range))
       {
           if(hit.transform.tag == "Enemy")
           Debug.Log(hit.transform.name);
           CharacterStats enemyStats = hit.transform.GetComponent<CharacterStats>();
           enemyStats.TakeDamage(database.weapons[id].damage);
           Debug.Log(database.weapons[id].damage);

       }
   }


Specifically on the line where it says " Ray ray = mainCam.ScreenPointToRay(new Vector3(0.5f,0.5f,0));" is where i get the error. mainCam just refers to a variable that is assigned the value of Camera.main. What causes this problem?

What I have tried:

i tried debugging but couldnt figure it out
Posted
Updated 9-Apr-21 21:33pm
Comments
Richard MacCutchan 10-Apr-21 5:43am
   
Using the debugger, check the value of mainCam at the point of the error.

1 solution

This is one of the most common problems we get asked, and it's also the one we are least equipped to answer, but you are most equipped to answer yourself.

Let me just explain what the error means: You have tried to use a variable, property, or a method return value but it contains null - which means that there is no instance of a class in the variable.
It's a bit like a pocket: you have a pocket in your shirt, which you use to hold a pen. If you reach into the pocket and find there isn't a pen there, you can't sign your name on a piece of paper - and you will get very funny looks if you try! The empty pocket is giving you a null value (no pen here!) so you can't do anything that you would normally do once you retrieved your pen. Why is it empty? That's the question - it may be that you forgot to pick up your pen when you left the house this morning, or possibly you left the pen in the pocket of yesterday's shirt when you took it off last night.

We can't tell, because we weren't there, and even more importantly, we can't even see your shirt, much less what is in the pocket!

Back to computers, and you have done the same thing, somehow - and we can't see your code, much less run it and find out what contains null when it shouldn't.
But you can - and Visual Studio will help you here. Run your program in the debugger and when it fails, VS will show you the line it found the problem on. You can then start looking at the various parts of it to see what value is null and start looking back through your code to find out why. So put a breakpoint at the beginning of the method containing the error line, and run your program from the start again. This time, VS will stop before the error, and let you examine what is going on by stepping through the code looking at your values.

But we can't do that - we don't have your code, we don't know how to use it if we did have it, we don't have your data. So try it - and see how much information you can find out!
   

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)




CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900