Sql stored procedure inserts instead of update

Question

1.00/5 (1 vote)

See more:

I have a table called CustomerAnalysis which has one record with ID 1, My stored proc does not go into the if since the record exist. What am I doing wrong

CusomerAnalysis:
| ID| 
|:--|
| 1 |

What I have tried:

CREATE PROC proc_Insert
(
    @CustomerID INT = 1
)
AS
BEGIN
    IF EXISTS(SELECT ID FROM Client WHERE Client.ID = @CustomerID)

BEGIN
    UPDATE Client
    SET Client.ID = 2
    WHERE Client.ID = @CustomerID
END

ELSE
BEGIN
     INSERT INTO Client(ID) VALUES(@CustomerID)
END
END

Posted 15-Apr-21 23:34pm

Zainalds

Updated 16-Apr-21 1:06am

v4

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Answer 1 · 2021-04-16T00:26:00

Solution 1

You have a table with a single column called ID.

That table contains a single record with ID = 1.

You are looking for a record in that table where the non-existent column CustomerID is equal to 1.

The only correct result is an error telling you that the column CustomerID does not exist.

Posted 16-Apr-21 0:26am

Richard Deeming

Comments

Zainalds 16-Apr-21 7:05am

CREATE PROC proc_Insert
(
@CustomerID INT = 1
)
AS
BEGIN
IF EXISTS(SELECT ID FROM Client WHERE Client.ID = @CustomerID)

BEGIN
UPDATE Client
SET Client.ID = 2
WHERE Client.ID = @CustomerID
END

ELSE
BEGIN
INSERT INTO Client(ID) VALUES(@CustomerID)
END
END

Richard Deeming 16-Apr-21 7:07am

That's the same code you posted in your question. You are still referencing a column which does not exist according to your question.

Zainalds 16-Apr-21 7:09am

I have updated the question, thank you.

Richard Deeming 16-Apr-21 7:16am

You need to debug your code. Remember, the record won't exist after you've run the procedure once - the ID will now be 2 instead of 1.