How can I fix it for my code?

Question

1.00/5 (1 vote)

See more:

C#

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Timers;
using System.Windows.Forms;

namespace Vize_Deneme
{
    public partial class Form1 : Form
    {
        private int sayac; 
        public Form1()
        {
            InitializeComponent();
        }

        
        private void timer1_Elapsed(object sender, ElapsedEventArgs e)
        {
            label1.Text = DateTime.Now.ToLongDateString();
        }

        private void button1_Click(object sender, EventArgs e)
        {
            
            double x = Convert.ToDouble(textBox1.Text);
            double y = Math.Pow(x, 3);
            double z = Math.Pow(x,2);
            label3.Text = Math.Log(y + (z*2) +5,2).ToString();
        }

        private void timer2_Tick(object sender, ElapsedEventArgs e)
        {
           
            sayac++;
            if (sayac % 2 == 0) ;
            {
                Random rnd1 = new Random();
                int rndSayi1 = rnd1.Next(0, 5);
                label4.Text = rndSayi1.ToString();
                
                Random rnd2 = new Random();
                int rndSayi2 = rnd2.Next(0, 5);
                label5.Text = rndSayi2.ToString();
            }
        }

        private void Form1_Load(object sender, EventArgs e)
        {
            timer2.Enabled = true;
        }
    }
}

What I have tried:

While a random number should come, there is no random number at the moment

https://ibb.co/C0fCKJ0
https://ibb.co/4N7L8d8

Posted 26-Apr-21 10:15am

enes dogrul

Updated 28-Apr-21 0:26am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Accepted Answer · 2021-04-26T10:50:00

Why are you creating new Random objects every time you need a random number? Don't do that. You create a single Random object at the class level, then you can use it where you need a random number throughout the class.

C#

public partial class Form1 : Form
    {
        private Random RNG = new Random();
        private int sayac; 

        public Form1()
        {
            InitializeComponent();
        }
        
        private void timer1_Elapsed(object sender, ElapsedEventArgs e)
        {
            label1.Text = DateTime.Now.ToLongDateString();
        }

        private void button1_Click(object sender, EventArgs e)
        {
            
            double x = Convert.ToDouble(textBox1.Text);
            double y = Math.Pow(x, 3);
            double z = Math.Pow(x,2);
            label3.Text = Math.Log(y + (z*2) +5,2).ToString();
        }

        private void timer2_Tick(object sender, ElapsedEventArgs e)
        {
           
            sayac++;
            if (sayac % 2 == 0) ;
            {
                int rndSayi1 = RNG.Next(0, 5);
                label4.Text = rndSayi1.ToString();
                
                int rndSayi2 = RNG.Next(0, 5);
                label5.Text = rndSayi2.ToString();
            }
        }

        private void Form1_Load(object sender, EventArgs e)
        {
            timer2.Enabled = true;
        }
    }