Click here to Skip to main content
15,067,335 members
Please Sign up or sign in to vote.
0.00/5 (No votes)
See more:
i have written a code in c to search for duplicate words in a string, It just appends every word in a string to a 2d string array, but it is returning 0 for the numbers of rows and duplicate strings, what is the problem with the code?

What I have tried:

#include <stdio.h>
#include <string.h>

int main()
{
    char str[50] = "C code find duplicate string" ;
    char str2d[10][50];

    int count = 0;
      
    int row = 0,column = 0;
    for (int i = 0; str[i] != '\0'; i++)
    {
        if (str[i] != '\0' || str[i] != ' ')
        {
            str2d[row][column] = str[i];
            column += 1;
        }
        else
        {
            str2d[row][column] = '\0';
            row += 1;
            column = 0;
        }
    }
    for (int x = 0; x <= row; x++)
    {
        for (int y = x+1; y <= row; y++)
        {
            if(strcmp(str2d[x], str2d[y]) == 0 && (strcmp(str2d[y],"0") != 0))
            {
                count += 1;
            }              
        }   
    }
    printf("%i %i",row,count);            
    
   
    return 0;   
}
Posted
Updated 21-May-21 21:56pm
v3

Quote:
what is the problem with the code?
I think you are going about it the wrong way. It would be much simpler just to tokenize the string and save the pointer to each token in a 1-dimensional array. You can then iterate the elements of the array comparing each word with all the others. Each time you find a match you just need to print the word number.
   
Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
C#
int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
   
Replace
if (str[i] != '\0' || str[i] != ' ')

with:
if (str[i] != '\0' && str[i] != ' ')
   

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)




CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900