Three things:
1) Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.
When you concatenate strings, you cause problems because SQL receives commands like:
SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'
The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:
SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;
Which SQL sees as three separate commands:
SELECT * FROM MyTable WHERE StreetAddress = 'x';
A perfectly valid SELECT
DROP TABLE MyTable;
A perfectly valid "delete the table" command
And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.
So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?
2) Don't share a connection - create it inside a
Using block when you need it so the system can automatically close and dispose it: teh same applies to the Command object - that can go in a
Using block as well.
3) Why are you executing the same command twice? Once with ExecuteReader to get the data, and once to cause an error because the reader is already open?
Mind you, even if you fix all of that throughout your app, it's a waste of time, because you discard the DataReader and the data it collects for you immediately after the it's started when the method ends and the only reference to it is invalidated ...
Submit an article or tip