Click here to Skip to main content
14,930,017 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
Imports System.Data
Imports System.Data.OleDb
Public Class Editmember
Dim dr As OleDbDataReader
Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click

Dim dr As OleDbDataReader
If Len(Trim(ComboBox6.Text)) = 0 Then
MessageBox.Show("Please Enter Members Registration ID ", "input Error", MessageBoxButtons.OK, MessageBoxIcon.Error)
Exit Sub
End If

cmd.CommandText = "select * From [NewMember] where [ID] ='" & Convert.ToInt32(ComboBox6.Text) & "'"
cmd.Connection = con

dr = cmd.ExecuteReader()
If dr.Read() Then
TextBox9.Text = ("[First name]")
TextBox2.Text = ("[Last name]")
DateTimePicker1.Text = ("[DOB]")
TextBox3.Text = ("[Mobile]")
ComboBox1.Text = ("[Gender]")
TextBox4.Text = ("[Email]")
TextBox5.Text = ("[Occupation]")
TextBox6.Text = ("[Address]")
ComboBox2.Text = ("[Membership]")
TextBox7.Text = ("[Amount]")
ComboBox3.Text = ("[AmtStatus]")
TextBox8.Text = ("[PendingAmt]")

DateTimePicker2.Value = ("[StartDate]")

DateTimePicker3.Value = ("[EndDate]")
ComboBox4.Text = ("[TrainerName]")
ComboBox5.Text = ("[Facility]")
MessageBox.Show("Record not found")
End If

Catch ex As Exception



End Try
End Sub

When i press the search button it displays output data type mismatch in criteria expression ?

What I have tried:

Tried changing the values and display options
Updated 10-Jun-21 5:33am

1 solution

Couple of things:
1) Never use Convert methods for user input: if they mistype - and they will, often - the Convert methods crash your app or (in your case) emit a pretty useless error message directly to the user.
Instead, use int.TryParse[^] and it's related method, and do "proper" error reporting so he knows what is happening.

2) Do yourself a favour, and stop using Visual Studio default names for everything - you may remember that "TextBox9" is the users first name today, but when you have to modify it in three weeks time, will you then? Use descriptive names - "tbFirstName" for example - and your code becomes easier to read, more self documenting, easier to maintain - and surprisingly quicker to code because Intellisense can get to to "tbFirstName" in three keystrokes, where "TextBox9" takes thinking about and 8 keystrokes...

3) Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:
SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'
The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:
SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'
Which SQL sees as three separate commands:
SELECT * FROM MyTable WHERE StreetAddress = 'x';
A perfectly valid SELECT
A perfectly valid "delete the table" command
And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?

Fix that throughout your app, and the problem you have noticed will go away at the same time.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900