Click here to Skip to main content
15,031,725 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
Hi Below is my master mind game python code, now I have a problem that example: when the answer is "RGRG" and I enter the alphabet "GRRG" by right the output for Correct colour and correct place should be = 2 and Correct colour and wrong place should be = 2. but now the output is wrong and it shows that colour and correct place = 2 but Correct colour and wrong place = 0. So if anybody know what part of my code is wrong?

What I have tried:

Python
import random
from random import choice

print("Welcome to Chee Fung Mastermind Games")
opening = input("Hi Do you need instruction or starightly enter into the game. [I/G]\n")
if opening == "I" or opening == "i" :
        print("Computer will automatically generate four colour from list.")
        print("Player must guess 4 colours numbers correct from the list to win the game.")
        print("You have 10 times chances to atempt the game.")
        print("There will be 5 colours in the below list.")
        print("(R)Red, (G)Green, (B)Blue, (P)Purple, (O)Orange")
        print("Player no need to enter the whole word, just need to enter the first alphabetical of the colours.")
        print("Example: for Red colour you just need to enter 'r' or 'R'.")
else:
        print("Let's start the game.")
prev_curt_color = 0
colors = ["R", "G", "B", "Y", "W", "P"]
attempts = 0
game = True

# computer randomly picks four-color code
color_code = []
for i in range(4):
        color_code.append(choice(colors))
print (color_code)


# player guesses the number
while game:
        correct_color = 0
        guessed_color = 0
        player_guess = input("Please enter the four colour:").upper()
        attempts += 1
        # checking if player's input is correct
        if len(player_guess) != len(color_code):
                print ("\nThe color code has exactly four colors. please try again!")
                attempts -= 1
                continue
        for i in range(4):
                if player_guess[i] not in colors:
                        print ("\nLook up what colors you can use in this game.")
                        attempts -= 1
                        break
        # comparison between player's input and secret code and player_guess[i] in color_code
        if correct_color != 4:
                for i in range(4):
                        if player_guess[i] == color_code[i]:
                                correct_color += 1
                        elif player_guess[i] != color_code[i] and player_guess[i] in color_code and correct_color > prev_curt_color:
                                guessed_color += 1
                        prev_curt_color = correct_color
                print("Correct colour and correct place: ", correct_color)
                print("Correct colour and wrong place: ", guessed_color)

        if correct_color == 4:
                if attempts == 1:
                        print ("Wow! You guessed at the first attempt!")
                else:
                        print ("Well done... You needed " + str(attempts) + " attempts to guess.")
                game = False

        if attempts >= 1 and attempts <10 and correct_color != 4:
                print("The attempt time " + str(attempts))
                print("Next attempt: ")
        elif attempts >= 10:
                print ("You didn't guess! The secret color code was: " + str(color_code))
                game = False

        # play or not to play
        while game == False:
                finish_game = input("\nDo you want to play again (Y/N)?").upper()
                attempts = 0
                if finish_game =="N":
                        print ("Thanks for the game! Bye, bye!")
                        break
                elif finish_game == "Y":
                        game = True
                        print ("So, let's play again... Guess the secret code: ")
Posted
Updated 8-Jul-21 23:38pm
v5
Comments
Richard MacCutchan 9-Jul-21 5:57am
   
Make a copy of the list of colours to be checked
Using the list of guesses:
For each one that matches the list to be checked:
remove it from both lists, and add one to the correct count
For each guess that remains:
if it matches any of the remaining colours:
remove it from both lists, and add one to the other count.
Chiew Chee Fung 9-Jul-21 5:58am
   
Hi can I know how does the code write , cause i have no idea haha
Richard MacCutchan 9-Jul-21 6:14am
   
I have given you the logic, it is your job to convert that to code. If you never try you will never learn (or succeed).

Getting your code to run at all does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
C#
int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
   
Quote:
what part of my code is wrong?

Python
correct_color = 0 # here you set correct_color to 0
...
if correct_color != 4: # and here you test it against 4, but you done nothing since 0
        for i in range(4):
                if player_guess[i] == color_code[i]:
                        correct_color += 1
                elif player_guess[i] != color_code[i] and player_guess[i] in color_code and correct_color > prev_curt_color:
                        guessed_color += 1
                prev_curt_color = correct_color
        print("Correct colour and correct place: ", correct_color)
        print("Correct colour and wrong place: ", guessed_color)

Your logic for guessed_color is just wrong, I don't understand how you try to get the count.
Advice: define a function that get the code to guess and user input and it compute number of correct colors and number of colors in wrong place.
The reason is that you can feed it with any arbitrary codes you choose.
Then create a list of codes for testing purpose.

Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

27.3. pdb — The Python Debugger — Python 3.6.1 documentation[^]
Debugging in Python | Python Conquers The Universe[^]
pdb – Interactive Debugger - Python Module of the Week[^]

The debugger is here to only show you what your code is doing and your task is to compare with what it should do.
   

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)




CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900