Define or not to define ....

Question

0.00/5 (No votes)

See more:

I am "rewriting" a piece of C code to C++ class which has few hardware #defines.

They are related to the class - so where do these #defines belong - header / source / elsewhere ?

What I have tried:

For now I am leaving it alone - sort of "global "... not very clean...

Posted 19-Sep-21 15:25pm

Member 14968771

Updated 19-Sep-21 20:25pm

Add a Solution

2 solutions

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Rick York · Answer 1 · 2021-09-19T20:25:00

Solution 2

I agree with Joe Woodbury on this. I will add that I would try to use a class with accessor methods and isolate as much knowledge of the specifics of that hardware as possible into that class. Usually that means only the source code for the class needs to know the values you are defining.

I also try to avoid behavioral definitions and rely on logic to handle variations in behavior. I really, REALLY dislike ifdefs because usually not all code paths get compiled all the time.

Posted 19-Sep-21 20:25pm

Rick York

Comments

Member 14968771 20-Sep-21 11:47am

The original code was written for at least two different hardware...
I am really not interested to write for something I will not use , but these specific #define(s) are already (scattered) in the code. I guess I'll put them in class header.

Rick York 20-Sep-21 18:16pm

If at all possible, I would try to avoid that because it exposes higher level code to details it probably does not need to know.

FWIW, I am in the automation business and I have been making interfaces to hardware for decades and I have found it enhances the usability and reusability of an interface when as few details as possible are known.

Joe Woodbury · Answer 2 · 2021-09-19T16:42:00

Solution 1

My preference is that if the type is known, use a constexpr with as narrow a scope as possible. In the rare circumstance that the value covers multiple types, I use a define.

Posted 19-Sep-21 16:42pm

Joe Woodbury

Define or not to define ....

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0

Define or not to define ....

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0

Existing Members

...or Join us