Click here to Skip to main content
15,498,398 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
I am trying to have this run questions using a loop. Not sure if I started this correctly.
Python
print('Hello, welcome to Farmvert. A great place to convert your loads.')

answer = 'Y' or 'y'
counter = 0

miles=float(input('How many miles would you like to convert?'))
if miles < 0:
    counter +=1
    print('Negative numbers can not be converted.')
else:
    counter = 0
    going_back == 4
    while counter <3:
        gallons=float(input('How many gallons would you like to convert?'))
        if gallons < 0:
            counter +=1
            print('Negative numbers can not be converted.')
        else:
            counter = 0
            going_back == 4
            while counter <3 and going_back == 4:
                pounds=float(input('How many pounds would you like to convert?:'))
                if pounds < 0:
                    counter +=1
                    print('Negative numbers can not be converted.')
                else:
                    counter = 0
                    going_back = 4
                    while counter <3 and going_back ==4:
                        inches=float(input('How many inches would you like to convert?:'))
                        if inches < 0:
                            counter +=1
                            print('Negative numbers can not be converted.')
                        else:
                            counter = 0
                            going_back = 4
                            while counter <3 and going_back ==4:
                                temp=float(input('What degree in fahrenheit do you want to convert to celsius?:'))
                                if temp > 1000:
                                    counter +=1
                                    print('More than 1000 degrees can not be converted.')
                                else:
                                    km=miles*1.6
                                    liters=gallons*3.9
                                    kg=pounds*0.45
                                    cm=inches*2.54
                                    celsius=(temp-32) * 5/9
                                    print('Calculating....')
                                    print(miles,'Miles equal to',format(km,'2f'),'kilometers')
                                    print(gallons,'Gallons equal to',format(liters,'2f'),'liters')
                                    print(pounds,'Pounds equal to',format(kg,'2f'),'kilograms')
                                    print(inches,'Inches equal to',format(cm,'2f'),'centimeters')
                                    print(temp,'Degrees in Fahrenheit',format(celsius,'2f'),'C')
                                    answer =input('Would you like to convert again?(Y/N)')
                                    if answer == 'Y' or answer == 'y':
                                        counter = 0
                                        going_back = 0
                                    else:
                                        counter = 3


What I have tried:

I tried without answer, without counter, with answer and no counter.
Posted
Updated 11-Oct-21 23:17pm
v2
Comments
Wendelius 11-Oct-21 22:01pm    
Please use the "Improve question" link and edit the code to be inside a pre tag (code block). This ensures that the indentation is shown correctly.
Patrice T 12-Oct-21 4:12am    
What is supposed to do your code ?

Getting your code to run does not mean it is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
C#
int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
If you don't know how to use the debugger, start here: pdb — The Python Debugger — Python 3.10.0 documentation[^]

This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!

And even if we wanted to fix your code for you - which wouldn't help you in the long run - we have no idea what the code is supposed to do, which is fundamental to fixing it! :laugh:
 
Share this answer
 
Writing all the code inline like that just makes it more difficult to find any errors. You should break out the common parts and create functions to handle them. for example, you have a number of parts that display a message and accept a number, which could be:
Python
def getvalue(message, limit = 0):
    value = 0
    for i in range(3): # allow 3 attempts
        value = float(input(message))
        if value < 0:
            print("value must be greater than 0")
            continue
        elif limit > 0 and value > limit:
            print("value must be less than", limit)
            continue
        else:
            break # a valid number
    return value

You can then call it from the main code:
Python
miles = getvalue("How many miles to convert?")
# or
temp = getvalue('What degree in fahrenheit do you want to convert to celsius?', 1000)
 
Share this answer
 
v2

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900