Click here to Skip to main content
15,312,319 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
Hey Guys I have a problem I am trying to fetch area to my table but is is displaying just one row even if I have 4 with condition that I set

What I have tried:

here is my mysql
 <?php
$findmessage = mysqli_query($dbc, "SELECT * FROM privatemessages WHERE to_id= '$username'");
if($res = mysqli_fetch_array($findmessage))
{
$msgid = $res['id']; 
$from = $res['from_id']; 
$subject = $res['subject'];   
$senton = $res['time_sent'];  
$read = $res['opened']; 
}
?> 

here is my table
<table cellpadding="0" cellspacing="0" border="0">
      <thead>
        <tr>
          <th>FROM:</th>
		     
          <th>Subject</th>
          <th>Sent on</th>
          <th>Read</th>
         
        </tr>
      </thead>
	<?php 
 

    	
		echo "<tr>";
		echo "<td>".$from."</td>";
  	echo "<td>".$subject."</td>";
		echo "<td>".$senton."</td>";
    echo "<td>".$read."</td>";	
    echo "<tr>";
        
	
	?>
	</table>


I even tried like this
<?php


while($res = mysqli_fetch_array($findmessage)) {
    echo "<tr>";
    echo "<td>".$res['from_id']."</td>";
    echo "<td>".$res['subject']."</td>";
    echo "<td>".$res['time_sent']."</td>";
echo "<td>".$res['opened']."</td>";
echo "<td>";

}
?>
Posted
Updated 21-Jan-22 3:35am
v4

1 solution

Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'
The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'
Which SQL sees as three separate commands:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';
A perfectly valid SELECT
SQL
DROP TABLE MyTable;
A perfectly valid "delete the table" command
SQL
--'
And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?
   
Comments
Member 13084733 19-Jan-22 6:14am
   
yes I do and this is just a test run because it was not working I asked you guys why it is not working

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900