Click here to Skip to main content
15,441,280 members
Please Sign up or sign in to vote.
0.00/5 (No votes)
See more:
Hey Guys I have A issue with one piece of code and I can't figure it out

this is the error
Notice: Undefined index: fullName  on line 25

I am using the script to call this function if I am getting this error script is working right?
line 25 is this
<a href="javascript:void(0)" class="gsearch" style="color:#333;text-decoration:none;">'.$row['fullName'].'</a>


What I have tried:

here is my PHP
<?php
require_once("../dataconfig.php");
if(isset($_POST['query']))
{
 $query = "
 SELECT DISTINCT fullName FROM customer 
 WHERE fullName LIKE '%".trim($_POST["query"])."%'
 ";

 $statement = $dbc->prepare($query);

 $statement->execute();

 $resultSet = $statement->get_result();


 $result = $resultSet->fetch_all();

 $output = '';

 foreach($result as $row)
 {
  $output .= '
  <li class="list-group-item contsearch">
   <a href="javascript:void(0)" class="gsearch" style="color:#333;text-decoration:none;">'.$row['fullName'].'</a>
  </li>
  ';
 }

 echo $output;
}

?>
Posted
Updated 23-Jan-22 4:08am
v2
Comments
Richard MacCutchan 23-Jan-22 14:15pm    
Whatever you are getting from the database, it does not include a column named "fullName". You need to check what result you get from the database before trying to use any results.

1 solution

Don't do it like that! Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'
The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'
Which SQL sees as three separate commands:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';
A perfectly valid SELECT
SQL
DROP TABLE MyTable;
A perfectly valid "delete the table" command
SQL
--'
And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?
 
Share this answer
 

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900