Why else condition is not working>

Question

0.00/5 (No votes)

See more:

I tried to add else condition in my code it is not executing my .batch file.
When I add only if condition it works fine.

Problem getting in apply else condition in the last of the code.

What I have tried:

Cd /d D:


	SetLocal EnableDelayedExpansion
	set "file=newabc.c"
	set var={"abc1
	set var2="};
	for /F "tokens=1,* delims==" %%i in ('findstr "abc[] = " newabc.c') do (
    set "versionVar=%%~i"
    set "versionVal=%%~j"
	set "string=!versionVal:~7,5!"
	set /a "string+=1"
	::set "string=%versionVal:~2,1%"
	::%string:~4,3%
    :: set /a "string=string+1"
	::echo %sequence%
	
	)
	for /f "tokens=1,2 delims=." %%a in ("!versionVal!") do (
    set BEFORE_UNDERSCORE=%%a
    set AFTER_UNDERSCORE=%%b
)
	::echo !BEFORE_UNDERSCORE!
	
	for /f "tokens=1,*delims=]" %%i in ('type "%file%" ^| find /v /n "" ^& break^>%file%') do (
    ::set "line=%%~j"
	if "!BEFORE_UNDERSCORE!" == "!var!" (
	
	set "line=%%~j"
	echo !line! hello
    if "!line!" == "!versionVar!=!versionVal!" set line=!versionVar!=!var!.!string!
    echo(!line!>>!file!)
	
	) else 
	
	 set "line=%%~j"
	 if "!line!" == "!versionVar!=!versionVal!" set line=!versionVar!=!versionVar!=!versionVal!
	 echo !line!>>!file!)
	)
	
	pause

Posted 11-Nov-22 3:15am

Radha sharma 2022

Updated 11-Nov-22 3:33am

Add a Solution

Comments

Richard MacCutchan 11-Nov-22 9:31am

You have not explained exzactly what happens in this script. Just saying "t is not executing" does not tell ius anything useful.

1 solution

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Answer 1 · 2022-11-11T03:33:00

You are missing the opening parenthesis of the ELSE clause. You have:

BAT

) else

It should be:

BAT

) else (

[EDIT]

Your if statements are not correct, you have the following:

BAT

    if "!line!" == "!versionVar!=!versionVal!" set <-- THIS IS INCORRECT
line=!versionVar!=!var!.!string! <-- THE IF PART IS NOT CLOSED
    echo(!line!>>!file!) 
	
	) else <-- THE ELSE CLAUSE IS NOT OPENED
	
	 set "line=%%~j"
	 if "!line!" == "!versionVar!=!versionVal!" set line=!versionVar!=!versionVar!=!versionVal!
	 echo !line!>>!file!)
	)

Try this:

BAT

if "!line!" == "!versionVar!=!versionVal!" (
    set line=!versionVar!=!var!.!string!
    echo(!line!>>!file!) 
    
) else (

    set "line=%%~j"
    if "!line!" == "!versionVar!=!versionVal!" (
        set line=!versionVar!=!versionVar!=!versionVal!
        echo !line!>>!file!
    )
)

And try using consistent and proper indentation so your code is readable.

[/EDIT]

Why else condition is not working>

1 solution

Solution 1

Add your solution here

Preview 0

Why else condition is not working>

1 solution

Solution 1

Add your solution here

Preview 0

Existing Members

...or Join us