Click here to Skip to main content
15,942,765 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
hi I'm new to coding, I'm have a Visual Basic project for the memory game. it basically lets the player flips over 2 cards, if those 2 cards match, they disappear, if they don't, they flip back. the game end when all the cards disappear. I have completed the code but when I run it, it just let me flip the cards when I click; the matched cards didn't disappear, and when time out the msg box don't show up. I don't know what is wrong with my code, and Im new so I only use basic statement like if else, for next, do while,...and I use Visual Basic 2013
please help!!!

What I have tried:

Public Class Easy
    Private Sub Timer1_Tick(sender As Object, e As EventArgs) Handles Timer1.Tick
        lblEasyTime.Text = Val(lblEasyTime.Text) - 1
        If lblEasyTime.Text = 0 Then Timer1.Enabled = False
    End Sub
    Sub check()
        'Private Sub Easy_Load(sender As Object, e As EventArgs) Handles MyBase.Load
        'Declare Variable
        Dim imgCardback(5) As PictureBox
        Dim imgCardfront(5) As PictureBox
        Dim intGuesses As Integer
        Dim intX As Integer
        Dim intY As Integer

        'Initialize variables
        imgCardback(0) = imgJHeart
        imgCardback(1) = imgJHeart2
        imgCardback(2) = imgKHeart
        imgCardback(3) = imgKHeart2
        imgCardback(4) = imgQHeart
        imgCardback(5) = imgQHeart2

        imgCardfront(0) = imgCard1
        imgCardfront(1) = imgCard2
        imgCardfront(2) = imgcard3
        imgCardfront(3) = imgcard4
        imgCardfront(4) = imgcard5
        imgCardfront(5) = imgcard6

        intGuesses = 0

        'Check images
        For intX = 0 To 5
            If imgCardfront(intX).Visible = False Then
                For intY = 0 To 5
                    If imgCardfront(intY).Visible = False Then
                        If intX <> intY And imgCardback(intX).Tag = imgCardback(intY).Tag Then
                            imgCardback(intX).Visible = False
                            imgCardback(intY).Visible = False
                            imgCardfront(intX).Visible = False
                            imgCardfront(intY).Visible = False
                            intGuesses = intGuesses + 1
                        End If
                        If intX <> intY And imgCardback(intX).Tag <> imgCardback(intY).Tag And imgCardback(intX).Visible = True And imgCardback(intY).Visible = True Then
                            imgCardfront(intX).Visible = True
                            imgCardfront(intY).Visible = True
                            intGuesses = intGuesses + 1
                        End If
                    End If
            End If

        If imgCard1.Visible = False And imgCard1.Visible = False And imgCard1.Visible = False And imgCard1.Visible = False And imgCard1.Visible = False And imgCard1.Visible = False And imgJHeart.Visible = False And imgJHeart2.Visible = False And imgKHeart.Visible = False And imgKHeart2.Visible = False And imgQHeart.Visible = False And imgQHeart2.Visible = False Then
            Congratulation.Visible = True
        End If

        Do While lblEasyTime.Text = 0
            MsgBox("Times out!!! Better luck next time.")
    End Sub

    Private Sub imgCard1_Click(sender As Object, e As EventArgs) Handles imgCard1.Click
        imgCard1.Visible = False
    End Sub

    Private Sub imgCard2_Click(sender As Object, e As EventArgs) Handles imgCard2.Click
        imgCard2.Visible = False
    End Sub

    Private Sub imgcard3_Click(sender As Object, e As EventArgs) Handles imgcard3.Click
        imgcard3.Visible = False
    End Sub

    Private Sub imgcard4_Click(sender As Object, e As EventArgs) Handles imgcard4.Click
        imgcard4.Visible = False
    End Sub

    Private Sub imgcard5_Click(sender As Object, e As EventArgs) Handles imgcard5.Click
        imgcard5.Visible = False
    End Sub

    Private Sub imgcard6_Click(sender As Object, e As EventArgs) Handles imgcard6.Click
        imgcard6.Visible = False
    End Sub
End Class
Updated 7-Dec-22 22:54pm

1 solution

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
Private Function Double(ByVal value As Integer) As Integer
    Return value * value
End Function

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
Share this answer
pham thao 2022 8-Dec-22 5:02am    
thanks for your respond, I will spend time to look back my code.
OriginalGriff 8-Dec-22 5:58am    
You're welcome!

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900