How the progress bar works according to the value of the text box?

Question

0.00/5 (No votes)

See more:

Entering 30 inside the textbox should complete the progress bar and entering 300 should complete the progress bar. my actual problem :- When entering 30, the progress bar is completed once and the progress starts again ,And the form should be closed when the progress bar is complete

What I have tried:

C#

 private void form_Load(object sender, EventArgs e)
        {
            backgroundWorker1.WorkerReportsProgress = true;
            backgroundWorker1.RunWorkerAsync();
        }


private void backgroundWorker1_DoWork(object sender, DoWorkEventArgs e)
        {
            int str = textbox1.text;
                for (int i = 0;i <= str; i++)
                {
                    //   updatepicbox();
                    backgroundWorker1.ReportProgress(i);
                    System.Threading.Thread.Sleep(100);
                }
        }


private void backgroundWorker1_ProgressChanged(object sender, ProgressChangedEventArgs e)
        {
            updatepicbox();

            progressBar1.Value = e.ProgressPercentage;
            label1.Text = string.Format("{0}%", e.ProgressPercentage);
            progressBar1.Update();
        }


private void backgroundWorker1_RunWorkerCompleted(object sender, RunWorkerCompletedEventArgs e)
        {
            this.Hide();
        }

Posted 20-Dec-22 19:35pm

Ridhdhi Vaghani

Updated 21-Dec-22 11:20am

Dave Kreskowiak

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2022-12-20T22:09:00

That code won't compile:

C#

int str = textbox1.text;

is not valid C#: "text" is not a property of the TextBox class, "Text" is, and there is no implicit conversion in C# from string to any numeric type.
Additionally, the DoWork delegate is executed on a background worker thread, not the UI thread, so an attempt to access any Control in any way will cause a cross-threading exception - and that includes the TextBox.Text property.

Instead, you need convert the value using Tryparse:

C#

int val;
if (!int.TryParse(textbox1.text, out val))
   {
   ... report problem to user, it's not a number ...
   return;
   }
...

But that code needs to be executed on the GUI thread, not the background worker.

Handle the TextBox.TextChanged method and update a class-level variable which you can check in your worker thread: but do note that you will need to lock variables to prevent problems with multiple thread accesses, that 30 * Sleep(100) is only 3 seconds anyway, and that Hide doesn't close a form - it just removes it from view.

Richard MacCutchan · Answer 2 · 2022-12-20T22:00:00

Solution 3

C#

int str = textbox1.text;

The TextBox Class (System.Windows.Forms) | Microsoft Learn[^] does not have a property named text. If you meant to specify Text, then that is still wrong as the Text property returns a string not an int.

Posted 20-Dec-22 22:00pm

Richard MacCutchan

Richard Deeming · Answer 3 · 2022-12-20T22:00:00

A TextBox does not have a text property. The property is called Text - remember, C# is case-sensitive.

The Text property returns a string. You cannot assign that value to an int variable.

(I'm starting to suspect you're trying to convert some code from VB.NET here.)

The parameter to the ReportProgress method[^] is documented as "the percentage, from 0 to 100, of the background operation that is complete". However, in reality, there is no validation on the value you pass in. But if you use it to update a progress bar, it should be between the Minimum and Maximum values for that progress bar.

Fixing those errors gives you:

C#

private void Form_Load(object sender, EventArgs e)
{
    if (!int.TryParse(textbox1.Text, out int maximum)) maximum = 100;
    
    progressBar1.Minimum = 0;
    progressBar1.Maximum = maximum;
    
    backgroundWorker1.WorkerReportsProgress = true;
    backgroundWorker1.RunWorkerAsync(maximum);
}

private void backgroundWorker1_DoWork(object sender, DoWorkEventArgs e)
{
    int maximum = (int)e.Argument;
    for (int i = 0; i <= maximum; i++)
    {
        backgroundWorker1.ReportProgress(i);
        System.Threading.Thread.Sleep(100);
    }
}

private void backgroundWorker1_ProgressChanged(object sender, ProgressChangedEventArgs e)
{
    updatepicbox();

    progressBar1.Value = e.ProgressPercentage;
    
    double percentComplete = (double)e.ProgressPercentage / progressBar1.Maximum;
    label1.Text = percentComplete.ToString("P0");
}

How the progress bar works according to the value of the text box?

3 solutions

Solution 4

Solution 3

Solution 2

Add your solution here

Preview 0